donglora/firmware
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: unify SimpleLed via embedded-hal, remove Option<L> from BoardParts

Browse Source 
- Added embedded-hal 1.0 as direct dep (already transitive via embedded-hal-async)
- SimpleLed<P: OutputPin> now generic over any HAL — single definition in driver/
- Removed duplicate SimpleLed from board/esp32s3.rs and board/wio_tracker_l1.rs
- Changed BoardParts.led from Option<L> to L — boards with no LED use ()
- Display task calls led.set_rgb() unconditionally (no-op for () boards)
- RAK board: led: () instead of led: None
This commit is contained in:
swaits committed 2026-04-07 12:40:55 -06:00
1 parent f9117d71c8
commit 41b5775268
12 files changed
+50 -59
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/display.rs
+12 -18
View File
@@ -109,7 +109,7 @@ fn render_current(
#[task]
pub async fn display_task(
parts: DisplayParts,
mut led: Option<LedDriver>,
mut led: LedDriver,
status: &'static StatusWatch,
display_commands: &'static DisplayCommandChannel,
) {
@@ -176,17 +176,15 @@ pub async fn display_task(
let _ = display.flush().await;
// Brief LED blink: red on TX, green scaled by SNR on RX
if let Some(ref mut led) = led {
if tx_packet {
led.set_rgb(32, 0, 0).await;
Timer::after_millis(50).await;
led.set_rgb(0, 0, 0).await;
} else if rx_packet {
let b = snr_brightness(last_snr);
led.set_rgb(0, b, 0).await;
Timer::after_millis(50).await;
led.set_rgb(0, 0, 0).await;
}
if tx_packet {
led.set_rgb(32, 0, 0).await;
Timer::after_millis(50).await;
led.set_rgb(0, 0, 0).await;
} else if rx_packet {
let b = snr_brightness(last_snr);
led.set_rgb(0, b, 0).await;
Timer::after_millis(50).await;
led.set_rgb(0, 0, 0).await;
}
}
}
@@ -196,9 +194,7 @@ pub async fn display_task(
state.display_on = false;
render::blank(&mut display);
let _ = display.flush().await;
if let Some(ref mut led) = led {
led.set_rgb(0, 0, 0).await;
}
led.set_rgb(0, 0, 0).await;
}
DisplayCommand::On => {
state.disconnected = false;
@@ -213,9 +209,7 @@ pub async fn display_task(
state = DisplayState::new();
render::splash(&mut display, &board_info);
let _ = display.flush().await;
if let Some(ref mut led) = led {
led.set_rgb(0, 0, 0).await;
}
led.set_rgb(0, 0, 0).await;
}
},
Either3::Third(()) => {