Fix cargo test and a number of little cleanup bugs

This commit is contained in:
Jonathan Kelley committed 2024-01-30 17:33:14 -08:00
1 parent eff1dd6c90
commit 0bd9692e45
49 files changed
+307 -309

No files matched your search

+14 -14
View File
@@ -361,10 +361,10 @@ mod tests {
LineColumn { line: 3, column: 24 },
),
Span::new_from_str(
r#"use_state"#,
r#"use_signal"#,
LineColumn { line: 3, column: 24 },
),
"use_state".to_string()
"use_signal".to_string()
),
ConditionalInfo::If(IfInfo::new(
Span::new_from_str(
@@ -401,8 +401,8 @@ mod tests {
vec![Issue::HookInsideConditional(
HookInfo::new(
Span::new_from_str(r#"use_signal(|| "hands")"#, LineColumn { line: 4, column: 28 }),
Span::new_from_str(r#"use_state"#, LineColumn { line: 4, column: 28 }),
"use_state".to_string()
Span::new_from_str(r#"use_signal"#, LineColumn { line: 4, column: 28 }),
"use_signal".to_string()
),
ConditionalInfo::Match(MatchInfo::new(
Span::new_from_str(
@@ -437,10 +437,10 @@ mod tests {
LineColumn { line: 3, column: 26 },
),
Span::new_from_str(
"use_state",
"use_signal",
LineColumn { line: 3, column: 26 },
),
"use_state".to_string()
"use_signal".to_string()
),
AnyLoopInfo::For(ForInfo::new(
Span::new_from_str(
@@ -478,10 +478,10 @@ mod tests {
LineColumn { line: 3, column: 24 },
),
Span::new_from_str(
"use_state",
"use_signal",
LineColumn { line: 3, column: 24 },
),
"use_state".to_string()
"use_signal".to_string()
),
AnyLoopInfo::While(WhileInfo::new(
Span::new_from_str(
@@ -519,10 +519,10 @@ mod tests {
LineColumn { line: 3, column: 24 },
),
Span::new_from_str(
"use_state",
"use_signal",
LineColumn { line: 3, column: 24 },
),
"use_state".to_string()
"use_signal".to_string()
),
AnyLoopInfo::Loop(LoopInfo::new(Span::new_from_str(
"loop {\n let something = use_signal(|| \"hands\");\n println!(\"clap your {something}\")\n }",
@@ -573,13 +573,13 @@ mod tests {
},
),
Span::new_from_str(
"use_state",
"use_signal",
LineColumn {
line: 3,
column: 16
},
),
"use_state".to_string()
"use_signal".to_string()
),
ClosureInfo::new(Span::new_from_str(
"|| {\n let b = use_signal(|| 0);\n b.get()\n }",
@@ -613,13 +613,13 @@ mod tests {
}
),
Span::new_from_str(
"use_state",
"use_signal",
LineColumn {
line: 2,
column: 13
},
),
"use_state".to_string()
"use_signal".to_string()
))]
);
}
+14 -14
View File
@@ -240,11 +240,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called conditionally: `use_state` (inside `if`)
error: hook called conditionally: `use_signal` (inside `if`)
--> src/main.rs:3:25
|
3 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
|
= note: `if you_are_happy && you_know_it { … }` is the conditional
"#};
@@ -271,11 +271,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called conditionally: `use_state` (inside `match`)
error: hook called conditionally: `use_signal` (inside `match`)
--> src/main.rs:4:29
|
4 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
|
= note: `match you_are_happy && you_know_it { … }` is the conditional
"#};
@@ -299,11 +299,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called in a loop: `use_state` (inside `for` loop)
error: hook called in a loop: `use_signal` (inside `for` loop)
--> src/main.rs:3:25
|
3 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
|
= note: `for i in 0..10 { … }` is the loop
"#};
@@ -327,11 +327,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called in a loop: `use_state` (inside `while` loop)
error: hook called in a loop: `use_signal` (inside `while` loop)
--> src/main.rs:3:25
|
3 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
|
= note: `while check_thing() { … }` is the loop
"#};
@@ -355,11 +355,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called in a loop: `use_state` (inside `loop`)
error: hook called in a loop: `use_signal` (inside `loop`)
--> src/main.rs:3:25
|
3 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
|
= note: `loop { … }` is the loop
"#};
@@ -383,11 +383,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called in a closure: `use_state`
error: hook called in a closure: `use_signal`
--> src/main.rs:3:25
|
3 | let something = use_signal(|| "hands");
| ^^^^^^^^^
| ^^^^^^^^^^
"#};
assert_eq!(expected, issue_report.to_string());
@@ -411,11 +411,11 @@ mod tests {
);
let expected = indoc! {r#"
error: hook called conditionally: `use_state` (inside `if`)
error: hook called conditionally: `use_signal` (inside `if`)
--> src/main.rs:3:25
|
3 | let something = use_signal(|| {
| ^^^^^^^^^
| ^^^^^^^^^^
4 | "hands"
5 | });
|