swaits/dioxus
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #915 from Demonthos/fix-empty-mutations

Browse Source 
Don't add no op mutations when diffing lists
This commit is contained in:
Jon Kelley authored and GitHub committed 2023-03-28 16:17:25 -07:00
2 parents 51c388ce1f 3bb6c4bc30
commit 0fd93e74c2
1 file changed
+18 -12
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/diff.rs
+18 -12
View File
@@ -628,10 +628,12 @@ impl<'b> VirtualDom {
} }
let id = self.find_last_element(&new[last]); let id = self.find_last_element(&new[last]);
self.mutations.push(Mutation::InsertAfter { if nodes_created > 0 {
id, self.mutations.push(Mutation::InsertAfter {
m: nodes_created, id,
}); m: nodes_created,
})
}
nodes_created = 0; nodes_created = 0;
} }
@@ -652,10 +654,12 @@ impl<'b> VirtualDom {
} }
let id = self.find_first_element(&new[last]); let id = self.find_first_element(&new[last]);
self.mutations.push(Mutation::InsertBefore { if nodes_created > 0 {
id, self.mutations.push(Mutation::InsertBefore {
m: nodes_created, id,
}); m: nodes_created,
});
}
nodes_created = 0; nodes_created = 0;
} }
@@ -676,10 +680,12 @@ impl<'b> VirtualDom {
} }
let id = self.find_first_element(&new[first_lis]); let id = self.find_first_element(&new[first_lis]);
self.mutations.push(Mutation::InsertBefore { if nodes_created > 0 {
id, self.mutations.push(Mutation::InsertBefore {
m: nodes_created, id,
}); m: nodes_created,
});
}
} }
} }