wip: web now links against the js interprter code
This commit is contained in:
1 parent
5bf6c96f9f
commit
10db6ad65b
10 files changed
+1661
-645
No files matched your search
+27
-392
@@ -7,10 +7,11 @@
|
||||
//! - tests to ensure dyn_into works for various event types.
|
||||
//! - Partial delegation?>
|
||||
|
||||
use crate::bindings::Interpreter;
|
||||
use dioxus_core::{DomEdit, ElementId, SchedulerMsg, ScopeId, UserEvent};
|
||||
use fxhash::FxHashMap;
|
||||
use std::{any::Any, fmt::Debug, rc::Rc, sync::Arc};
|
||||
use wasm_bindgen::{closure::Closure, JsCast};
|
||||
use wasm_bindgen::{closure::Closure, JsCast, JsValue};
|
||||
use web_sys::{
|
||||
CssStyleDeclaration, Document, Element, Event, HtmlElement, HtmlInputElement,
|
||||
HtmlOptionElement, HtmlTextAreaElement, Node,
|
||||
@@ -19,13 +20,10 @@ use web_sys::{
|
||||
use crate::{nodeslab::NodeSlab, WebConfig};
|
||||
|
||||
pub struct WebsysDom {
|
||||
stack: Stack,
|
||||
|
||||
/// A map from ElementID (index) to Node
|
||||
pub(crate) nodes: NodeSlab,
|
||||
|
||||
document: Document,
|
||||
|
||||
pub interpreter: Interpreter,
|
||||
|
||||
pub(crate) root: Element,
|
||||
|
||||
sender_callback: Rc<dyn Fn(SchedulerMsg)>,
|
||||
@@ -42,7 +40,6 @@ impl WebsysDom {
|
||||
pub fn new(cfg: WebConfig, sender_callback: Rc<dyn Fn(SchedulerMsg)>) -> Self {
|
||||
let document = load_document();
|
||||
|
||||
let nodes = NodeSlab::new(2000);
|
||||
let listeners = FxHashMap::default();
|
||||
|
||||
let mut stack = Stack::with_capacity(10);
|
||||
@@ -52,8 +49,7 @@ impl WebsysDom {
|
||||
stack.push(root_node);
|
||||
|
||||
Self {
|
||||
stack,
|
||||
nodes,
|
||||
interpreter: Interpreter::new(root.clone()),
|
||||
listeners,
|
||||
document,
|
||||
sender_callback,
|
||||
@@ -64,399 +60,38 @@ impl WebsysDom {
|
||||
pub fn apply_edits(&mut self, mut edits: Vec<DomEdit>) {
|
||||
for edit in edits.drain(..) {
|
||||
match edit {
|
||||
DomEdit::PushRoot { root } => self.push(root),
|
||||
DomEdit::AppendChildren { many } => self.append_children(many),
|
||||
DomEdit::ReplaceWith { m, root } => self.replace_with(m, root),
|
||||
DomEdit::Remove { root } => self.remove(root),
|
||||
DomEdit::CreateTextNode { text, root: id } => self.create_text_node(text, id),
|
||||
DomEdit::CreateElement { tag, root: id } => self.create_element(tag, None, id),
|
||||
DomEdit::CreateElementNs { tag, root: id, ns } => {
|
||||
self.create_element(tag, Some(ns), id)
|
||||
DomEdit::PushRoot { root } => self.interpreter.PushRoot(root),
|
||||
DomEdit::AppendChildren { many } => self.interpreter.AppendChildren(many),
|
||||
DomEdit::ReplaceWith { root, m } => self.interpreter.ReplaceWith(root, m),
|
||||
DomEdit::InsertAfter { root, n } => self.interpreter.InsertAfter(root, n),
|
||||
DomEdit::InsertBefore { root, n } => self.interpreter.InsertBefore(root, n),
|
||||
DomEdit::Remove { root } => self.interpreter.Remove(root),
|
||||
DomEdit::CreateTextNode { text, root } => {
|
||||
self.interpreter.CreateTextNode(text, root)
|
||||
}
|
||||
DomEdit::CreatePlaceholder { root: id } => self.create_placeholder(id),
|
||||
DomEdit::CreateElement { tag, root } => self.interpreter.CreateElement(tag, root),
|
||||
DomEdit::CreateElementNs { tag, root, ns } => {
|
||||
self.interpreter.CreateElementNs(tag, root, ns)
|
||||
}
|
||||
DomEdit::CreatePlaceholder { root } => self.interpreter.CreatePlaceholder(root),
|
||||
DomEdit::NewEventListener {
|
||||
event_name,
|
||||
scope,
|
||||
root: mounted_node_id,
|
||||
} => self.new_event_listener(event_name, scope, mounted_node_id),
|
||||
|
||||
DomEdit::RemoveEventListener { event, root } => {
|
||||
self.remove_event_listener(event, root)
|
||||
root,
|
||||
} => self.interpreter.NewEventListener(event_name, scope.0, root),
|
||||
DomEdit::RemoveEventListener { root, event } => {
|
||||
self.interpreter.RemoveEventListener(root, event)
|
||||
}
|
||||
|
||||
DomEdit::SetText { text, root } => self.set_text(text, root),
|
||||
DomEdit::SetText { root, text } => self.interpreter.SetText(root, text),
|
||||
DomEdit::SetAttribute {
|
||||
root,
|
||||
field,
|
||||
value,
|
||||
ns,
|
||||
root,
|
||||
} => self.set_attribute(field, value, ns, root),
|
||||
DomEdit::RemoveAttribute { name, root } => self.remove_attribute(name, root),
|
||||
|
||||
DomEdit::InsertAfter { n, root } => self.insert_after(n, root),
|
||||
DomEdit::InsertBefore { n, root } => self.insert_before(n, root),
|
||||
}
|
||||
}
|
||||
}
|
||||
fn push(&mut self, root: u64) {
|
||||
let key = root as usize;
|
||||
let domnode = &self.nodes[key];
|
||||
|
||||
let real_node: Node = match domnode {
|
||||
Some(n) => n.clone(),
|
||||
None => todo!(),
|
||||
};
|
||||
|
||||
self.stack.push(real_node);
|
||||
}
|
||||
|
||||
fn append_children(&mut self, many: u32) {
|
||||
let root: Node = self
|
||||
.stack
|
||||
.list
|
||||
.get(self.stack.list.len() - (1 + many as usize))
|
||||
.unwrap()
|
||||
.clone();
|
||||
|
||||
// We need to make sure to add comments between text nodes
|
||||
// We ensure that the text siblings are patched by preventing the browser from merging
|
||||
// neighboring text nodes. Originally inspired by some of React's work from 2016.
|
||||
// -> https://reactjs.org/blog/2016/04/07/react-v15.html#major-changes
|
||||
// -> https://github.com/facebook/react/pull/5753
|
||||
/*
|
||||
todo: we need to track this for replacing/insert after/etc
|
||||
*/
|
||||
let mut last_node_was_text = false;
|
||||
|
||||
for child in self
|
||||
.stack
|
||||
.list
|
||||
.drain((self.stack.list.len() - many as usize)..)
|
||||
{
|
||||
if child.dyn_ref::<web_sys::Text>().is_some() {
|
||||
if last_node_was_text {
|
||||
let comment_node = self
|
||||
.document
|
||||
.create_comment("dioxus")
|
||||
.dyn_into::<Node>()
|
||||
.unwrap();
|
||||
root.append_child(&comment_node).unwrap();
|
||||
} => self.interpreter.SetAttribute(root, field, value, ns),
|
||||
DomEdit::RemoveAttribute { root, name } => {
|
||||
self.interpreter.RemoveAttribute(root, name)
|
||||
}
|
||||
last_node_was_text = true;
|
||||
} else {
|
||||
last_node_was_text = false;
|
||||
}
|
||||
root.append_child(&child).unwrap();
|
||||
}
|
||||
}
|
||||
|
||||
fn replace_with(&mut self, m: u32, root: u64) {
|
||||
let old = self.nodes[root as usize].as_ref().unwrap();
|
||||
|
||||
let arr: js_sys::Array = self
|
||||
.stack
|
||||
.list
|
||||
.drain((self.stack.list.len() - m as usize)..)
|
||||
.collect();
|
||||
|
||||
if let Some(el) = old.dyn_ref::<Element>() {
|
||||
el.replace_with_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = old.dyn_ref::<web_sys::CharacterData>() {
|
||||
el.replace_with_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = old.dyn_ref::<web_sys::DocumentType>() {
|
||||
el.replace_with_with_node(&arr).unwrap();
|
||||
}
|
||||
}
|
||||
|
||||
fn remove(&mut self, root: u64) {
|
||||
let node = self.nodes[root as usize].as_ref().unwrap();
|
||||
if let Some(element) = node.dyn_ref::<Element>() {
|
||||
element.remove();
|
||||
} else {
|
||||
if let Some(parent) = node.parent_node() {
|
||||
parent.remove_child(&node).unwrap();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn create_placeholder(&mut self, id: u64) {
|
||||
self.create_element("pre", None, id);
|
||||
self.set_attribute("hidden", "", None, id);
|
||||
}
|
||||
|
||||
fn create_text_node(&mut self, text: &str, id: u64) {
|
||||
let textnode = self
|
||||
.document
|
||||
.create_text_node(text)
|
||||
.dyn_into::<Node>()
|
||||
.unwrap();
|
||||
|
||||
self.stack.push(textnode.clone());
|
||||
|
||||
self.nodes[(id as usize)] = Some(textnode);
|
||||
}
|
||||
|
||||
fn create_element(&mut self, tag: &str, ns: Option<&'static str>, id: u64) {
|
||||
let tag = wasm_bindgen::intern(tag);
|
||||
|
||||
let el = match ns {
|
||||
Some(ns) => self
|
||||
.document
|
||||
.create_element_ns(Some(ns), tag)
|
||||
.unwrap()
|
||||
.dyn_into::<Node>()
|
||||
.unwrap(),
|
||||
None => self
|
||||
.document
|
||||
.create_element(tag)
|
||||
.unwrap()
|
||||
.dyn_into::<Node>()
|
||||
.unwrap(),
|
||||
};
|
||||
|
||||
use smallstr::SmallString;
|
||||
use std::fmt::Write;
|
||||
|
||||
let mut s: SmallString<[u8; 8]> = smallstr::SmallString::new();
|
||||
write!(s, "{}", id).unwrap();
|
||||
|
||||
let el2 = el.dyn_ref::<Element>().unwrap();
|
||||
el2.set_attribute("dioxus-id", s.as_str()).unwrap();
|
||||
|
||||
self.stack.push(el.clone());
|
||||
self.nodes[(id as usize)] = Some(el);
|
||||
}
|
||||
|
||||
fn new_event_listener(&mut self, event: &'static str, _scope: ScopeId, _real_id: u64) {
|
||||
let event = wasm_bindgen::intern(event);
|
||||
|
||||
// attach the correct attributes to the element
|
||||
// these will be used by accessing the event's target
|
||||
// This ensures we only ever have one handler attached to the root, but decide
|
||||
// dynamically when we want to call a listener.
|
||||
|
||||
let el = self.stack.top();
|
||||
|
||||
let el = el.dyn_ref::<Element>().unwrap();
|
||||
|
||||
el.set_attribute("dioxus-event", event).unwrap();
|
||||
|
||||
// Register the callback to decode
|
||||
|
||||
if let Some(entry) = self.listeners.get_mut(event) {
|
||||
entry.0 += 1;
|
||||
} else {
|
||||
let trigger = self.sender_callback.clone();
|
||||
|
||||
let c: Box<dyn FnMut(&Event)> = Box::new(move |event: &web_sys::Event| {
|
||||
// "Result" cannot be received from JS
|
||||
// Instead, we just build and immediately execute a closure that returns result
|
||||
match decode_trigger(event) {
|
||||
Ok(synthetic_event) => {
|
||||
let target = event.target().unwrap();
|
||||
if let Some(node) = target.dyn_ref::<HtmlElement>() {
|
||||
if let Some(name) = node.get_attribute("dioxus-prevent-default") {
|
||||
if name == synthetic_event.name
|
||||
|| name.trim_start_matches("on") == synthetic_event.name
|
||||
{
|
||||
log::trace!("Preventing default");
|
||||
event.prevent_default();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
trigger.as_ref()(SchedulerMsg::Event(synthetic_event))
|
||||
}
|
||||
Err(e) => log::error!("Error decoding Dioxus event attribute. {:#?}", e),
|
||||
};
|
||||
});
|
||||
|
||||
let handler = Closure::wrap(c);
|
||||
|
||||
self.root
|
||||
.add_event_listener_with_callback(event, (&handler).as_ref().unchecked_ref())
|
||||
.unwrap();
|
||||
|
||||
// Increment the listeners
|
||||
self.listeners.insert(event.into(), (1, handler));
|
||||
}
|
||||
}
|
||||
|
||||
fn remove_event_listener(&mut self, _event: &str, _root: u64) {
|
||||
todo!()
|
||||
}
|
||||
|
||||
fn set_text(&mut self, text: &str, root: u64) {
|
||||
let el = self.nodes[root as usize].as_ref().unwrap();
|
||||
el.set_text_content(Some(text))
|
||||
}
|
||||
|
||||
fn set_attribute(&mut self, name: &str, value: &str, ns: Option<&str>, root: u64) {
|
||||
let node = self.nodes[root as usize].as_ref().unwrap();
|
||||
if ns == Some("style") {
|
||||
if let Some(el) = node.dyn_ref::<Element>() {
|
||||
let el = el.dyn_ref::<HtmlElement>().unwrap();
|
||||
let style_dc: CssStyleDeclaration = el.style();
|
||||
style_dc.set_property(name, value).unwrap();
|
||||
}
|
||||
} else {
|
||||
let fallback = || {
|
||||
let el = node.dyn_ref::<Element>().unwrap();
|
||||
el.set_attribute(name, value).unwrap()
|
||||
};
|
||||
match name {
|
||||
"dangerous_inner_html" => {
|
||||
if let Some(el) = node.dyn_ref::<Element>() {
|
||||
el.set_inner_html(value);
|
||||
}
|
||||
}
|
||||
"value" => {
|
||||
if let Some(input) = node.dyn_ref::<HtmlInputElement>() {
|
||||
/*
|
||||
if the attribute being set is the same as the value of the input, then don't bother setting it.
|
||||
This is used in controlled components to keep the cursor in the right spot.
|
||||
|
||||
this logic should be moved into the virtualdom since we have the notion of "volatile"
|
||||
*/
|
||||
if input.value() != value {
|
||||
input.set_value(value);
|
||||
}
|
||||
} else if let Some(node) = node.dyn_ref::<HtmlTextAreaElement>() {
|
||||
if name == "value" {
|
||||
node.set_value(value);
|
||||
}
|
||||
} else {
|
||||
fallback();
|
||||
}
|
||||
}
|
||||
"checked" => {
|
||||
if let Some(input) = node.dyn_ref::<HtmlInputElement>() {
|
||||
match value {
|
||||
"true" => input.set_checked(true),
|
||||
"false" => input.set_checked(false),
|
||||
_ => fallback(),
|
||||
}
|
||||
} else {
|
||||
fallback();
|
||||
}
|
||||
}
|
||||
"selected" => {
|
||||
if let Some(node) = node.dyn_ref::<HtmlOptionElement>() {
|
||||
node.set_selected(true);
|
||||
} else {
|
||||
fallback();
|
||||
}
|
||||
}
|
||||
_ => {
|
||||
// https://github.com/facebook/react/blob/8b88ac2592c5f555f315f9440cbb665dd1e7457a/packages/react-dom/src/shared/DOMProperty.js#L352-L364
|
||||
if value == "false" {
|
||||
if let Some(el) = node.dyn_ref::<Element>() {
|
||||
match name {
|
||||
"allowfullscreen"
|
||||
| "allowpaymentrequest"
|
||||
| "async"
|
||||
| "autofocus"
|
||||
| "autoplay"
|
||||
| "checked"
|
||||
| "controls"
|
||||
| "default"
|
||||
| "defer"
|
||||
| "disabled"
|
||||
| "formnovalidate"
|
||||
| "hidden"
|
||||
| "ismap"
|
||||
| "itemscope"
|
||||
| "loop"
|
||||
| "multiple"
|
||||
| "muted"
|
||||
| "nomodule"
|
||||
| "novalidate"
|
||||
| "open"
|
||||
| "playsinline"
|
||||
| "readonly"
|
||||
| "required"
|
||||
| "reversed"
|
||||
| "selected"
|
||||
| "truespeed" => {
|
||||
let _ = el.remove_attribute(name);
|
||||
}
|
||||
_ => {
|
||||
let _ = el.set_attribute(name, value);
|
||||
}
|
||||
};
|
||||
}
|
||||
} else {
|
||||
fallback();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn remove_attribute(&mut self, name: &str, root: u64) {
|
||||
let node = self.nodes[root as usize].as_ref().unwrap();
|
||||
if let Some(node) = node.dyn_ref::<web_sys::Element>() {
|
||||
node.remove_attribute(name).unwrap();
|
||||
}
|
||||
if let Some(node) = node.dyn_ref::<HtmlInputElement>() {
|
||||
// Some attributes are "volatile" and don't work through `removeAttribute`.
|
||||
if name == "value" {
|
||||
node.set_value("");
|
||||
}
|
||||
if name == "checked" {
|
||||
node.set_checked(false);
|
||||
}
|
||||
}
|
||||
|
||||
if let Some(node) = node.dyn_ref::<HtmlOptionElement>() {
|
||||
if name == "selected" {
|
||||
node.set_selected(true);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn insert_after(&mut self, n: u32, root: u64) {
|
||||
let old = self.nodes[root as usize].as_ref().unwrap();
|
||||
|
||||
let arr: js_sys::Array = self
|
||||
.stack
|
||||
.list
|
||||
.drain((self.stack.list.len() - n as usize)..)
|
||||
.collect();
|
||||
|
||||
if let Some(el) = old.dyn_ref::<Element>() {
|
||||
el.after_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = old.dyn_ref::<web_sys::CharacterData>() {
|
||||
el.after_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = old.dyn_ref::<web_sys::DocumentType>() {
|
||||
el.after_with_node(&arr).unwrap();
|
||||
}
|
||||
}
|
||||
|
||||
fn insert_before(&mut self, n: u32, root: u64) {
|
||||
let anchor = self.nodes[root as usize].as_ref().unwrap();
|
||||
|
||||
if n == 1 {
|
||||
let before = self.stack.pop();
|
||||
|
||||
anchor
|
||||
.parent_node()
|
||||
.unwrap()
|
||||
.insert_before(&before, Some(&anchor))
|
||||
.unwrap();
|
||||
} else {
|
||||
let arr: js_sys::Array = self
|
||||
.stack
|
||||
.list
|
||||
.drain((self.stack.list.len() - n as usize)..)
|
||||
.collect();
|
||||
|
||||
if let Some(el) = anchor.dyn_ref::<Element>() {
|
||||
el.before_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = anchor.dyn_ref::<web_sys::CharacterData>() {
|
||||
el.before_with_node(&arr).unwrap();
|
||||
} else if let Some(el) = anchor.dyn_ref::<web_sys::DocumentType>() {
|
||||
el.before_with_node(&arr).unwrap();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user