Change the semantics of exprs/for loops allocations strategy

This commit adjusts how exprs and for loops are handled within
rsx. This is a breaking change in terms of codegen, but has
slight semantic changes as well.

Now, when exprs/for loops are allocated, they are given a temporary.
The temporary is elided to the <'a> lifetime of the bump, to satisfy
the borrow checker. This fixes issues with signals where exprs/for
loops mapping vecs out of RefCells would be caught up without a
temporary lifetime.
This commit is contained in:
Jonathan Kelley committed 2023-10-15 17:40:56 -07:00
1 parent 04f83e1e92
commit 14b3fa72e4
2 files changed
+24 -4

No files matched your search

+13 -4
View File
@@ -125,7 +125,11 @@ impl ToTokens for BodyNode {
__cx.text_node(#txt)
}),
BodyNode::RawExpr(exp) => tokens.append_all(quote! {
__cx.make_node(#exp)
{
use ::dioxus::core::IntoDynNode;
let ___nodes =(#exp).into_vnode(__cx);
___nodes
}
}),
BodyNode::ForLoop(exp) => {
let ForLoop {
@@ -137,10 +141,15 @@ impl ToTokens for BodyNode {
location: None,
};
// Signals expose an issue with temporary lifetimes
// We need to directly render out the nodes first to collapse their lifetime to <'a>
// And then we can return them into the dyn loop
tokens.append_all(quote! {
__cx.make_node(
(#expr).into_iter().map(|#pat| { #renderer })
)
{
use ::dioxus::core::IntoDynNode;
let ___nodes =(#expr).into_iter().map(|#pat| { #renderer }).into_vnode(__cx);
___nodes
}
})
}
BodyNode::IfChain(chain) => {