diff --git a/Cargo.lock b/Cargo.lock index 6139975c1..234fc4527 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -12371,11 +12371,12 @@ dependencies = [ [[package]] name = "warnings" -version = "0.2.0" +version = "0.2.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d0c672c7629eeed21c37d7a96ee9c0287b86a5e29b5730773117e4261d1a73ca" +checksum = "64f68998838dab65727c9b30465595c6f7c953313559371ca8bf31759b3680ad" dependencies = [ "pin-project", + "tracing", "warnings-macro", ] diff --git a/Cargo.toml b/Cargo.toml index 715c9c3ca..eb25a6fc7 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -142,7 +142,7 @@ manganis = { path = "packages/manganis/manganis", version = "0.6.0-alpha.4" } manganis-core = { path = "packages/manganis/manganis-core", version = "0.6.0-alpha.4" } manganis-macro = { path = "packages/manganis/manganis-macro", version = "0.6.0-alpha.4" } -warnings = { version = "0.2.0" } +warnings = { version = "0.2.1" } # a fork of pretty please for tests - let's get off of this if we can! diff --git a/packages/signals/src/read_only_signal.rs b/packages/signals/src/read_only_signal.rs index 14540892e..d5d95348b 100644 --- a/packages/signals/src/read_only_signal.rs +++ b/packages/signals/src/read_only_signal.rs @@ -52,7 +52,12 @@ impl>> ReadOnlySignal { /// Mark any readers of the signal as dirty pub fn mark_dirty(&mut self) { use crate::write::Writable; - _ = self.inner.try_write(); + use warnings::Warning; + // We diff props while rendering, but we only write to the signal if it has + // changed so it is safe to ignore the warning + crate::warnings::signal_write_in_component_body::allow(|| { + _ = self.inner.try_write(); + }); } }