fix: automatic rebuilds, num_threads for localpools (#4583)

* fix: automatic rebuilds

* Fix concurrency for locapoolhandle
This commit is contained in:
Jonathan Kelley authored and GitHub committed 2025-08-19 17:50:16 -07:00
1 parent 74163984be
commit 23908b9d49
5 files changed
+27 -8

No files matched your search

+3 -2
View File
@@ -267,13 +267,14 @@ pub(crate) async fn serve_all(args: ServeArgs, tracer: &TraceController) -> Resu
}
ServeUpdate::ToggleShouldRebuild => {
use crate::styles::{ERROR, NOTE_STYLE};
builder.automatic_rebuilds = !builder.automatic_rebuilds;
tracing::info!(
"Automatic rebuilds are currently: {}",
if builder.automatic_rebuilds {
"enabled"
format!("{NOTE_STYLE}enabled{NOTE_STYLE:#}")
} else {
"disabled"
format!("{ERROR}disabled{ERROR:#}")
}
)
}
+9 -1
View File
@@ -492,7 +492,7 @@ impl AppServer {
// todo - we need to distinguish between hotpatchable rebuilds and true full rebuilds.
// A full rebuild is required when the user modifies static initializers which we haven't wired up yet.
if needs_full_rebuild {
if needs_full_rebuild && self.automatic_rebuilds {
if self.use_hotpatch_engine {
self.client.patch_rebuild(files.to_vec());
if let Some(server) = self.server.as_mut() {
@@ -526,6 +526,14 @@ impl AppServer {
let file =
file.trim_start_matches(&self.client.build.crate_dir().display().to_string());
if needs_full_rebuild && !self.automatic_rebuilds {
use crate::styles::NOTE_STYLE;
tracing::warn!(
"Ignoring full rebuild for: {NOTE_STYLE}{}{NOTE_STYLE:#}",
file
);
}
// Only send a hotreload message for templates and assets - otherwise we'll just get a full rebuild
//
// todo: move the android file uploading out of hotreload_bundled_asset and