From 25f02904e9977f20b39cb09a17842798acd37a06 Mon Sep 17 00:00:00 2001
From: Evan Almloff <evanalmloff@gmail.com>
Date: Tue, 8 Aug 2023 11:39:36 -0700
Subject: [PATCH] make clippy happy

---
 packages/desktop/src/protocol.rs     |  9 +++++++--
 packages/html/src/eval.rs            |  2 +-
 packages/native-core/src/real_dom.rs |  1 -
 packages/rsx/src/lib.rs              | 10 ++--------
 packages/ssr/src/cache.rs            |  2 +-
 packages/ssr/src/renderer.rs         |  2 +-
 6 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/packages/desktop/src/protocol.rs b/packages/desktop/src/protocol.rs
index 89ce50a48..53652f82f 100644
--- a/packages/desktop/src/protocol.rs
+++ b/packages/desktop/src/protocol.rs
@@ -158,8 +158,13 @@ fn get_mime_from_path(trimmed: &Path) -> Result<&'static str> {
     }
 
     let res = match infer::get_from_path(trimmed)?.map(|f| f.mime_type()) {
-        Some(t) if t == "text/plain" => get_mime_by_ext(trimmed),
-        Some(f) => f,
+        Some(f) => {
+            if f == "text/plain" {
+                get_mime_by_ext(trimmed)
+            } else {
+                f
+            }
+        }
         None => get_mime_by_ext(trimmed),
     };
 
diff --git a/packages/html/src/eval.rs b/packages/html/src/eval.rs
index b39eef805..c90f5125b 100644
--- a/packages/html/src/eval.rs
+++ b/packages/html/src/eval.rs
@@ -42,7 +42,7 @@ pub fn use_eval(cx: &ScopeState) -> &EvalCreator {
         Rc::new(move |script: &str| {
             eval_provider
                 .new_evaluator(script.to_string())
-                .map(|evaluator| UseEval::new(evaluator))
+                .map(UseEval::new)
         }) as Rc<dyn Fn(&str) -> Result<UseEval, EvalError>>
     })
 }
diff --git a/packages/native-core/src/real_dom.rs b/packages/native-core/src/real_dom.rs
index 44c378ddf..b520b2de1 100644
--- a/packages/native-core/src/real_dom.rs
+++ b/packages/native-core/src/real_dom.rs
@@ -446,7 +446,6 @@ impl<V: FromAnyValue + Send + Sync> RealDom<V> {
             drop(tree);
             children.reverse();
             if let Some(node) = self.get_mut(id) {
-                let node = node;
                 f(node);
                 stack.extend(children.iter());
             }
diff --git a/packages/rsx/src/lib.rs b/packages/rsx/src/lib.rs
index 1f01fcd72..783dd3322 100644
--- a/packages/rsx/src/lib.rs
+++ b/packages/rsx/src/lib.rs
@@ -288,10 +288,7 @@ impl DynamicMapping {
         let idx = self.last_attribute_idx;
         self.last_attribute_idx += 1;
 
-        self.attribute_to_idx
-            .entry(attr)
-            .or_insert_with(Vec::new)
-            .push(idx);
+        self.attribute_to_idx.entry(attr).or_default().push(idx);
 
         idx
     }
@@ -300,10 +297,7 @@ impl DynamicMapping {
         let idx = self.last_element_idx;
         self.last_element_idx += 1;
 
-        self.node_to_idx
-            .entry(node)
-            .or_insert_with(Vec::new)
-            .push(idx);
+        self.node_to_idx.entry(node).or_default().push(idx);
 
         idx
     }
diff --git a/packages/ssr/src/cache.rs b/packages/ssr/src/cache.rs
index 564be68a2..bcd6ba71f 100644
--- a/packages/ssr/src/cache.rs
+++ b/packages/ssr/src/cache.rs
@@ -88,7 +88,7 @@ impl StringCache {
                                 inner_html = Some(value);
                             } else if let Some("style") = namespace {
                                 styles.push((name, value));
-                            } else if BOOL_ATTRS.contains(&name) {
+                            } else if BOOL_ATTRS.contains(name) {
                                 if str_truthy(value) {
                                     write!(chain, " {name}=\"{value}\"",)?;
                                 }
diff --git a/packages/ssr/src/renderer.rs b/packages/ssr/src/renderer.rs
index 313839520..20461eb40 100644
--- a/packages/ssr/src/renderer.rs
+++ b/packages/ssr/src/renderer.rs
@@ -91,7 +91,7 @@ impl Renderer {
                             write_value(buf, &attr.value)?;
                         }
                     } else {
-                        write_attribute(buf, &attr)?;
+                        write_attribute(buf, attr)?;
                     }
                 }
                 Segment::Node(idx) => match &template.dynamic_nodes[*idx] {