Fix buliding with redefined cargo target dir

This commit is contained in:
imbolc committed 2022-03-21 10:56:19 +03:00
1 parent 83c4666f2e
commit 3052e0ef11
2 files changed
+38 -19

No files matched your search

+35 -17
View File
@@ -10,6 +10,12 @@ use std::{
/// How many parent folders are searched for a `Cargo.toml` /// How many parent folders are searched for a `Cargo.toml`
const MAX_ANCESTORS: u32 = 10; const MAX_ANCESTORS: u32 = 10;
/// Some fields parsed from `cargo metadata` command
pub struct Metadata {
pub workspace_root: PathBuf,
pub target_directory: PathBuf,
}
/// Returns the root of the crate that the command is run from /// Returns the root of the crate that the command is run from
/// ///
/// If the command is run from the workspace root, this will return the top-level Cargo.toml /// If the command is run from the workspace root, this will return the top-level Cargo.toml
@@ -31,9 +37,21 @@ pub fn crate_root() -> Result<PathBuf> {
.ok_or_else(|| Error::CargoError("Failed to find the cargo directory".to_string())) .ok_or_else(|| Error::CargoError("Failed to find the cargo directory".to_string()))
} }
/// Returns the root of a workspace /// Checks if the directory contains `Cargo.toml`
/// TODO @Jon, find a different way that doesn't rely on the cargo metadata command (it's slow) fn contains_manifest(path: &Path) -> bool {
pub fn workspace_root() -> Result<PathBuf> { fs::read_dir(path)
.map(|entries| {
entries
.filter_map(Result::ok)
.any(|ent| &ent.file_name() == "Cargo.toml")
})
.unwrap_or(false)
}
impl Metadata {
/// Returns the struct filled from `cargo metadata` output
/// TODO @Jon, find a different way that doesn't rely on the cargo metadata command (it's slow)
pub fn get() -> Result<Self> {
let output = Command::new("cargo") let output = Command::new("cargo")
.args(&["metadata"]) .args(&["metadata"])
.output() .output()
@@ -53,22 +71,22 @@ pub fn workspace_root() -> Result<PathBuf> {
let meta: serde_json::Value = serde_json::from_str(line) let meta: serde_json::Value = serde_json::from_str(line)
.map_err(|_| Error::CargoError("InvalidOutput".to_string()))?; .map_err(|_| Error::CargoError("InvalidOutput".to_string()))?;
let root = meta["workspace_root"] let workspace_root = meta["workspace_root"]
.as_str() .as_str()
.ok_or_else(|| Error::CargoError("InvalidOutput".to_string()))?; .ok_or_else(|| Error::CargoError("InvalidOutput".to_string()))?
return Ok(root.into()); .into();
let target_directory = meta["target_directory"]
.as_str()
.ok_or_else(|| Error::CargoError("InvalidOutput".to_string()))?
.into();
return Ok(Self {
workspace_root,
target_directory,
});
} }
Err(Error::CargoError("InvalidOutput".to_string())) Err(Error::CargoError("InvalidOutput".to_string()))
} }
/// Checks if the directory contains `Cargo.toml`
fn contains_manifest(path: &Path) -> bool {
fs::read_dir(path)
.map(|entries| {
entries
.filter_map(Result::ok)
.any(|ent| &ent.file_name() == "Cargo.toml")
})
.unwrap_or(false)
} }
+3 -2
View File
@@ -120,8 +120,9 @@ impl CrateConfig {
let dioxus_config = DioxusConfig::load()?; let dioxus_config = DioxusConfig::load()?;
let crate_dir = crate::cargo::crate_root()?; let crate_dir = crate::cargo::crate_root()?;
let workspace_dir = crate::cargo::workspace_root()?; let meta = crate::cargo::Metadata::get()?;
let target_dir = workspace_dir.join("target"); let workspace_dir = meta.workspace_root;
let target_dir = meta.target_directory;
let out_dir = match dioxus_config.application.out_dir { let out_dir = match dioxus_config.application.out_dir {
Some(ref v) => crate_dir.join(v), Some(ref v) => crate_dir.join(v),