swaits/dioxus
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix attribute diffs causing infinite loops with test

Browse Source
This commit is contained in:
Ege Gungordu committed 2024-01-22 01:19:37 +03:00
1 parent 6111bdfdf0
commit 43fe17d9c5
2 files changed
+78 -63
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

packages/core/src/diff.rs
+20 -16
View File
@@ -145,25 +145,29 @@ impl<'b> VirtualDom {
(Some(left), Some(right)) => {
// check which name is greater
match left.name.cmp(right.name) {
std::cmp::Ordering::Less => self.remove_attribute(
left.name,
left.namespace,
mounted_id,
),
std::cmp::Ordering::Greater => self.write_attribute(
right_template,
right,
idx,
mounted_id,
),
std::cmp::Ordering::Less => {
self.remove_attribute(
left.name,
left.namespace,
mounted_id,
);
left_iter.next();
}
std::cmp::Ordering::Greater => {
self.write_attribute(
right_template,
right,
idx,
mounted_id,
);
right_iter.next();
}
std::cmp::Ordering::Equal => {
self.diff_attribute(left, right, mounted_id)
self.diff_attribute(left, right, mounted_id);
left_iter.next();
right_iter.next();
}
}
// consume both
left_iter.next();
right_iter.next();
}
(Some(_), None) => {
let left = left_iter.next().unwrap();