apply clippy suggestions

packages/router-core/src/routes/segment.rs

@@ -189,7 +189,7 @@ impl<T: Clone> Segment<T> {
     pub fn gen_sitemap(&self) -> Vec<String> {
         let mut res = Vec::new();
         res.push(String::from("/"));
-        gen_sitemap(&self, "", &mut res);
+        gen_sitemap(self, "", &mut res);
         res
     }
 
@@ -213,7 +213,7 @@ impl<T: Clone> Segment<T> {
     pub fn gen_parameter_sitemap(&self, parameters: &BTreeMap<Name, Vec<String>>) -> Vec<String> {
         let mut res = Vec::new();
         res.push(String::from("/"));
-        gen_parameter_sitemap(&self, parameters, "", &mut res);
+        gen_parameter_sitemap(self, parameters, "", &mut res);
         res
     }
 }

packages/router-core/src/service.rs

@@ -146,7 +146,7 @@ where
         (
             Self {
                 history,
-                names: names,
+                names,
                 routes,
                 receiver,
                 state: Arc::clone(&state),
@@ -444,7 +444,7 @@ where
                     false
                 } else {
                     (self.subscriber_update)(id.as_ref().clone());
-                    previous.push(id.clone());
+                    previous.push(id);
                     true
                 }
             } else {

packages/router-core/src/state.rs

@@ -65,7 +65,7 @@ impl<T: Clone> RouterState<T> {
 
     /// Get the `href` for the `target`.
     pub fn href(&self, target: &NavigationTarget) -> String {
-        match resolve_target(&self.name_map, &target) {
+        match resolve_target(&self.name_map, target) {
             Either::Left(Either::Left(i)) => match &self.prefix {
                 Some(p) => format!("{p}{i}"),
                 None => i,

packages/router-core/src/utils/name.rs

@@ -13,10 +13,10 @@ pub fn resolve_name(
     parameters: &HashMap<Name, String>,
 ) -> Option<String> {
     debug_assert!(
-        map.contains_key(&name),
+        map.contains_key(name),
         "named navigation to unknown name: {name}"
     );
-    let target = map.get(&name)?;
+    let target = map.get(name)?;
 
     let mut res = String::new();
     for t in target {

packages/router-core/src/utils/target.rs

@@ -27,7 +27,7 @@ pub fn resolve_target(
                                 if !s.starts_with('?') {
                                     p += "?";
                                 }
-                                p += &s;
+                                p += s;
                             }
                             #[cfg(feature = "serde")]
                             Query::List(l) => {
@@ -44,8 +44,8 @@ pub fn resolve_target(
 
                     p
                 })
-                .map(|p| Either::Left(p))
-                .unwrap_or(Either::Right(name.clone())),
+                .map(Either::Left)
+                .unwrap_or_else(|| Either::Right(name.clone())),
         ),
         NavigationTarget::External(e) => Either::Right(e.to_string()),
     }