From fae81e2364ba7bdd75670cc1af609dcfdd149251 Mon Sep 17 00:00:00 2001 From: Evan Almloff Date: Thu, 4 Jan 2024 19:32:00 -0600 Subject: [PATCH] fix event tests in core --- examples/compose.rs | 2 +- packages/core/tests/event_propagation.rs | 16 ++++++---------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/examples/compose.rs b/examples/compose.rs index 23f703bd2..133192281 100644 --- a/examples/compose.rs +++ b/examples/compose.rs @@ -26,7 +26,7 @@ fn app(cx: Scope) -> Element { button { onclick: move |_| { let dom = VirtualDom::new_with_props(compose, ComposeProps { app_tx: tx.clone() }); - window.new_window(dom, Default::default()); + dioxus_desktop::window().new_window(dom, Default::default()); }, "Click to compose a new email" } diff --git a/packages/core/tests/event_propagation.rs b/packages/core/tests/event_propagation.rs index d694b1ff1..1c294aa37 100644 --- a/packages/core/tests/event_propagation.rs +++ b/packages/core/tests/event_propagation.rs @@ -10,7 +10,7 @@ fn events_propagate() { _ = dom.rebuild(); // Top-level click is registered - dom.handle_event("click", Rc::new(MouseData::default()), ElementId(1), true); + dom.handle_event("click", Rc::new(PlatformEventData::new(Box::::default())), ElementId(1), true); assert_eq!(*CLICKS.lock().unwrap(), 1); // break reference.... @@ -20,7 +20,7 @@ fn events_propagate() { } // Lower click is registered - dom.handle_event("click", Rc::new(MouseData::default()), ElementId(2), true); + dom.handle_event("click", Rc::new(PlatformEventData::new(Box::::default())), ElementId(2), true); assert_eq!(*CLICKS.lock().unwrap(), 3); // break reference.... @@ -30,14 +30,13 @@ fn events_propagate() { } // Stop propagation occurs - dom.handle_event("click", Rc::new(MouseData::default()), ElementId(2), true); + dom.handle_event("click", Rc::new(PlatformEventData::new(Box::::default())), ElementId(2), true); assert_eq!(*CLICKS.lock().unwrap(), 3); } fn app(cx: Scope) -> Element { render! { - div { - onclick: move |_| { + div { onclick: move |_| { println!("top clicked"); *CLICKS.lock().unwrap() += 1; }, @@ -53,17 +52,14 @@ fn app(cx: Scope) -> Element { fn problematic_child(cx: Scope) -> Element { render! { - button { - onclick: move |evt| { + button { onclick: move |evt| { println!("bottom clicked"); let mut clicks = CLICKS.lock().unwrap(); - if *clicks == 3 { evt.stop_propagation(); } else { *clicks += 1; } - } - } + } } } }