From 5ab0c48dddd86578bfe260a28446254621823daa Mon Sep 17 00:00:00 2001 From: Evan Almloff Date: Sun, 17 Dec 2023 17:55:02 -0600 Subject: [PATCH] fix clippy --- packages/cli/src/cli/autoformat.rs | 2 -- packages/signals/examples/errors.rs | 32 ++++++++++++++--------------- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/packages/cli/src/cli/autoformat.rs b/packages/cli/src/cli/autoformat.rs index 8cbb86269..2c0691d6c 100644 --- a/packages/cli/src/cli/autoformat.rs +++ b/packages/cli/src/cli/autoformat.rs @@ -147,8 +147,6 @@ async fn autoformat_project(check: bool) -> Result<()> { return Ok(()); } - let indent = indentation_for(&files_to_format[0])?; - if files_to_format.is_empty() { return Ok(()); } diff --git a/packages/signals/examples/errors.rs b/packages/signals/examples/errors.rs index d082e55bb..8155f9192 100644 --- a/packages/signals/examples/errors.rs +++ b/packages/signals/examples/errors.rs @@ -10,9 +10,9 @@ fn main() { #[derive(Clone, Copy)] enum ErrorComponent { - ReadsSignal, - ReadsMutSignal, - ReadDroppedSignal, + Read, + ReadMut, + ReadDropped, } fn app(cx: Scope) -> Element { @@ -20,28 +20,28 @@ fn app(cx: Scope) -> Element { render! { match *error() { - Some(ErrorComponent::ReadsSignal) => render! { ReadsSignal {} }, - Some(ErrorComponent::ReadsMutSignal) => render! { ReadsMutSignal {} }, - Some(ErrorComponent::ReadDroppedSignal) => render! { ReadDroppedSignal {} }, + Some(ErrorComponent::Read) => render! { Read {} }, + Some(ErrorComponent::ReadMut) => render! { ReadMut {} }, + Some(ErrorComponent::ReadDropped) => render! { ReadDropped {} }, None => render! { button { - onclick: move |_| error.set(Some(ErrorComponent::ReadsSignal)), - "ReadsSignal" + onclick: move |_| error.set(Some(ErrorComponent::Read)), + "Read" } button { - onclick: move |_| error.set(Some(ErrorComponent::ReadsMutSignal)), - "ReadsMutSignal" + onclick: move |_| error.set(Some(ErrorComponent::ReadMut)), + "ReadMut" } button { - onclick: move |_| error.set(Some(ErrorComponent::ReadDroppedSignal)), - "ReadDroppedSignal" + onclick: move |_| error.set(Some(ErrorComponent::ReadDropped)), + "ReadDropped" } } } } } -fn ReadsSignal(cx: Scope) -> Element { +fn Read(cx: Scope) -> Element { let signal = use_signal_sync(cx, || 0); let _write = signal.write(); @@ -50,7 +50,7 @@ fn ReadsSignal(cx: Scope) -> Element { todo!() } -fn ReadsMutSignal(cx: Scope) -> Element { +fn ReadMut(cx: Scope) -> Element { let signal = use_signal_sync(cx, || 0); let _read = signal.read(); @@ -59,7 +59,7 @@ fn ReadsMutSignal(cx: Scope) -> Element { todo!() } -fn ReadDroppedSignal(cx: Scope) -> Element { +fn ReadDropped(cx: Scope) -> Element { let signal = use_signal_sync(cx, || None); if cx.generation() < 4 { cx.needs_update(); @@ -82,7 +82,7 @@ fn ReadDroppedSignalChild( ) -> Element { let signal = use_signal_sync(cx, || 0); cx.use_hook(move || { - parent_signal.set(Some(signal.clone())); + parent_signal.set(Some(signal)); }); render! { "{signal}"