From 690efade8840cd2744891600071f7460cba52df9 Mon Sep 17 00:00:00 2001 From: Muhannad Alrusayni Date: Sat, 7 May 2022 06:47:16 +0300 Subject: [PATCH] fix: Support `Input::<..>` style to for generic components before that, we accepted this style `Input<..>` but to be consistent with Rust syntax this is dropped now. > For reference, the two ways of specifying explicit type parameters in > Rust are: > // for functions > let _ = foo::(); > > // for structs > let _ = Foo:: { ... }; > > by @jkelleyrtp --- packages/core-macro/src/rsx/component.rs | 2 +- packages/core-macro/src/rsx/node.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core-macro/src/rsx/component.rs b/packages/core-macro/src/rsx/component.rs index d316c833b..91c8c4903 100644 --- a/packages/core-macro/src/rsx/component.rs +++ b/packages/core-macro/src/rsx/component.rs @@ -141,7 +141,7 @@ impl ToTokens for Component { } None => { let mut toks = match prop_gen_args { - Some(gen_args) => quote! { fc_to_builder::#gen_args(#name) }, + Some(gen_args) => quote! { fc_to_builder #gen_args(#name) }, None => quote! { fc_to_builder(#name) }, }; for field in &self.body { diff --git a/packages/core-macro/src/rsx/node.rs b/packages/core-macro/src/rsx/node.rs index fa651cebf..baccf5371 100644 --- a/packages/core-macro/src/rsx/node.rs +++ b/packages/core-macro/src/rsx/node.rs @@ -65,10 +65,10 @@ impl Parse for BodyNode { // ::component () // crate::component{} // crate::component() - // Input<'_, String> {} - // crate::Input<'_, i32> {} + // Input:: {} + // crate::Input:: {} if body_stream.peek(token::Brace) || body_stream.peek(token::Paren) { - // this syntax is not allowd: + // NOTE: this syntax is not allowd: // Div () -> comp if path.segments.len() == 1 && body_stream.peek(token::Paren) { let com_ident = &path.segments.iter().next().unwrap().ident;