Dont write empty strings in link

This commit is contained in:
Jonathan Kelley committed 2024-01-31 13:15:33 -08:00
1 parent a7a3513b3f
commit 72a40e41e6
2 files changed
+19 -34

No files matched your search

+10 -6
View File
@@ -244,14 +244,18 @@ pub fn Link(props: LinkProps) -> Element {
}
}
let tag_target = new_tab.then_some("_blank").unwrap_or_default();
let class = if class_.is_empty() {
None
} else {
Some(class_)
};
let tag_target = new_tab.then_some("_blank");
let is_external = matches!(parsed_route, NavigationTarget::External(_));
let is_router_nav = !is_external && !new_tab;
let prevent_default = is_router_nav.then_some("onclick").unwrap_or_default();
let rel = rel
.or_else(|| is_external.then_some("noopener noreferrer".to_string()))
.unwrap_or_default();
let rel = rel.or_else(|| is_external.then_some("noopener noreferrer".to_string()));
let do_default = onclick.is_none() || !onclick_only;
@@ -270,9 +274,9 @@ pub fn Link(props: LinkProps) -> Element {
onclick: action,
href,
prevent_default,
class: class_,
class,
rel,
target: "{tag_target}",
target: tag_target,
..attributes,
{children}
}