From 74ec3a4a82c2ae6909b4dc070454bdc0b05ecf2d Mon Sep 17 00:00:00 2001 From: Evan Almloff Date: Mon, 22 Jan 2024 08:36:17 -0600 Subject: [PATCH] fix js framework benchmark --- packages/dioxus/benches/jsframework.rs | 4 ++-- packages/dioxus/src/launch.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/dioxus/benches/jsframework.rs b/packages/dioxus/benches/jsframework.rs index a3c663454..c7010ffe1 100644 --- a/packages/dioxus/benches/jsframework.rs +++ b/packages/dioxus/benches/jsframework.rs @@ -19,6 +19,7 @@ use criterion::{criterion_group, criterion_main, Criterion}; use dioxus::prelude::*; +use dioxus_core::NoOpMutations; use rand::prelude::*; criterion_group!(mbenches, create_rows); @@ -30,8 +31,7 @@ fn create_rows(c: &mut Criterion) { let _ = dom.rebuild(&mut dioxus_core::NoOpMutations); b.iter(|| { - let g = dom.rebuild(&mut ()); - assert!(g.edits.len() > 1); + dom.rebuild(&mut NoOpMutations); }) }); } diff --git a/packages/dioxus/src/launch.rs b/packages/dioxus/src/launch.rs index 69e834d06..89fc8e5e4 100644 --- a/packages/dioxus/src/launch.rs +++ b/packages/dioxus/src/launch.rs @@ -170,13 +170,13 @@ pub fn launch(app: fn() -> Element) { LaunchBuilder::new().launch(app) } -#[cfg(all(feature = "web"))] +#[cfg(feature = "web")] /// Launch your web application without any additional configuration. See [`LaunchBuilder`] for more options. pub fn launch_web(app: fn() -> Element) { LaunchBuilder::web().launch(app) } -#[cfg(all(feature = "desktop"))] +#[cfg(feature = "desktop")] /// Launch your desktop application without any additional configuration. See [`LaunchBuilder`] for more options. pub fn launch_desktop(app: fn() -> Element) { LaunchBuilder::desktop().launch(app)