From 79e09934aa685d03d6e0b323723bc1cd537d74d9 Mon Sep 17 00:00:00 2001
From: Jonathan Kelley <jkelleyrtp@gmail.com>
Date: Fri, 28 Jan 2022 12:14:40 -0500
Subject: [PATCH] chore: add docs to router UseRouteListener

---
 packages/router/src/hooks/use_route.rs | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/packages/router/src/hooks/use_route.rs b/packages/router/src/hooks/use_route.rs
index ab6fad268..3b609f5e2 100644
--- a/packages/router/src/hooks/use_route.rs
+++ b/packages/router/src/hooks/use_route.rs
@@ -8,6 +8,7 @@ use crate::RouterService;
 /// This struct provides is a wrapper around the internal router
 /// implementation, with methods for getting information about the current
 /// route.
+#[derive(Clone)]
 pub struct UseRoute {
     router: Rc<RouterService>,
 }
@@ -82,7 +83,7 @@ pub fn use_route(cx: &ScopeState) -> &UseRoute {
 
         router.subscribe_onchange(cx.scope_id());
 
-        UseRouteInner {
+        UseRouteListener {
             router: UseRoute { router },
             scope: cx.scope_id(),
         }
@@ -90,11 +91,15 @@ pub fn use_route(cx: &ScopeState) -> &UseRoute {
     .router
 }
 
-struct UseRouteInner {
+// The entire purpose of this struct is to unubscribe this component when it is unmounted.
+// The UseRoute can be cloned into async contexts, so we can't rely on its drop to unubscribe.
+// Instead, we hide the drop implementation on this private type exclusive to the hook,
+// and reveal our cached version of UseRoute to the component.
+struct UseRouteListener {
     router: UseRoute,
     scope: ScopeId,
 }
-impl Drop for UseRouteInner {
+impl Drop for UseRouteListener {
     fn drop(&mut self) {
         self.router.router.unsubscribe_onchange(self.scope)
     }