From 7d529cf39c2d3b6c87fb7136466ec68298bac0f5 Mon Sep 17 00:00:00 2001 From: Marc Espin Date: Wed, 29 May 2024 15:53:21 +0200 Subject: [PATCH] fix: Avoid cloning a provided context unnecessarily (#2458) * fix: Avoid clonning a provided context unnecessarily * remove another useless clone in use_context_provider * fix formatting --------- Co-authored-by: Evan Almloff --- Cargo.lock | 1 - packages/hooks/src/use_context.rs | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index bbb45f817..d121cc05e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2572,7 +2572,6 @@ version = "0.1.0" dependencies = [ "console_error_panic_hook", "dioxus", - "dioxus-web", "log", "wasm-logger", ] diff --git a/packages/hooks/src/use_context.rs b/packages/hooks/src/use_context.rs index 19ef6b734..247cf7a69 100644 --- a/packages/hooks/src/use_context.rs +++ b/packages/hooks/src/use_context.rs @@ -57,9 +57,5 @@ pub fn use_context() -> T { ///} /// ``` pub fn use_context_provider(f: impl FnOnce() -> T) -> T { - use_hook(|| { - let val = f(); - provide_context(val.clone()); - val - }) + use_hook(|| provide_context(f())) }