swaits/dioxus
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix mutations related to keyed lists

Browse Source
This commit is contained in:
Evan Almloff committed 2022-12-24 10:58:56 -06:00
1 parent 2409d499e0
commit 7eac90065a
1 file changed
+7 -7
Download Patch File Download Diff File Expand all files Collapse all files
packages/native-core/src/real_dom.rs
+7 -7
View File
@@ -174,7 +174,7 @@ impl<S: State> RealDom<S> {
use dioxus_core::Mutation::*; use dioxus_core::Mutation::*;
match e { match e {
AppendChildren { id, m } => { AppendChildren { id, m } => {
let children = self.stack.split_off(m); let children = self.stack.split_off(self.stack.len() - m);
let parent = self.element_to_node_id(id); let parent = self.element_to_node_id(id);
for child in children { for child in children {
self.add_child(parent, child); self.add_child(parent, child);
@@ -222,10 +222,10 @@ impl<S: State> RealDom<S> {
self.stack.push(clone_id); self.stack.push(clone_id);
} }
ReplaceWith { id, m } => { ReplaceWith { id, m } => {
let new_nodes = self.stack.split_off(m); let new_nodes = self.stack.split_off(self.stack.len() - m);
let old_node_id = self.element_to_node_id(id); let old_node_id = self.element_to_node_id(id);
for new in new_nodes { for new in new_nodes {
self.tree.insert_after(old_node_id, new); self.tree.insert_before(old_node_id, new);
mark_dirty(new, NodeMask::ALL, &mut nodes_updated); mark_dirty(new, NodeMask::ALL, &mut nodes_updated);
} }
self.tree.remove(old_node_id); self.tree.remove(old_node_id);
@@ -234,21 +234,21 @@ impl<S: State> RealDom<S> {
let new_nodes = self.stack.split_off(self.stack.len() - m); let new_nodes = self.stack.split_off(self.stack.len() - m);
let old_node_id = self.load_child(path); let old_node_id = self.load_child(path);
for new in new_nodes { for new in new_nodes {
self.tree.insert_after(old_node_id, new); self.tree.insert_before(old_node_id, new);
mark_dirty(new, NodeMask::ALL, &mut nodes_updated); mark_dirty(new, NodeMask::ALL, &mut nodes_updated);
} }
self.tree.remove(old_node_id); self.tree.remove(old_node_id);
} }
InsertAfter { id, m } => { InsertAfter { id, m } => {
let new_nodes = self.stack.split_off(m); let new_nodes = self.stack.split_off(self.stack.len() - m);
let old_node_id = self.element_to_node_id(id); let old_node_id = self.element_to_node_id(id);
for new in new_nodes { for new in new_nodes.into_iter().rev() {
self.tree.insert_after(old_node_id, new); self.tree.insert_after(old_node_id, new);
mark_dirty(new, NodeMask::ALL, &mut nodes_updated); mark_dirty(new, NodeMask::ALL, &mut nodes_updated);
} }
} }
InsertBefore { id, m } => { InsertBefore { id, m } => {
let new_nodes = self.stack.split_off(m); let new_nodes = self.stack.split_off(self.stack.len() - m);
let old_node_id = self.element_to_node_id(id); let old_node_id = self.element_to_node_id(id);
for new in new_nodes { for new in new_nodes {
self.tree.insert_before(old_node_id, new); self.tree.insert_before(old_node_id, new);