From fc5dd8f56283f3c8c3b75f7d8655456defd76a55 Mon Sep 17 00:00:00 2001 From: Jonathan Kelley Date: Tue, 8 Feb 2022 00:40:48 -0500 Subject: [PATCH 1/2] fix: always prevent default on a tags --- packages/interpreter/src/interpreter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/interpreter/src/interpreter.js b/packages/interpreter/src/interpreter.js index 01a1d3dd5..4720382c7 100644 --- a/packages/interpreter/src/interpreter.js +++ b/packages/interpreter/src/interpreter.js @@ -210,6 +210,7 @@ export class Interpreter { // todo call prevent default if it's the right type of event if (shouldPreventDefault !== `onclick`) { if (target.tagName == "A") { + event.preventDefault(); const href = target.getAttribute("href"); if (href !== "" && href !== null && href !== undefined) { window.rpc.call("browser_open", { href }); From 4818c44c7c4d960c89e44fd2e2bc1cbccbfd0ab2 Mon Sep 17 00:00:00 2001 From: Jonathan Kelley Date: Tue, 8 Feb 2022 00:43:05 -0500 Subject: [PATCH 2/2] fix: also prevent default on buttons --- packages/interpreter/src/interpreter.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/interpreter/src/interpreter.js b/packages/interpreter/src/interpreter.js index 4720382c7..a9f00b2a1 100644 --- a/packages/interpreter/src/interpreter.js +++ b/packages/interpreter/src/interpreter.js @@ -217,6 +217,11 @@ export class Interpreter { } } } + + // also prevent buttons from submitting + if (target.tagName == "BUTTON") { + event.preventDefault(); + } } // walk the tree to find the real element while (realId == null) {