From 8a0eca1c8aa3e812f3899bc62f8ecc8c4154f819 Mon Sep 17 00:00:00 2001 From: Miles Murgaw Date: Mon, 28 Oct 2024 14:20:35 -0400 Subject: [PATCH] remove: default_platform toml field (#3108) --- packages/cli/Dioxus.toml | 3 --- packages/cli/README.md | 6 ------ packages/cli/src/config/app.rs | 8 -------- packages/cli/src/config/dioxus_config.rs | 1 - 4 files changed, 18 deletions(-) diff --git a/packages/cli/Dioxus.toml b/packages/cli/Dioxus.toml index b8ee45bd4..02b61ba69 100644 --- a/packages/cli/Dioxus.toml +++ b/packages/cli/Dioxus.toml @@ -3,9 +3,6 @@ # App name name = "project_name" -# The Dioxus platform to default to -default_platform = "web" - # `build` & `serve` output path out_dir = "dist" diff --git a/packages/cli/README.md b/packages/cli/README.md index cc45524cd..9627a1e35 100644 --- a/packages/cli/README.md +++ b/packages/cli/README.md @@ -33,12 +33,6 @@ Note: The CLI will fail to build projects in debug profile. This is currently un cargo install --path . ``` -### Developing The CLI -It's faster to build the CLI using the `cli-dev` profile when testing changes. -```shell -cargo build --profile cli-dev -``` - ## Get started Use `dx new` to initialize a new Dioxus project. diff --git a/packages/cli/src/config/app.rs b/packages/cli/src/config/app.rs index ea426e868..c1e4bd72d 100644 --- a/packages/cli/src/config/app.rs +++ b/packages/cli/src/config/app.rs @@ -1,12 +1,8 @@ -use crate::Platform; use serde::{Deserialize, Serialize}; use std::path::PathBuf; #[derive(Debug, Clone, Serialize, Deserialize)] pub(crate) struct ApplicationConfig { - #[serde(default = "default_platform")] - pub(crate) default_platform: Platform, - #[serde(default = "asset_dir_default")] pub(crate) asset_dir: PathBuf, @@ -14,10 +10,6 @@ pub(crate) struct ApplicationConfig { pub(crate) sub_package: Option, } -pub(crate) fn default_platform() -> Platform { - Platform::Web -} - pub(crate) fn asset_dir_default() -> PathBuf { PathBuf::from("assets") } diff --git a/packages/cli/src/config/dioxus_config.rs b/packages/cli/src/config/dioxus_config.rs index 23f96b4ab..ec8e7607f 100644 --- a/packages/cli/src/config/dioxus_config.rs +++ b/packages/cli/src/config/dioxus_config.rs @@ -22,7 +22,6 @@ impl Default for DioxusConfig { fn default() -> Self { Self { application: ApplicationConfig { - default_platform: default_platform(), asset_dir: asset_dir_default(), sub_package: None, },