From 8f07d881a6485d5fb3d0d4af4a20e39571ad6ffa Mon Sep 17 00:00:00 2001 From: Jonathan Kelley Date: Wed, 31 Jan 2024 16:26:12 -0800 Subject: [PATCH] Switch todo!() to unreachable!/unimplemented! where it matters --- examples/memo_chain.rs | 1 - examples/shorthand.rs | 6 +- examples/signals.rs | 5 +- examples/simple_list.rs | 2 +- packages/core-macro/src/utils.rs | 2 +- packages/core/README.md | 2 +- packages/core/src/events.rs | 4 +- packages/core/src/properties.rs | 2 +- packages/core/tests/lifecycle.rs | 97 ------------------- packages/core/tests/miri_simple.rs | 2 +- packages/core/tests/miri_stress.rs | 8 -- .../fullstack/src/adapters/axum_adapter.rs | 4 +- .../fullstack/src/adapters/salvo_adapter.rs | 2 +- .../fullstack/src/adapters/warp_adapter.rs | 2 +- packages/fullstack/src/hooks/server_cached.rs | 2 +- packages/native-core/src/layout_attributes.rs | 12 +-- packages/plasmo/src/render.rs | 4 +- packages/plasmo/src/style_attributes.rs | 26 ++--- packages/router/src/history/memory.rs | 4 +- packages/router/src/history/mod.rs | 28 +++--- packages/router/src/navigation.rs | 4 +- packages/router/src/routable.rs | 8 +- packages/router/src/router_cfg.rs | 2 +- packages/router/tests/via_ssr/link.rs | 14 +-- packages/rsx/src/attribute.rs | 4 +- packages/server-macro/src/lib.rs | 2 +- packages/signals/examples/errors.rs | 4 +- 27 files changed, 73 insertions(+), 180 deletions(-) diff --git a/examples/memo_chain.rs b/examples/memo_chain.rs index 2d1adbf61..56c3aad71 100644 --- a/examples/memo_chain.rs +++ b/examples/memo_chain.rs @@ -8,7 +8,6 @@ fn app() -> Element { let mut value = use_signal(|| 0); let mut depth = use_signal(|| 0_usize); let items = use_memo(move || (0..depth()).map(|f| f as _).collect::>()); - let state = use_memo(move || value() + 1); println!("rendering app"); diff --git a/examples/shorthand.rs b/examples/shorthand.rs index 7dc889a94..c53e0146b 100644 --- a/examples/shorthand.rs +++ b/examples/shorthand.rs @@ -25,14 +25,12 @@ fn app() -> Element { } #[component] -fn Component(a: i32, b: i32, c: i32, children: Element, onclick: EventHandler<()>) -> Element { +fn Component(a: i32, b: i32, c: i32, children: Element, onclick: EventHandler) -> Element { rsx! { div { "{a}" } div { "{b}" } div { "{c}" } div { {children} } - div { - onclick: move |_| onclick.call(()), - } + div { onclick: move |_| onclick.call(()) } } } diff --git a/examples/signals.rs b/examples/signals.rs index fd4c59d0b..981853e57 100644 --- a/examples/signals.rs +++ b/examples/signals.rs @@ -15,7 +15,7 @@ fn app() -> Element { // use_effect will subscribe to any changes in the signal values it captures // effects will always run after first mount and then whenever the signal values change - use_effect(move || println!("Count changed to {}", count())); + use_effect(move || println!("Count changed to {count}")); // We can do early returns and conditional rendering which will pause all futures that haven't been polled if count() > 30 { @@ -49,7 +49,7 @@ fn app() -> Element { button { onclick: move |_| count += 1, "Up high!" } button { onclick: move |_| count -= 1, "Down low!" } button { onclick: move |_| running.toggle(), "Toggle counter" } - button { onclick: move |_| saved_values.push(count().to_string()), "Save this value" } + button { onclick: move |_| saved_values.push(count.to_string()), "Save this value" } button { onclick: move |_| saved_values.clear(), "Clear saved values" } // We can do boolean operations on the current signal value @@ -71,6 +71,7 @@ fn app() -> Element { // You can pass a value directly to any prop that accepts a signal Child { count: doubled_count() } + Child { count: doubled_count } } } diff --git a/examples/simple_list.rs b/examples/simple_list.rs index dfe1f4b76..67e9e64ff 100644 --- a/examples/simple_list.rs +++ b/examples/simple_list.rs @@ -22,7 +22,7 @@ fn app() -> Element { // use a for loop where the body itself is RSX for name in 0..10 { - div {"{name}"} + div { "{name}" } } // Or even use an unterminated conditional diff --git a/packages/core-macro/src/utils.rs b/packages/core-macro/src/utils.rs index 7e066f773..918c8d293 100644 --- a/packages/core-macro/src/utils.rs +++ b/packages/core-macro/src/utils.rs @@ -4,7 +4,7 @@ use syn::spanned::Spanned; use syn::{parse_quote, Expr, Lit, Meta, Token, Type}; const FORMATTED_TYPE_START: &str = "static TY_AFTER_HERE:"; -const FORMATTED_TYPE_END: &str = "= todo!();"; +const FORMATTED_TYPE_END: &str = "= unreachable!();"; /// Attempts to convert the given literal to a string. /// Converts ints and floats to their base 10 counterparts. diff --git a/packages/core/README.md b/packages/core/README.md index e013a9d56..b48a7d2b2 100644 --- a/packages/core/README.md +++ b/packages/core/README.md @@ -17,7 +17,7 @@ loop { } # fn app() -> Element { None } -# struct SomeRenderer; impl SomeRenderer { fn new() -> SomeRenderer { SomeRenderer; } async fn event() -> () { todo!() } } +# struct SomeRenderer; impl SomeRenderer { fn new() -> SomeRenderer { SomeRenderer; } async fn event() -> () { unimplemented!() } } ``` ## Features diff --git a/packages/core/src/events.rs b/packages/core/src/events.rs index 20f304991..2c0c92d14 100644 --- a/packages/core/src/events.rs +++ b/packages/core/src/events.rs @@ -150,8 +150,8 @@ impl std::fmt::Debug for Event { /// } /// /// #[derive(Props)] -/// struct MyProps<'a> { -/// onclick: EventHandler<'a, MouseEvent>, +/// struct MyProps { +/// onclick: EventHandler, /// } /// /// fn MyComponent(cx: MyProps) -> Element { diff --git a/packages/core/src/properties.rs b/packages/core/src/properties.rs index 2a85b517c..7dd7e8307 100644 --- a/packages/core/src/properties.rs +++ b/packages/core/src/properties.rs @@ -72,7 +72,7 @@ where { type Builder = P; fn builder() -> Self::Builder { - todo!() + unreachable!("Root props technically are never built") } fn memoize(&mut self, _other: &Self) -> bool { true diff --git a/packages/core/tests/lifecycle.rs b/packages/core/tests/lifecycle.rs index e0c4364d4..a7089c7e6 100644 --- a/packages/core/tests/lifecycle.rs +++ b/packages/core/tests/lifecycle.rs @@ -77,100 +77,3 @@ fn events_generate() { ] ) } - -// #[test] -// fn components_generate() { -// fn app() -> Element { -// let render_phase = use_hook(|| 0); -// *render_phase += 1; - -// match *render_phase { -// 1 => rsx_without_templates!("Text0"), -// 2 => rsx_without_templates!(div {}), -// 3 => rsx_without_templates!("Text2"), -// 4 => rsx_without_templates!(Child {}), -// 5 => rsx_without_templates!({ None as Option<()> }), -// 6 => rsx_without_templates!("text 3"), -// 7 => rsx_without_templates!({ (0..2).map(|f| rsx_without_templates!("text {f}")) }), -// 8 => rsx_without_templates!(Child {}), -// _ => todo!(), -// }) -// }; - -// fn Child() -> Element { -// println!("Running child"); -// render_without_templates! { -// h1 {} -// }) -// } - -// let mut dom = VirtualDom::new(app); -// let edits = dom.rebuild_to_vec(); -// assert_eq!( -// edits.edits, -// [ -// CreateTextNode { root: Some(1), text: "Text0" }, -// AppendChildren { root: Some(0), children: vec![1] } -// ] -// ); - -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateElement { root: Some(2), tag: "div", children: 0 }, -// ReplaceWith { root: Some(1), nodes: vec![2] } -// ] -// ); - -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateTextNode { root: Some(1), text: "Text2" }, -// ReplaceWith { root: Some(2), nodes: vec![1] } -// ] -// ); - -// // child {} -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateElement { root: Some(2), tag: "h1", children: 0 }, -// ReplaceWith { root: Some(1), nodes: vec![2] } -// ] -// ); - -// // placeholder -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreatePlaceholder { root: Some(1) }, -// ReplaceWith { root: Some(2), nodes: vec![1] } -// ] -// ); - -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateTextNode { root: Some(2), text: "text 3" }, -// ReplaceWith { root: Some(1), nodes: vec![2] } -// ] -// ); - -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateTextNode { text: "text 0", root: Some(1) }, -// CreateTextNode { text: "text 1", root: Some(3) }, -// ReplaceWith { root: Some(2), nodes: vec![1, 3] }, -// ] -// ); - -// assert_eq!( -// dom.hard_diff(ScopeId::ROOT).edits, -// [ -// CreateElement { tag: "h1", root: Some(2), children: 0 }, -// ReplaceWith { root: Some(1), nodes: vec![2] }, -// Remove { root: Some(3) }, -// ] -// ); -// } diff --git a/packages/core/tests/miri_simple.rs b/packages/core/tests/miri_simple.rs index 4224c14ee..eb567144f 100644 --- a/packages/core/tests/miri_simple.rs +++ b/packages/core/tests/miri_simple.rs @@ -95,7 +95,7 @@ fn diffing_drops_old() { match generation() % 2 { 0 => rsx!( ChildComp1 { name: "asdasd".to_string() }), 1 => rsx!( ChildComp2 { name: "asdasd".to_string() }), - _ => todo!() + _ => unreachable!() } } } diff --git a/packages/core/tests/miri_stress.rs b/packages/core/tests/miri_stress.rs index ec37ec476..3a0ce6a1c 100644 --- a/packages/core/tests/miri_stress.rs +++ b/packages/core/tests/miri_stress.rs @@ -97,14 +97,6 @@ fn memo_works_properly() { let mut dom = VirtualDom::new(app); dom.rebuild(&mut dioxus_core::NoOpMutations); - // todo!() - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); - // dom.hard_diff(ScopeId::ROOT); } #[test] diff --git a/packages/fullstack/src/adapters/axum_adapter.rs b/packages/fullstack/src/adapters/axum_adapter.rs index 022ed51f5..bed2bc9b1 100644 --- a/packages/fullstack/src/adapters/axum_adapter.rs +++ b/packages/fullstack/src/adapters/axum_adapter.rs @@ -184,7 +184,7 @@ pub trait DioxusRouterExt { /// } /// /// fn app() -> Element { - /// todo!() + /// unimplemented!() /// } /// ``` fn serve_static_assets(self, assets_path: impl Into) -> Self; @@ -213,7 +213,7 @@ pub trait DioxusRouterExt { /// } /// /// fn app() -> Element { - /// todo!() + /// unimplemented!() /// } /// ``` fn serve_dioxus_application( diff --git a/packages/fullstack/src/adapters/salvo_adapter.rs b/packages/fullstack/src/adapters/salvo_adapter.rs index 39da4e4f1..f548f2c95 100644 --- a/packages/fullstack/src/adapters/salvo_adapter.rs +++ b/packages/fullstack/src/adapters/salvo_adapter.rs @@ -200,7 +200,7 @@ pub trait DioxusRouterExt { /// .await; /// } /// - /// fn app() -> Element {todo!()} + /// fn app() -> Element {unimplemented!() } /// ``` fn serve_dioxus_application( self, diff --git a/packages/fullstack/src/adapters/warp_adapter.rs b/packages/fullstack/src/adapters/warp_adapter.rs index de0fb3c31..bf3dc20c0 100644 --- a/packages/fullstack/src/adapters/warp_adapter.rs +++ b/packages/fullstack/src/adapters/warp_adapter.rs @@ -177,7 +177,7 @@ pub fn register_server_fns(server_fn_route: &'static str) -> BoxedFilter<(impl R /// } /// /// fn app() -> Element { -/// todo!() +/// None /// } /// ``` pub fn serve_dioxus_application( diff --git a/packages/fullstack/src/hooks/server_cached.rs b/packages/fullstack/src/hooks/server_cached.rs index 959dbd406..5c0ea85fc 100644 --- a/packages/fullstack/src/hooks/server_cached.rs +++ b/packages/fullstack/src/hooks/server_cached.rs @@ -16,7 +16,7 @@ use serde::{de::DeserializeOwned, Serialize}; /// 1234 /// })); /// -/// todo!() +/// None /// } /// ``` pub fn server_cached(server_fn: impl Fn() -> O) -> O { diff --git a/packages/native-core/src/layout_attributes.rs b/packages/native-core/src/layout_attributes.rs index 4eb39292b..6ee5a6dc8 100644 --- a/packages/native-core/src/layout_attributes.rs +++ b/packages/native-core/src/layout_attributes.rs @@ -470,7 +470,7 @@ pub fn apply_layout_attributes_cfg( fn extract_px_value(length_value: LengthValue) -> f32 { match length_value { LengthValue::Px(value) => value, - _ => todo!(), + _ => todo!("Only px values are supported"), } } @@ -480,7 +480,7 @@ fn convert_length_percentage( match dimension_percentage { DimensionPercentage::Dimension(value) => LengthPercentage::Points(extract_px_value(value)), DimensionPercentage::Percentage(percentage) => LengthPercentage::Percent(percentage.0), - DimensionPercentage::Calc(_) => todo!(), + DimensionPercentage::Calc(_) => todo!("Calc is not supported yet"), } } @@ -492,7 +492,7 @@ fn convert_padding(dimension_percentage: LengthPercentageOrAuto) -> LengthPercen LengthPercentage::Points(extract_px_value(value)) } DimensionPercentage::Percentage(percentage) => LengthPercentage::Percent(percentage.0), - DimensionPercentage::Calc(_) => unimplemented!(), + DimensionPercentage::Calc(_) => unimplemented!("Calc is not supported yet"), }, } } @@ -509,7 +509,7 @@ fn convert_length_percentage_or_auto( DimensionPercentage::Percentage(percentage) => { LengthPercentageAuto::Percent(percentage.0) } - DimensionPercentage::Calc(_) => todo!(), + DimensionPercentage::Calc(_) => todo!("Calc is not supported yet"), }, } } @@ -518,7 +518,7 @@ fn convert_dimension(dimension_percentage: DimensionPercentage) -> match dimension_percentage { DimensionPercentage::Dimension(value) => Dimension::Points(extract_px_value(value)), DimensionPercentage::Percentage(percentage) => Dimension::Percent(percentage.0), - DimensionPercentage::Calc(_) => todo!(), + DimensionPercentage::Calc(_) => todo!("Calc is not supported yet"), } } @@ -533,7 +533,7 @@ fn convert_border_side_width( border::BorderSideWidth::Thick => LengthPercentage::Points(border_width_config.thick), border::BorderSideWidth::Medium => LengthPercentage::Points(border_width_config.medium), border::BorderSideWidth::Thin => LengthPercentage::Points(border_width_config.thin), - border::BorderSideWidth::Length(_) => unimplemented!(), + border::BorderSideWidth::Length(_) => todo!("Only Length::Value is supported"), } } diff --git a/packages/plasmo/src/render.rs b/packages/plasmo/src/render.rs index 4185f3a62..68e239331 100644 --- a/packages/plasmo/src/render.rs +++ b/packages/plasmo/src/render.rs @@ -210,7 +210,7 @@ impl RinkWidget for NodeRef<'_> { [1, -1] => [points_history[1][0], points_history[1][1] - 1], [-1, 1] => [points_history[1][0], points_history[1][1] + 1], [-1, -1] => [points_history[1][0] - 1, points_history[1][1]], - _ => todo!(), + _ => unreachable!(), }; draw( buf, @@ -253,7 +253,7 @@ impl RinkWidget for NodeRef<'_> { _ => match border.radius { Dimension::Percent(p) => p * area.width as f32 / 100.0, Dimension::Points(p) => p, - _ => todo!(), + _ => unreachable!(), } .abs() .min((area.width as f32 / RADIUS_MULTIPLIER[0]) / 2.0) diff --git a/packages/plasmo/src/style_attributes.rs b/packages/plasmo/src/style_attributes.rs index d1e8c6bee..d75de29d3 100644 --- a/packages/plasmo/src/style_attributes.rs +++ b/packages/plasmo/src/style_attributes.rs @@ -384,7 +384,7 @@ fn apply_border(name: &str, value: &str, style: &mut StyleModifier) { "outset" => BorderStyle::Outset, "none" => BorderStyle::None, "hidden" => BorderStyle::Hidden, - _ => todo!(), + _ => todo!("Implement other border styles"), } } match name { @@ -582,7 +582,7 @@ fn apply_font(name: &str, value: &str, style: &mut StyleModifier) { "oblique" => style.core = style.core.add_modifier(Modifier::ITALIC), _ => (), }, - "font-variant" => todo!(), + "font-variant" => todo!("Implement font-variant"), "font-weight" => match value { "bold" => style.core = style.core.add_modifier(Modifier::BOLD), "normal" => style.core = style.core.remove_modifier(Modifier::BOLD), @@ -596,8 +596,8 @@ fn apply_text(name: &str, value: &str, style: &mut StyleModifier) { use ratatui::style::Modifier; match name { - "text-align" => todo!(), - "text-align-last" => todo!(), + "text-align" => todo!("Implement text-align"), + "text-align-last" => todo!("text-Implement align-last"), "text-decoration" | "text-decoration-line" => { for v in value.split(' ') { match v { @@ -607,19 +607,19 @@ fn apply_text(name: &str, value: &str, style: &mut StyleModifier) { } } } - "text-decoration-color" => todo!(), - "text-decoration-style" => todo!(), - "text-indent" => todo!(), - "text-justify" => todo!(), - "text-overflow" => todo!(), - "text-shadow" => todo!(), - "text-transform" => todo!(), - _ => todo!(), + "text-decoration-color" => todo!("text-Implement decoration-color"), + "text-decoration-style" => todo!("text-Implement decoration-style"), + "text-indent" => todo!("Implement text-indent"), + "text-justify" => todo!("Implement text-justify"), + "text-overflow" => todo!("Implement text-overflow"), + "text-shadow" => todo!("Implement text-shadow"), + "text-transform" => todo!("Implement text-transform"), + _ => todo!("Implement other text attributes"), } } fn apply_transition(_name: &str, _value: &str, _style: &mut StyleModifier) { - todo!() + todo!("Implement transitions") } const SORTED_STYLE_ATTRS: &[&str] = &[ diff --git a/packages/router/src/history/memory.rs b/packages/router/src/history/memory.rs index d079aad76..ab0558c40 100644 --- a/packages/router/src/history/memory.rs +++ b/packages/router/src/history/memory.rs @@ -21,9 +21,9 @@ where /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] diff --git a/packages/router/src/history/mod.rs b/packages/router/src/history/mod.rs index e869e288d..18ee092e6 100644 --- a/packages/router/src/history/mod.rs +++ b/packages/router/src/history/mod.rs @@ -54,9 +54,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -92,8 +92,8 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } - /// # fn Other() -> Element { todo!() } + /// # fn Index() -> Element { None } + /// # fn Other() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -121,9 +121,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -153,9 +153,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -186,9 +186,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -219,9 +219,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] @@ -248,9 +248,9 @@ pub trait HistoryProvider { /// # use dioxus_router::prelude::*; /// # use dioxus::prelude::*; /// # #[component] - /// # fn Index() -> Element { todo!() } + /// # fn Index() -> Element { None } /// # #[component] - /// # fn OtherPage() -> Element { todo!() } + /// # fn OtherPage() -> Element { None } /// #[derive(Clone, Routable, Debug, PartialEq)] /// enum Route { /// #[route("/")] diff --git a/packages/router/src/navigation.rs b/packages/router/src/navigation.rs index dea87afa2..3c8a8e28d 100644 --- a/packages/router/src/navigation.rs +++ b/packages/router/src/navigation.rs @@ -20,7 +20,7 @@ pub enum NavigationTarget { /// # use dioxus_router::navigation::NavigationTarget; /// # #[component] /// # fn Index() -> Element { - /// # todo!() + /// # unreachable!() /// # } /// #[derive(Clone, Routable, PartialEq, Debug)] /// enum Route { @@ -40,7 +40,7 @@ pub enum NavigationTarget { /// # use dioxus_router::navigation::NavigationTarget; /// # #[component] /// # fn Index() -> Element { - /// # todo!() + /// # unreachable!() /// # } /// #[derive(Clone, Routable, PartialEq, Debug)] /// enum Route { diff --git a/packages/router/src/routable.rs b/packages/router/src/routable.rs index 35096f431..7037355ca 100644 --- a/packages/router/src/routable.rs +++ b/packages/router/src/routable.rs @@ -213,9 +213,9 @@ pub trait Routable: FromStr + Display + Clone + 'static { /// use dioxus::prelude::*; /// /// #[component] - /// fn Home() -> Element { todo!() } + /// fn Home() -> Element { None } /// #[component] - /// fn About() -> Element { todo!() } + /// fn About() -> Element { None } /// /// #[derive(Routable, Clone, PartialEq, Debug)] /// enum Route { @@ -255,9 +255,9 @@ pub trait Routable: FromStr + Display + Clone + 'static { /// use dioxus::prelude::*; /// /// #[component] - /// fn Home() -> Element { todo!() } + /// fn Home() -> Element { None } /// #[component] - /// fn About() -> Element { todo!() } + /// fn About() -> Element { None } /// /// #[derive(Routable, Clone, PartialEq, Debug)] /// enum Route { diff --git a/packages/router/src/router_cfg.rs b/packages/router/src/router_cfg.rs index 1642f79c7..0c81faae1 100644 --- a/packages/router/src/router_cfg.rs +++ b/packages/router/src/router_cfg.rs @@ -15,7 +15,7 @@ use crate::prelude::*; /// # use dioxus::prelude::*; /// # #[component] /// # fn Index() -> Element { -/// # todo!() +/// # None /// # } /// #[derive(Clone, Routable)] /// enum Route { diff --git a/packages/router/tests/via_ssr/link.rs b/packages/router/tests/via_ssr/link.rs index 3a8f93a3d..d332e1adf 100644 --- a/packages/router/tests/via_ssr/link.rs +++ b/packages/router/tests/via_ssr/link.rs @@ -60,7 +60,7 @@ fn href_internal() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -94,7 +94,7 @@ fn href_external() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -129,7 +129,7 @@ fn with_class() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -195,7 +195,7 @@ fn with_active_class_inactive() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -232,7 +232,7 @@ fn with_id() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -268,7 +268,7 @@ fn with_new_tab() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] @@ -334,7 +334,7 @@ fn with_rel() { #[component] fn Test() -> Element { - todo!() + unimplemented!() } #[component] diff --git a/packages/rsx/src/attribute.rs b/packages/rsx/src/attribute.rs index 34429495d..1a403b901 100644 --- a/packages/rsx/src/attribute.rs +++ b/packages/rsx/src/attribute.rs @@ -169,7 +169,7 @@ impl ToTokens for ElementAttrNamed { dioxus_elements::events::#name(#tokens) } } - ElementAttrName::Custom(_) => todo!(), + ElementAttrName::Custom(_) => unreachable!("Handled elsewhere in the macro"), }, _ => { quote! { dioxus_elements::events::#value(#value) } @@ -338,7 +338,7 @@ impl ElementAttrValue { } }) } - _ => todo!(), + _ => unreachable!("Invalid combination of attributes"), } } } diff --git a/packages/server-macro/src/lib.rs b/packages/server-macro/src/lib.rs index ecf07056c..e7b51f79b 100644 --- a/packages/server-macro/src/lib.rs +++ b/packages/server-macro/src/lib.rs @@ -40,7 +40,7 @@ use syn::{ /// #[server(ReadPosts, "/api")] /// pub async fn read_posts(how_many: u8, query: String) -> Result, ServerFnError> { /// // do some work on the server to access the database -/// todo!() +/// # unimplemented!() /// } /// ``` /// diff --git a/packages/signals/examples/errors.rs b/packages/signals/examples/errors.rs index 43384fa68..31b89f43a 100644 --- a/packages/signals/examples/errors.rs +++ b/packages/signals/examples/errors.rs @@ -35,7 +35,7 @@ fn Read() -> Element { let _write = signal.write(); let _read = signal.read(); - todo!() + unreachable!() } #[component] @@ -45,7 +45,7 @@ fn ReadMut() -> Element { let _read = signal.read(); let _write = signal.write(); - todo!() + unreachable!() } #[component]