From 967c082085cef158de6ae955fd43f5936bd13455 Mon Sep 17 00:00:00 2001 From: Evan Almloff Date: Tue, 9 Jan 2024 11:02:07 -0600 Subject: [PATCH] clippy fix --- packages/core/src/diff/iterator.rs | 8 ++++---- packages/core/src/diff/mod.rs | 2 +- packages/core/src/virtual_dom.rs | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/core/src/diff/iterator.rs b/packages/core/src/diff/iterator.rs index a94b78395..7c3555e15 100644 --- a/packages/core/src/diff/iterator.rs +++ b/packages/core/src/diff/iterator.rs @@ -116,7 +116,7 @@ impl VirtualDom { // // `shared_prefix_count` is the count of how many nodes at the start of // `new` and `old` share the same keys. - let (left_offset, right_offset) = match self.diff_keyed_ends(to, old, new, parent.clone()) { + let (left_offset, right_offset) = match self.diff_keyed_ends(to, old, new, parent) { Some(count) => count, None => return, }; @@ -340,7 +340,7 @@ impl VirtualDom { let new_idx = idx + last + 1; let old_index = new_index_to_old_index[new_idx]; if old_index == u32::MAX as usize { - nodes_created += new_node.create(self, to, parent.clone()); + nodes_created += new_node.create(self, to, parent); } else { old[old_index].diff_node(new_node, self, to); nodes_created += new_node.push_all_real_nodes(self, to); @@ -363,7 +363,7 @@ impl VirtualDom { let new_idx = idx + next + 1; let old_index = new_index_to_old_index[new_idx]; if old_index == u32::MAX as usize { - nodes_created += new_node.create(self, to, parent.clone()); + nodes_created += new_node.create(self, to, parent); } else { old[old_index].diff_node(new_node, self, to); nodes_created += new_node.push_all_real_nodes(self, to); @@ -386,7 +386,7 @@ impl VirtualDom { for (idx, new_node) in new[..first_lis].iter().enumerate() { let old_index = new_index_to_old_index[idx]; if old_index == u32::MAX as usize { - nodes_created += new_node.create(self, to, parent.clone()); + nodes_created += new_node.create(self, to, parent); } else { old[old_index].diff_node(new_node, self, to); nodes_created += new_node.push_all_real_nodes(self, to); diff --git a/packages/core/src/diff/mod.rs b/packages/core/src/diff/mod.rs index 34ed86dbe..db6b25e9b 100644 --- a/packages/core/src/diff/mod.rs +++ b/packages/core/src/diff/mod.rs @@ -22,7 +22,7 @@ impl VirtualDom { ) -> usize { nodes .into_iter() - .map(|child| child.create(self, to, parent.clone())) + .map(|child| child.create(self, to, parent)) .sum() } diff --git a/packages/core/src/virtual_dom.rs b/packages/core/src/virtual_dom.rs index a460ff1e3..b3ca1ec52 100644 --- a/packages/core/src/virtual_dom.rs +++ b/packages/core/src/virtual_dom.rs @@ -369,7 +369,7 @@ impl VirtualDom { | <-- no, broke early */ let parent_path = match self.elements.get(element.0) { - Some(Some(el)) => el.clone(), + Some(Some(el)) => *el, _ => return, }; let mut parent_node = Some(parent_path);