fix lints on rust 1.89 (#4587)

packages/core/src/effect.rs

@@ -36,18 +36,18 @@ impl Effect {
     }
 }
 
-impl PartialOrd for Effect {
-    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        Some(self.order.cmp(&other.order))
-    }
-}
-
 impl Ord for Effect {
     fn cmp(&self, other: &Self) -> std::cmp::Ordering {
         self.order.cmp(&other.order)
     }
 }
 
+impl PartialOrd for Effect {
+    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
+        Some(self.cmp(other))
+    }
+}
+
 impl PartialEq for Effect {
     fn eq(&self, other: &Self) -> bool {
         self.order == other.order

packages/core/src/error_boundary.rs

@@ -250,7 +250,7 @@ impl ErrorContext {
     }
 
     /// Get all errors thrown from child components
-    pub fn errors(&self) -> Ref<[CapturedError]> {
+    pub fn errors(&self) -> Ref<'_, [CapturedError]> {
         Ref::map(self.errors.borrow(), |errors| errors.as_slice())
     }
 

packages/core/src/scheduler.rs

@@ -265,17 +265,16 @@ impl Borrow<ScopeOrder> for DirtyTasks {
     }
 }
 
-impl PartialOrd for DirtyTasks {
-    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        Some(self.order.cmp(&other.order))
-    }
-}
-
 impl Ord for DirtyTasks {
     fn cmp(&self, other: &Self) -> std::cmp::Ordering {
         self.order.cmp(&other.order)
     }
 }
+impl PartialOrd for DirtyTasks {
+    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
+        Some(self.cmp(other))
+    }
+}
 
 impl PartialEq for DirtyTasks {
     fn eq(&self, other: &Self) -> bool {

packages/core/src/scope_context.rs

@@ -294,7 +294,7 @@ impl Scope {
         for ctx in contexts.iter_mut() {
             // Swap the ptr directly
             if let Some(ctx) = ctx.downcast_mut::<T>() {
-                std::mem::swap(ctx, &mut value.clone());
+                *ctx = value.clone();
                 return value;
             }
         }

packages/core/src/suspense/mod.rs

@@ -170,7 +170,7 @@ impl SuspenseContext {
     }
 
     /// Get all suspended tasks
-    pub fn suspended_futures(&self) -> Ref<[SuspendedFuture]> {
+    pub fn suspended_futures(&self) -> Ref<'_, [SuspendedFuture]> {
         Ref::map(self.inner.suspended_tasks.borrow(), |tasks| {
             tasks.as_slice()
         })