From bc707db8325f9d95e3f94e962b1f378a6a04d0de Mon Sep 17 00:00:00 2001
From: Jonathan Kelley <jkelleyrtp@gmail.com>
Date: Thu, 29 Dec 2022 00:46:02 -0500
Subject: [PATCH] chore: make clippy happy and limit workspace checks

---
 .vscode/settings.json           | 3 ++-
 packages/rsx-rosetta/src/lib.rs | 8 +++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 819ffec5d..ebd52887e 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -2,5 +2,6 @@
   "editor.formatOnSave": true,
   "[toml]": {
     "editor.formatOnSave": false
-  }
+  },
+  "rust-analyzer.checkOnSave.allTargets": false,
 }
diff --git a/packages/rsx-rosetta/src/lib.rs b/packages/rsx-rosetta/src/lib.rs
index 1d1248852..83f79883c 100644
--- a/packages/rsx-rosetta/src/lib.rs
+++ b/packages/rsx-rosetta/src/lib.rs
@@ -8,8 +8,7 @@ pub fn convert_from_html(dom: Dom) -> CallBody {
         roots: dom
             .children
             .into_iter()
-            .map(|f| create_body_node_from_node(f))
-            .filter_map(|f| f)
+            .filter_map(create_body_node_from_node)
             .collect(),
     }
 }
@@ -37,7 +36,7 @@ fn create_body_node_from_node(node: Node) -> Option<BodyNode> {
                     ElementAttrNamed {
                         attr: ElementAttr::AttrText {
                             name: ident,
-                            value: ifmt_from_text(value.unwrap_or("false".to_string())),
+                            value: ifmt_from_text(value.unwrap_or_else(|| "false".to_string())),
                         },
                         el_name: el_name.clone(),
                     }
@@ -68,8 +67,7 @@ fn create_body_node_from_node(node: Node) -> Option<BodyNode> {
             let children = el
                 .children
                 .into_iter()
-                .map(|f| create_body_node_from_node(f))
-                .filter_map(|f| f)
+                .filter_map(create_body_node_from_node)
                 .collect();
 
             Some(BodyNode::Element(Element {