Merge branch 'master' of github.com:DioxusLabs/dioxus

packages/core/src/create.rs

@@ -81,9 +81,7 @@ impl<'b> VirtualDom {
 
         // The best renderers will have templates prehydrated and registered
         // Just in case, let's create the template using instructions anyways
-        if !self.templates.contains_key(&node.template.get().name) {
-            self.register_template(node.template.get());
-        }
+        self.register_template(node.template.get());
 
         // we know that this will generate at least one mutation per node
         self.mutations
@@ -389,30 +387,36 @@ impl<'b> VirtualDom {
 
     /// Insert a new template into the VirtualDom's template registry
     pub(crate) fn register_template(&mut self, mut template: Template<'static>) {
-        // First, make sure we mark the template as seen, regardless if we process it
         let (path, byte_index) = template.name.rsplit_once(':').unwrap();
         let byte_index = byte_index.parse::<usize>().unwrap();
-
-        // if hot reloading is enabled, then we need to check for a template that has overriten this one
-        #[cfg(debug_assertions)]
-        if let Some(mut new_template) = self
+        // First, check if we've already seen this template
+        if self
             .templates
-            .get_mut(path)
-            .and_then(|map| map.remove(&usize::MAX))
+            .get(&path)
+            .filter(|set| set.contains_key(&byte_index))
+            .is_none()
         {
-            // the byte index of the hot reloaded template could be different
-            new_template.name = template.name;
-            template = new_template;
-        }
+            // if hot reloading is enabled, then we need to check for a template that has overriten this one
+            #[cfg(debug_assertions)]
+            if let Some(mut new_template) = self
+                .templates
+                .get_mut(path)
+                .and_then(|map| map.remove(&usize::MAX))
+            {
+                // the byte index of the hot reloaded template could be different
+                new_template.name = template.name;
+                template = new_template;
+            }
 
-        self.templates
-            .entry(path)
-            .or_default()
-            .insert(byte_index, template);
+            self.templates
+                .entry(path)
+                .or_default()
+                .insert(byte_index, template);
 
-        // If it's all dynamic nodes, then we don't need to register it
-        if !template.is_completely_dynamic() {
-            self.mutations.templates.push(template);
+            // If it's all dynamic nodes, then we don't need to register it
+            if !template.is_completely_dynamic() {
+                self.mutations.templates.push(template);
+            }
         }
     }
 

packages/core/src/nodes.rs

@@ -819,7 +819,6 @@ impl<'a, 'b> IntoTemplate<'a> for LazyNodes<'a, 'b> {
 }
 
 // Note that we're using the E as a generic but this is never crafted anyways.
-#[doc(hidden)]
 pub struct FromNodeIterator;
 impl<'a, T, I> IntoDynNode<'a, FromNodeIterator> for T
 where

packages/core/src/scopes.rs

@@ -556,7 +556,7 @@ impl<'src> ScopeState {
     #[allow(clippy::mut_from_ref)]
     pub fn use_hook<State: 'static>(&self, initializer: impl FnOnce() -> State) -> &mut State {
         let cur_hook = self.hook_idx.get();
-        let mut hook_list = self.hook_list.borrow_mut();
+        let mut hook_list = self.hook_list.try_borrow_mut().expect("The hook list is already borrowed: This error is likely caused by trying to use a hook inside a hook which violates the rules of hooks.");
 
         if cur_hook >= hook_list.len() {
             hook_list.push(self.hook_arena.alloc(initializer()));

packages/tui/examples/text.rs

@@ -12,7 +12,7 @@ fn app(cx: Scope) -> Element {
             width: "100%",
             height: "100%",
             flex_direction: "column",
-            onwheel: move |evt| alpha.set((**alpha + evt.inner().delta().strip_units().y as i64).min(100).max(0)),
+            onwheel: move |evt| alpha.set((**alpha + evt.inner().delta().strip_units().y as i64).clamp(0, 100)),
 
             p {
                 background_color: "black",