fix non-bubbling event propagation

packages/core/src/virtual_dom.rs

@@ -384,7 +384,9 @@ impl VirtualDom {
             data,
         };
 
-        // Loop through each dynamic attribute in this template before moving up to the template's parent.
+        // If the event bubbles, we traverse through the tree until we find the target element.
+        if bubbles {
+            // Loop through each dynamic attribute (in a depth first order) in this template before moving up to the template's parent.
             while let Some(el_ref) = parent_path {
                 // safety: we maintain references of all vnodes in the element slab
                 let template = unsafe { el_ref.template.unwrap().as_ref() };
@@ -400,11 +402,6 @@ impl VirtualDom {
                     {
                         listeners.push(&attr.value);
 
-                    // Break if the event doesn't bubble anyways
-                    if !bubbles {
-                        break;
-                    }
-
                         // Break if this is the exact target element.
                         // This means we won't call two listeners with the same name on the same element. This should be
                         // documented, or be rejected from the rsx! macro outright
@@ -430,6 +427,31 @@ impl VirtualDom {
 
                 parent_path = template.parent.and_then(|id| self.elements.get(id.0));
             }
+        } else {
+            // Otherwise, we just call the listener on the target element
+            if let Some(el_ref) = parent_path {
+                // safety: we maintain references of all vnodes in the element slab
+                let template = unsafe { el_ref.template.unwrap().as_ref() };
+                let node_template = template.template.get();
+                let target_path = el_ref.path;
+
+                for (idx, attr) in template.dynamic_attrs.iter().enumerate() {
+                    let this_path = node_template.attr_paths[idx];
+
+                    // Remove the "on" prefix if it exists, TODO, we should remove this and settle on one
+                    // Only call the listener if this is the exact target element.
+                    if attr.name.trim_start_matches("on") == name && target_path == this_path {
+                        if let AttributeValue::Listener(listener) = &attr.value {
+                            if let Some(cb) = listener.borrow_mut().as_deref_mut() {
+                                cb(uievent.clone());
+                            }
+
+                            break;
+                        }
+                    }
+                }
+            }
+        }
     }
 
     /// Wait for the scheduler to have any work.