fix: interaction between both hot-reload engines (#4083)

* fix: interaction between both hot-reload engines

* correct comment
This commit is contained in:
Jonathan Kelley authored and GitHub committed 2025-05-07 11:35:25 -07:00
1 parent b2ec1d957b
commit d00636ca31
4 files changed
+601 -506

No files matched your search

+3 -5
View File
@@ -393,11 +393,9 @@ impl AppServer {
}
}
// We decided to make the hotpatch engine drive *all* hotreloads, even if they are just RSX
// hot-reloads. This is a temporary measure to thoroughly test the hotpatch engine until
// we're comfortable with both co-existing. Keeping both would lead to two potential sources
// of errors, and we want to avoid that for now.
if needs_full_rebuild || self.use_hotpatch_engine {
// todo - we need to distinguish between hotpatchable rebuilds and true full rebuilds.
// A full rebuild is required when the user modifies static initializers which we haven't wired up yet.
if needs_full_rebuild {
if self.use_hotpatch_engine {
self.client.patch_rebuild(files.to_vec());
if let Some(server) = self.server.as_mut() {