From e03d8ff215ce9c617cc6e8661565609765299071 Mon Sep 17 00:00:00 2001 From: Evan Almloff Date: Mon, 3 Nov 2025 20:10:38 -0600 Subject: [PATCH] fix windows builds (#4903) --- packages/cli/src/build/request.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs index 9064130b3..cf1233585 100644 --- a/packages/cli/src/build/request.rs +++ b/packages/cli/src/build/request.rs @@ -908,7 +908,7 @@ impl BuildRequest { ]); } - // On windows, we pass /SUBSYSTbEM:WINDOWS to prevent a console from appearing + // On windows, we pass /SUBSYSTEM:WINDOWS to prevent a console from appearing if matches!(bundle, BundleFormat::Windows) && !rustflags .flags @@ -922,6 +922,11 @@ impl BuildRequest { rustflags .flags .push(format!("-Clink-arg=/SUBSYSTEM:{}", subsystem)); + // We also need to set the entry point to mainCRTStartup to avoid windows looking + // for a WinMain function + rustflags + .flags + .push("-Clink-arg=/ENTRY:mainCRTStartup".to_string()); } // Make sure we set the sysroot for ios builds in the event the user doesn't have it set