swaits/dioxus
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix double triggering events

Browse Source
This commit is contained in:
Evan Almloff committed 2023-10-04 08:58:28 -05:00
1 parent d5b7a6d15e
commit ed95ac932d
1 file changed
+5 -21
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/virtual_dom.rs
+5 -21
View File
@@ -375,30 +375,14 @@ impl VirtualDom {
for (idx, attr) in template.dynamic_attrs.iter().enumerate() { for (idx, attr) in template.dynamic_attrs.iter().enumerate() {
let this_path = node_template.attr_paths[idx]; let this_path = node_template.attr_paths[idx];
fn add_listener<'a>(
attribute: &'a Attribute<'a>,
event_name: &str,
listeners: &mut Vec<&'a AttributeValue<'a>>,
) {
if attribute.name.trim_start_matches("on") == event_name {
listeners.push(&attribute.value);
}
listeners.push(&attribute.value);
}
// Remove the "on" prefix if it exists, TODO, we should remove this and settle on one // Remove the "on" prefix if it exists, TODO, we should remove this and settle on one
if target_path.is_decendant(&this_path) { if target_path.is_decendant(&this_path) {
match &attr.ty { attr.ty.for_each(|attribute| {
AttributeType::Single(attribute) => { if attribute.name.trim_start_matches("on") == name {
add_listener(attribute, name, &mut listeners); listeners.push(&attribute.value);
} }
AttributeType::Many(attributes) => { });
for attribute in *attributes {
add_listener(attribute, name, &mut listeners);
}
}
}
// Break if this is the exact target element. // Break if this is the exact target element.
// This means we won't call two listeners with the same name on the same element. This should be // This means we won't call two listeners with the same name on the same element. This should be
// documented, or be rejected from the rsx! macro outright // documented, or be rejected from the rsx! macro outright