diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5411af846..4ccafff16 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -139,12 +139,8 @@ jobs: - name: "doc --lib --all-features" run: | cargo doc --workspace --no-deps --all-features --document-private-items - # env: - # RUSTFLAGS: --cfg docsrs - # RUSTDOCFLAGS: --cfg docsrs - # todo: re-enable warnings, private items - # RUSTDOCFLAGS: --cfg docsrs -Dwarnings - # --document-private-items + env: + RUSTDOCFLAGS: -Dwarnings --document-private-items check: if: github.event.pull_request.draft == false diff --git a/Cargo.lock b/Cargo.lock index eaa4cd1ba..228129dd6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4404,6 +4404,7 @@ dependencies = [ "dioxus-fullstack-hooks", "dioxus-history", "dioxus-lib", + "dioxus-router", "dioxus-router-macro", "dioxus-ssr", "rustversion", diff --git a/packages/cli/src/build/builder.rs b/packages/cli/src/build/builder.rs index 8284cfca5..42b706fc5 100644 --- a/packages/cli/src/build/builder.rs +++ b/packages/cli/src/build/builder.rs @@ -1140,7 +1140,7 @@ We checked the folder: {} /// - If the app fails to launch, errors are logged for debugging purposes. /// /// # Resources: - /// - https://developer.android.com/studio/run/emulator-commandline + /// - async fn open_android_sim( &self, root: bool, diff --git a/packages/cli/src/build/patch.rs b/packages/cli/src/build/patch.rs index 86a71ea7b..aff5f8f4f 100644 --- a/packages/cli/src/build/patch.rs +++ b/packages/cli/src/build/patch.rs @@ -415,7 +415,7 @@ fn create_native_jump_table( /// It doesn't seem like we can compile the base module to export these, sadly, so we're going /// to manually satisfy them here, removing their need to be imported. /// -/// https://github.com/WebAssembly/tool-conventions/blob/main/DynamicLinking.md +/// fn create_wasm_jump_table(patch: &Path, cache: &HotpatchModuleCache) -> Result { let name_to_ifunc_old = &cache.symbol_ifunc_map; let old = &cache.old_wasm; @@ -1299,7 +1299,7 @@ pub fn prepare_wasm_base_module(bytes: &[u8]) -> Result> { /// /// Uses the heuristics from the wasm-bindgen source code itself: /// -/// https://github.com/rustwasm/wasm-bindgen/blob/c35cc9369d5e0dc418986f7811a0dd702fb33ef9/crates/cli-support/src/wit/mod.rs#L1165 +/// fn name_is_bindgen_symbol(name: &str) -> bool { name.contains("__wbindgen_describe") || name.contains("__wbindgen_externref") diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs index ae30417a1..31ff61d17 100644 --- a/packages/cli/src/build/request.rs +++ b/packages/cli/src/build/request.rs @@ -55,7 +55,7 @@ //! //! Currently, we defer most of our deploy-based bundling to Tauri bundle, though we should migrate //! to just bundling everything ourselves. This would require us to implement code-signing which -//! is a bit of a pain, but fortunately a solved process (https://github.com/rust-mobile/xbuild). +//! is a bit of a pain, but fortunately a solved process (). //! //! ## Build Structure //! @@ -107,7 +107,7 @@ //! //! ### Linux: //! -//! https://docs.appimage.org/reference/appdir.html#ref-appdir +//! //! current_exe.join("Assets") //! ``` //! app.appimage/ @@ -157,7 +157,7 @@ //! drive the kotlin build ourselves. This would let us drop gradle (yay! no plugins!) but requires //! us to manage dependencies (like kotlinc) ourselves (yuck!). //! -//! https://github.com/WanghongLin/miscellaneous/blob/master/tools/build-apk-manually.sh +//! //! //! Unfortunately, it seems that while we can drop the `android` build plugin, we still will need //! gradle since kotlin is basically gradle-only. @@ -309,8 +309,8 @@ //! The idea here is that we can run any of the programs in the same way that they're deployed. //! //! ## Bundle structure links -//! - apple: ://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle> -//! - appimage: ://docs.appimage.org/packaging-guide/manual.html#ref-manual> +//! - apple: +//! - appimage: //! //! ## Extra links //! - xbuild: diff --git a/packages/cli/src/build/tools.rs b/packages/cli/src/build/tools.rs index 10aed816d..d2db7ee5b 100644 --- a/packages/cli/src/build/tools.rs +++ b/packages/cli/src/build/tools.rs @@ -8,7 +8,7 @@ use tokio::process::Command; /// The tools for Android (ndk, sdk, etc) /// -/// https://gist.github.com/Pulimet/5013acf2cd5b28e55036c82c91bd56d8?permalink_comment_id=3678614 +/// #[derive(Debug, Clone)] pub(crate) struct AndroidTools { pub(crate) sdk: Option, diff --git a/packages/cli/src/cli/build.rs b/packages/cli/src/cli/build.rs index 26cce0d3f..b748bf645 100644 --- a/packages/cli/src/cli/build.rs +++ b/packages/cli/src/cli/build.rs @@ -43,7 +43,7 @@ pub struct BuildArgs { /// /// Server and Client are special targets that integrate with `dx serve`, while `crate` is a generic. /// - /// ``` + /// ```sh /// dx serve \ /// client --target aarch64-apple-darwin \ /// server --target wasm32-unknown-unknown \ diff --git a/packages/cli/src/cli/check.rs b/packages/cli/src/cli/check.rs index dd4812698..28abe05a7 100644 --- a/packages/cli/src/cli/check.rs +++ b/packages/cli/src/cli/check.rs @@ -1,7 +1,7 @@ //! Run linting against the user's codebase. //! //! For reference, the rustfmt main.rs file -//! https://github.com/rust-lang/rustfmt/blob/master/src/bin/main.rs +//! use super::*; use crate::BuildRequest; diff --git a/packages/cli/src/cli/create.rs b/packages/cli/src/cli/create.rs index 067532ef4..62175ec6b 100644 --- a/packages/cli/src/cli/create.rs +++ b/packages/cli/src/cli/create.rs @@ -38,7 +38,7 @@ pub struct Create { #[clap(long)] subtemplate: Option, - /// Pass