* it works!
* fix wasm hotpatch error
* bump wasmopt
* rename wasmopt flag
* rename ldd_keep_exports
* add build profiling
* undo bundle ignore
* some cleanups
* more cleanups
* wip: hoist up telemetry to builder
* fix compile
* wip: flamegraph rewrite
* clean up flamegraph impl
* cleanup profiling engine
* add comment on spans obj
* cleanup more phases
* more cleanup
* small cleanups
* bit more cleanups
* cleanup phases
* sign with tokio, not std proc
* split out the specific platform helpers
* cleanup a bit
* more cleanups
* more cleanups
* more cleanups
* more cleanups
* pull out fingerprint logic
* wip... I think I have a slightly better approach. saving checkpoint
* hm I think it's better now?
* fix: also seems to work not in workspace mode juuust yet
* okay yay almost there
* clooose but not there yet
* fix: manually export __wasm_apply_data_relocs since got relocations weren't firing
WASM workspace hotpatching: export __wasm_apply_global_relocs to fix call_indirect type mismatch
When workspace crates are recompiled with -Crelocation-model=pic for hotpatching, wasm-ld generates GOT.func.internal globals that hold element-segment-relative offsets (e.g., MetricCardProps::memoize = 31). These need __table_base added at runtime by __wasm_apply_global_relocs to become absolute table indices.
wasm-ld generates __wasm_apply_global_relocs but treats it as an internal synthetic function -- neither --export nor --export-if-defined will export it. Without the export, the runtime's call silently failed (the old code used unchecked_into on undefined), leaving the globals unrelocated. Function pointers then pointed to index 31 in the original module's table (some unrelated function) instead of table_base + 31 (the patched function), causing call_indirect to a signature that does not match.
Three changes:
patch.rs: After walrus processing, find __wasm_apply_global_relocs by name and add it as an export before emitting the patched wasm.
lib.rs: Replace unchecked_into with dyn_into for calling relocation functions, so missing exports are handled gracefully instead of silently swallowed.
link.rs: Remove the ineffective --export-if-defined flags that were added during debugging.
* cleanup
* fix scope dir
* change up naming a bit
* more tidying up
* more cleanups
* ignore early return
* clean er up
* more comprehensive cache bustign
* bust fingerprints of dag
* move bust_fingerprint back to request.rs
* add better rustdoc
* more idiomatic
* more cleanups
* fix panic, typos
* more lints
* only delete workspace prints in fat mod
* clippy
* initial version
* make custom permission work without const-vec change
* wiring up with cli
* yey symbol found
* wip
* holy moly
* proper ui
* cleanup
* okay
* wip cleanup
* reduce boilerplate code into mobile-core
* Delete copilot-instructions.md
* revert hello-world example for low diff
* fix android build in mobile-core
* rename permission to static_permission
* small success with popup location on android
* android popup working
* Refactor permission checks for readability
Improves code formatting in has_location_permission and check_permission functions by splitting long lines and updating function signatures for better readability. No functional changes were made.
* wip consolidate all java files and build from cli instead of build.rs
* few cli cleanups
* wip java_plugin macro
* cleanup cleanup cleanup
* Update java_plugin macro to use full relative file paths
The java_plugin macro now accepts full relative paths for Java files instead of assuming a fixed directory structure. Documentation and usage examples have been updated to reflect this change, improving flexibility and clarity for specifying file locations.
* Improve iOS geolocation permission and retrieval logic
Added checks for authorization status before requesting location permissions and retrieving location data. Now only requests permission if not determined, and attempts to retrieve cached location before starting location updates, improving efficiency and user experience.
* Add ios_plugin macro for iOS framework metadata
Introduces the ios_plugin! macro in mobile-core-macro for declarative iOS framework metadata embedding. Updates mobile-core to re-export the macro and refactors mobile-geolocation to use ios_plugin! instead of manual linker attributes.
* not needed
* simplify the plugin
* rename mobile-core to platform-bridge and mobile-core-macro to platform-bridge-macro
* Refactor metadata serialization buffer initialization
Replaces inline creation of ConstVec with a named EMPTY constant for buffer initialization in metadata serialization. This improves code clarity and maintainability.
* mobile-geolocation out of dioxus
* take the example also out of dioxus
* remove example from cargo toml
* remove demo css
* revert hello-world example
* revert mac.plist
* revert gitignore
* Remove basic usage example for permissions crate
Deleted the basic_usage.rs example file from the permissions crate. This change may be part of a cleanup or refactoring to remove outdated or unnecessary example code.
* Delete plan.md
* remove dups
* cleanup java build
* cleanup permission symbol extraction
* update todo
* small slop of tested permissions in enums for minimum diff
* Refactor symbol extraction into linker_symbols module
Moved generic symbol extraction logic from android_java.rs and permissions.rs into a new linker_symbols.rs module. Updated both files to use the shared utilities for finding symbol offsets, reducing code duplication and improving maintainability.
* wip consolidate ios and macos as darwin
* Add docs and re-export for MainThreadCell and MainThreadMarker
Expanded documentation for MainThreadCell, clarifying usage and safety. Changed visibility of MainThreadCell to public, improved method docs, and re-exported MainThreadMarker in darwin/mod.rs for easier access.
* Update Darwin framework symbol and section names
Changed the framework symbol prefix from '__DARWIN_FRAMEWORK__' to '__DARWIN_FW__' and updated the Mach-O section name from '__darwin_framework' to '__darwin_fw' for compliance with section name length limits and consistency.
* Fix Info.plist path handling for iOS and macOS
Adds comments and corrects the path to Info.plist for iOS and macOS app bundles. For iOS, Info.plist is at the root of the .app bundle, while for macOS it is inside Contents/. Also improves warning message to include the missing path.
* Handle missing permission symbols and web bundle case
Improves permission extraction by returning an empty manifest when no permission symbols are found or when building a web bundle, as permissions are runtime-only in that case. Adds debug logging for missing symbols and ensures robust handling of these scenarios.
* objc2 over framework
* windows, linux, web all permissions are runtime so cleanup
* only include permissions for build time
* cleanup unnecessary test
* more cleanup
* extract shared into dx-macro-helpers
* rc.3 to 0.7.0 for const-serialize
* Add CustomPermissionBuilder and enhance PermissionBuilder for better permission management
- Introduced `CustomPermissionBuilder` for creating custom permissions with platform-specific identifiers.
- Enhanced `PermissionBuilder` to support custom permissions and location permissions with a clear builder pattern.
- Updated documentation and examples in the macro README to reflect new usage patterns for custom and location permissions.
- Improved parsing logic in the macro to handle both builder and direct construction patterns for permissions.
* clippy fixes
* implement const cbor encoding + decoding for basic types
* Add #[used] attribute to linker sections for optimization protection
- Added #[used] attribute to linker sections in both permission and Android plugin macros to prevent the linker from optimizing away symbols, ensuring they are preserved even if unused.
- Created static references to linker sections to enhance defense-in-depth against optimization issues.
* implement map encoding and decoding
* fix map test
* wip unified linker symbol
* cleanup permissions
* pipe java sources with manganis as well
* all tests passing
* dynamically sized arrays
* smaller str encoding
* swap array and list and add more documentation
* move serialization and deserialization for each struct together
* support both legacy and new assets
* bump const serialize version
* fix asset conversion code
* pull out manganis symbol struct from tuble
* test reading old asset versions
* more list/array cleanup and bump rust version
* fix clippy
* Revert "pipe java sources with manganis as well"
This reverts commit ddea9a459d9ac26f3f037a74d9ae0de3edfced67.
* Revert "cleanup permissions"
This reverts commit 7b18500155237403e179f0783cb8903a4f158b80.
* Revert "wip unified linker symbol"
This reverts commit 813e33feddb30d26868f6ac6e6da318402ac138f.
* Revert "Add #[used] attribute to linker sections for optimization protection"
This reverts commit a94a7a3a5e8eee80060de9d66a53aabfcf554f96.
* update cargo lock
* wip permission through assets
* abit cleanup
* fix reexports
* fix assets
* Fix the permissions piping
* some small cleanups
* checkout const-serialize as per #4932 and fix build
* invoking swift as a package
* geolocation package & example dumping for easy testing
* keep geolocation simple for testing
* cleanups
* pipe everything through __ASSETS__ and cleanup
* remove linker_symbols helper file
* example
* re example
* copy build methos into mobile-plugin-build crate
* Add conditional import for dioxus_07 feature
Introduces a conditional import to use the dioxus_07 crate when the corresponding feature is enabled, improving compatibility with different dioxus versions.
* Improve error handling and JNI reference usage
Adds a null check for Objective-C instance initialization in the iOS geolocation plugin to prevent errors on failed allocation. Refactors Android callback to use local JNI references instead of creating unnecessary global references, reducing potential memory leaks.
* revert changes on playwright
* Update dioxus dependency to 0.7.2 in Cargo.lock
Removed dioxus 0.7.1 from dependencies, retaining only dioxus 0.7.2 for the dioxus-cli-optimization-test package.
* small cleanup
* Add legacy const-serialize 0.7 support to dx-macro-helpers
Introduces support for the const-serialize 0.7 format in dx-macro-helpers by adding a new dependency and export, as well as a helper function for serialization with layout padding. Updates manganis to use the new helper for serializing assets in the legacy format, simplifying code and improving maintainability.
* Add helper for legacy and current linker sections
Introduces generate_link_sections_with_legacy in dx-macro-helpers to emit both legacy and current linker sections for compatibility. Refactors manganis-macro to use this new helper, reducing duplication and improving maintainability.
* Fix lints
* Fix clippy and doctest
* Refactor asset bundling and allow large enum variant
Refactored Asset::bundled to use Vec<u8> instead of ConstVec for reading volatile slices, simplifying the code and improving compatibility. Added #[allow(clippy::large_enum_variant)] to SymbolData enum to suppress Clippy warnings about large enum variants.
* Update license URLs in README to use angle brackets
Changed license URLs in the README from parentheses to angle brackets for improved formatting and clarity.
* Fix asset deserialization with correct buffer type
Replaces the use of `bytes.read()` with `ConstReadBuffer::new(bytes.as_ref())` for asset deserialization, ensuring compatibility with the expected deserialization API.
* Refactor geolocation and asset handling for clarity
Removed unnecessary clones in geolocation example event handlers to simplify state management. Updated SymbolDataOrAsset to store SymbolData in a Box for improved memory handling and adjusted related logic. Fixed documentation example in geolocation lib to include PermissionState in the import.
* Update geolocation example and permissions usage docs
Removes unused variables in the geolocation example's App function. Updates the permissions crate documentation to reflect new API usage with PermissionBuilder and LocationPrecision.
* Update permissions-macro to use permissions crate
Switched imports and dev-dependency from permissions_core to permissions in permissions-macro. Updated documentation and examples to reflect the new crate usage.
* rollback const-serialize changes
* move items around (doesn't compile)
* convert gelocation plugin to example
* remove dx-macro-helpers
* we're just gonna full-send linker everything
* rollback desktop changes
* remove gradle
* fix most compile?
* fix dioxus vers
* small cleanups
* add claude design docs
* add ffi macro
* remove
* loads but not linking yet
* fix output leak
* a little bit closer but not quite
* improve android code gen
* sheeeeee works!!!
* small tweaks to demo
* replace ios/android plugin with ffi macro entirely
* simplify ffi module
* simplify again
* condense / rip out some stuff from manganis
* remove types form public api
* wip, permissions
* oops I broke it
* I unbroke it
* move arch doc
* remove extra manifest types
* drop bindgen file
* remove permission
* small cleanup
* remove unsafecall mtm thing
* yoink perms
* wire up manifest
* Add deeplinks
* add schema generation
* update schema
* wip....
* fix recurse limit schema generation
* wip, muck around with schema
* add inline dioxus.toml support
* merge bundle config schemas
* claude my man
* Remove cdecl, annotate ffi
* rename design docs
* wip: live activities
* wip: apple plugin bundling
* wip
* get live activities linking properly
* small cleanups
* remove sidecars
* remove widget
* yoink legacy
* cleanup
* more fixups
* wire up more things to dioxus.toml
* fix workspace join
* final cleanups
* fmt
* final bit of clippy
* ci tweak
* update schema
* fmt, doc
* update schema docs
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* fix: hotpatching fullstack
* add hot-patching fullstack test
* add caching to playwright apt-get
* only run playwright on beta
* install binutils?
* dont commit lockfile
* ignore lockfiles
* make sure ld is in path
overhaul dioxus fullstack using a new implementation of server_fn
This PR is a complete rewrite of dioxus fullstack designed to improve compatibility with axum and to fix a number of compilation errors based on feature flag unification plumbing through macros.
* wip: fixes to get docsite working again
* Fix asset location with PIC in hot patched builds
* Add an hidden cli flag to exit early in hot patch tests on failure
* add a test for hot patching with assets
* fix clippy
* fix looks_like_manganis_symbol
* longer timeout for hot patching in CI
* log page content
* log assets
* Log asset after write
* record a playwright trace
* Explicitly enable cargo incremental for hot patching
* fix retry for patch test
* reset asset
* disable hot patching test for new exports
* add nightly playwright
* use different toolchain names
* use beta instead of nightly for less thrashing
* add failing test
* workaround hot reloading bug
* restore swapping asset tests
* add toolchain
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Add initial version of hash history
* wip...
* more cleanups
* cleanup the web history impl and then add a playwright test
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* adhox: Fix Clippy lints in const-serialize etc.
Fix the clippy lints that were preventing building:
* const-serialize/src/lib.rs
* core/src/nodes.rs
* fullstack/src/serve_config.rs
* adhoc: Change the way to satisfy the lint for 1.85
The lint for pointer comparison is only in 1.85. The solution
uses a mechanism that was only stabilized with 1.85. Instead
of using that solution, will just allow the lint on this
function for now. Once the MSRV of Dioxus is updated to 1.85
or above, this can be changed to use the recommeneded solution.
* adhoc: Fix the 'cargo make test' tests
There were a number of tests failing to compile and/or run.
Fixed those that could be meaningfully fixed. Those that were
incomplete examples that could not be fixed are marked as
'ignore'.
* adhoc: GitIgnore test results in playwright tests
* fix wry rollback
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
Enable runtime rust hot patching.
* roll back wry to 0.45
* cleanup rustc
* wip
* wip: fix client/server
* get the subsecond cli thing working again
* back to list of builds but with accessors
* migrate some methods to workspace, clean up impl a bit
* pass mode through build context
* use a build context, similar to cargo/rustc
* merge BuildUpdate and HandleUpdate into BuilderUpdate
* Move more resolution of args into runner
* migrate some methods to runner
* hoist out fullstack
* fix build request resolver
* yay request is cleaned up
* fixup resolution a bit
* spawn off the build!
* re-wire android autodetection
* re-wire android autodetection
* wire back up a few more things
* re-wire tooling verification
* I think it's mostly in the right condition for regular app
* add depinfo parser
* yay okay works with regular apps again
* full rebuilds are back
* rewire file wtcher
* wire patch!
* yayyyyyy patching works and is really fast
* yay android works
* clean up stdout piping
* yayyy memap on android so we don't need root
* create a static wasm jump table
* wip: global offset table for wasm
* wip... thinking about making the patches relocatable
* wip: customized relocation
* YESSSSSS RELOCATABLE WASM
* clean up impl a bit
* lil bit more cleanup
* lil bit more
* lil bit more cleanup
* lil bit more cleanup, support 32 bit platforms
* sick, wasm is completely pic
* hmmmm not quite working yet
* woooo, patches loading from rust+wasm
* integrated into the cli 😎
* condense a bit
* cleaned up request a bit
* bust fingerprints
* Make the file diffing logic a bit more sensible
* still working through a few issues, server launches but is acting weird
* fix merge conflict
* more merge issues
* remove stuff we don't want anymore
* revert name change
* wip: server not working anymore :(
* split apart "dioxus fullstack" into "dioxus server" and "dioxus web"
* fixup a few more compile errors
* grrr opening server
* simultaneous frontend and backend patching
* use rustc wrapper
* wip: passing assets to jumptable
* migrate project-like examples
* patchy patchy server fns!
* rollback some random changes
* unwind the js files
* rollback hash
* no need for patch
* more cleanups
* lil bit more cleanup, remove some old cruft
* allow patching when wasm webpage is closed
* tiny bit more robust
* lil bit of clean up
* clean up ws code
* bit more clean ups
* condense
* undo file moves
* move back other project
* move other project
* migrate out harness and janky CLI
* fix compile
* anonymize some files, heavily document others
* lots more documentation, for posterity!
* ton more docs
* clean up the cli a bit more
* more ws cleanup
* more cleanup
* migrate build id to cli-config
* add command file handling
* random small cleanups
* wip....
* wip....
* fix: use workspace for krate discovery
* fix panic logging on serve by placing it *after* the logs
* reorder logging to be sensible on success
* bring back swc
* ws cruft
* small patches to relocs in loader
* bump krates
* hoist main funcs into the ifunc table, fixing wasm
* fix tui output for long lines
* add more linker logging
* wow, incredible, we build fat binaries, holy heckkkkk
* fix args for frontend/backend
* small cleanups
* properly send along build IDs to clients
* fix workspace compiles
* clean up jump table work a bit
* clean up logging a bit
* open existing
* fixup some commands
* open existing browser integration
* wire up the new dx serve client/server syntax
* fixup `dx run` command
* bring back some old functionality
* fix serverfn feature sets
* remove toast animation and simplify its code a bit
* less intrusive toast
* dont change build status when patching on web
* add proper cache busting to vcomponent
* clean up the patch file a bit
* more lints/checks cleaned up
* go back to TargetArgs but a BuildTargets resolved struct
* clean up more nits
* use an atomicptr for jumptable
* fix interaction with initial web load + suspense
* don't run asset system on wasm/bindgen js in dev
* reduce blast radius of PR
* use profile to determine if we're in release
* cleanup prod html template
* cleanup profiles
* fix feature resolution of fullstack
* if fullstack is explicitly false, don't use it
* light cleanups
* drop carg config2
* pass along linker args properly
* make workspace examples compile with dx again
* fewer unwraps and better error loggign
* bit more error handlign
* small cleanup
* drive-by cleanups
* use queries instead of initialize for aslr stuff
* fix hotpatch with higher opt level
* fix aslr bug from multiple clients
* fix merge conflict
* fix typos
* clippy
* fix miscompile
* fix doctest
* properly rollback wry to 0.45
* fix markdown path issues, other test issues
* fix test in router
* fix release mode test
* fix some more tests, clean up a few more items
* use fnptr instead of typeid
* clean up memozation via subsecond in core
* use "main" as sentinel
* fix imports and re-exports
* get off __rust_alloc for aslr offset detection
* wip
* wip... fixing unoptimized web
* hmmmm mmmm
* close,ish, still missing the wasmbindgen dynaimc imports
* aha! full wasm works now
- disable externref when compilng patch modules
- manually link wasm instrinsics
- displace the __wbindgen_placeholder__ table with the synthesized wbg imports
what an awful pain.
There might be a few items missing, so will test against the docsite shortly
* remove failing test
* hmmmm things aren't perfect
* from what I can tell, relocatable wasm just doesn't work with wasm-bindgen
sad
https://github.com/rustwasm/wasm-bindgen/issues/1420
* AI IS LITERALLY THE WORST
* preserve wasm snippets across compiles
* IT HOTPATCHES THE DOCSITE, WE ARE LIVING IN THE FUTURE
* remove the macos cfg-out
* fix: need to allocate 1 more page
* fix url issue
* properly span props
* properly fill in extra symbols
* light cleanups and good docs
* delete cruft, better docs
* More cleanups and simplifications
* clippy, typos
* remove harnesses
* wasm-bindgen error logging
* clean up deps
* remove cruft
* proper priv/pub
* use ifuncs for all env imports
* cruft
* use par_iter, better output
* implement a cache for the base module
* delete custom sections
* cache the main native module too
* add par iter in a few more places
* clippy, map ident
* better logging and status bars
* wip: some small windows support
* wip more windowss
* fix weird regression
* implement windows jump table
* small fixes for windows
* better windows support
* windows support pt2
* rust lld is not msvc
* whole archive the rlibs
* ignore windows and sys crates
* logging
* ohhhhhh, pop out dlls
* dedupe
* thANK GOD FAT LINKING WORKS ON WINDOWS
* hoist caching
* implement patch based on cache
* fix location for pdb
* pass data symbols, correct object
* add all symbol for windows
* add log
* treat none rva as undefined
* whoops
* handle windows calling convention
* dont use relocated arm64 stub windows
* not all are text?
* WINDOWS FUNCTION PATCHING WORKS
but issue with statics?
* use our own entry
* handle windows imp symbols
* add log
* jump to the real symbol not the layout
* whoops
* hotpatching windows works completely holy heck yay
* drop linker args crate
* disable ssg playwright for now
* light cleanups
* some cleanups / preps:
- bump to serverfn 0.8.2
- fix playwright test
- fix clippy
* use fix from #4042
* bring in other fix for liveview
* hoist some configuration
* use __aslr_reference instead of aslr_reference
* add better errors to patcherror
* fix android
* panic if patching fails
* clean up tomls
* wip: fixing wasm compile for server
* fullstack wasm again
* fix cfg
* fixup feature detection
* fix issue with features
* fix playwright!
* add barebones template test harness
* fix compatibility between the two hotreload engines
* fix preldue of server
* fix check for wasm-opt
* small fixes
* clean up logging to avoid random extra trace
* fix race condition with updates
* properly wire up verbose
* fix bundling (macos) and logging
* Add structured output
* clean up clap names
* extract out wire format
* switch structured key to json
* fix random println, fallback to `dioxus/platform`
* clean up logging for run/build
* clean up logging around project
* remove manual exits
* fix tokio runtime for mobile
* rework dog app
* rip out ssg
* Switch dioxus/axum to dioxus/server
* add android template inline
* pre restructure for bundle prep
* add the whole res directory
* Better theme for the app
* remove mobile demo now that most apps work natively
* self-referential android
* only use deep linking for assets
* fix imports for android
* clippy, fixup ios and android
* I'm not boxing compiler message you can't make me
* fix clippy on unix
* Moves index.html creation until after wasm creation so the webserver doesn't prematurely serve the page
* sets up nasm for windows builds (to be superseded by Remove Dioxus CLI NASM dependency #2666#2682)
* puts magnanis-cli-support in a blocking task to prevent threadlocking during sequential builds
* changes order of client/server builds such that the client is built before the server so the webserver doesn't prematurely serve invalid client code
* declobbers "serve" such that each project gets a different dir in the target folder
* uses nest_service instead of fallback so the router doesn't respond with fallback codes
* reincorporates doge's fix from Fix hot-reloading on Windows #2544
Jonathan Kelley