Getting full panics here in prod:
thread '<unnamed>' (23) panicked at /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/dioxus-fullstack-0.7.0/src/magic.rs:554:22:
called `Result::unwrap()` on an `Err` value: Response { status: 500, version: HTTP/1.1, headers: {"content-type": "application/json"}, body: Body(UnsyncBoxBody) }
Could be triggered by something as simple as a client choosing to send formdata-style body instead of JSON. (I discovered this because exactly that was happening; not maliciously, but because of the upgrade from 0.6.3 to 0.7).
As far as I can tell, this was just meant to be an early return with a failure case of the Response, mapped from the ServerFnError. The .unwrap() left there was probably just an erroneous artifact from the various waves of the development process.
If this is incorrect or I've missed something, please let me know! But I believe this is a very simple fix for an otherwise critical problem
* wip: redirect
* redirect example
* fix file upload not in a form
* wip
* deny missing cfgs
* wip: add router fallback but it's not working
* fix suspense bug after rebuilds that queued work
* more cleanup
* add test for error codes
* add helpful comment
* bring back middleware annotation
* fix cfg
* add server feature
* fix doctest
* just disable liveview test for now
* fix liveview
* dont send init
* cache more playwright!
* add more pkgs to cache
* allow `--server` only builds!
* rollback example
* capture `/:route` routes
* fix: properly implement file uploads in forms
* implement desktop form uploads
* Performant serialization of form bytes
* finish up file stuff
* cleanups
* add request headers to streaming context
* remove some unwraps
overhaul dioxus fullstack using a new implementation of server_fn
This PR is a complete rewrite of dioxus fullstack designed to improve compatibility with axum and to fix a number of compilation errors based on feature flag unification plumbing through macros.
Enable runtime rust hot patching.
* roll back wry to 0.45
* cleanup rustc
* wip
* wip: fix client/server
* get the subsecond cli thing working again
* back to list of builds but with accessors
* migrate some methods to workspace, clean up impl a bit
* pass mode through build context
* use a build context, similar to cargo/rustc
* merge BuildUpdate and HandleUpdate into BuilderUpdate
* Move more resolution of args into runner
* migrate some methods to runner
* hoist out fullstack
* fix build request resolver
* yay request is cleaned up
* fixup resolution a bit
* spawn off the build!
* re-wire android autodetection
* re-wire android autodetection
* wire back up a few more things
* re-wire tooling verification
* I think it's mostly in the right condition for regular app
* add depinfo parser
* yay okay works with regular apps again
* full rebuilds are back
* rewire file wtcher
* wire patch!
* yayyyyyy patching works and is really fast
* yay android works
* clean up stdout piping
* yayyy memap on android so we don't need root
* create a static wasm jump table
* wip: global offset table for wasm
* wip... thinking about making the patches relocatable
* wip: customized relocation
* YESSSSSS RELOCATABLE WASM
* clean up impl a bit
* lil bit more cleanup
* lil bit more
* lil bit more cleanup
* lil bit more cleanup, support 32 bit platforms
* sick, wasm is completely pic
* hmmmm not quite working yet
* woooo, patches loading from rust+wasm
* integrated into the cli 😎
* condense a bit
* cleaned up request a bit
* bust fingerprints
* Make the file diffing logic a bit more sensible
* still working through a few issues, server launches but is acting weird
* fix merge conflict
* more merge issues
* remove stuff we don't want anymore
* revert name change
* wip: server not working anymore :(
* split apart "dioxus fullstack" into "dioxus server" and "dioxus web"
* fixup a few more compile errors
* grrr opening server
* simultaneous frontend and backend patching
* use rustc wrapper
* wip: passing assets to jumptable
* migrate project-like examples
* patchy patchy server fns!
* rollback some random changes
* unwind the js files
* rollback hash
* no need for patch
* more cleanups
* lil bit more cleanup, remove some old cruft
* allow patching when wasm webpage is closed
* tiny bit more robust
* lil bit of clean up
* clean up ws code
* bit more clean ups
* condense
* undo file moves
* move back other project
* move other project
* migrate out harness and janky CLI
* fix compile
* anonymize some files, heavily document others
* lots more documentation, for posterity!
* ton more docs
* clean up the cli a bit more
* more ws cleanup
* more cleanup
* migrate build id to cli-config
* add command file handling
* random small cleanups
* wip....
* wip....
* fix: use workspace for krate discovery
* fix panic logging on serve by placing it *after* the logs
* reorder logging to be sensible on success
* bring back swc
* ws cruft
* small patches to relocs in loader
* bump krates
* hoist main funcs into the ifunc table, fixing wasm
* fix tui output for long lines
* add more linker logging
* wow, incredible, we build fat binaries, holy heckkkkk
* fix args for frontend/backend
* small cleanups
* properly send along build IDs to clients
* fix workspace compiles
* clean up jump table work a bit
* clean up logging a bit
* open existing
* fixup some commands
* open existing browser integration
* wire up the new dx serve client/server syntax
* fixup `dx run` command
* bring back some old functionality
* fix serverfn feature sets
* remove toast animation and simplify its code a bit
* less intrusive toast
* dont change build status when patching on web
* add proper cache busting to vcomponent
* clean up the patch file a bit
* more lints/checks cleaned up
* go back to TargetArgs but a BuildTargets resolved struct
* clean up more nits
* use an atomicptr for jumptable
* fix interaction with initial web load + suspense
* don't run asset system on wasm/bindgen js in dev
* reduce blast radius of PR
* use profile to determine if we're in release
* cleanup prod html template
* cleanup profiles
* fix feature resolution of fullstack
* if fullstack is explicitly false, don't use it
* light cleanups
* drop carg config2
* pass along linker args properly
* make workspace examples compile with dx again
* fewer unwraps and better error loggign
* bit more error handlign
* small cleanup
* drive-by cleanups
* use queries instead of initialize for aslr stuff
* fix hotpatch with higher opt level
* fix aslr bug from multiple clients
* fix merge conflict
* fix typos
* clippy
* fix miscompile
* fix doctest
* properly rollback wry to 0.45
* fix markdown path issues, other test issues
* fix test in router
* fix release mode test
* fix some more tests, clean up a few more items
* use fnptr instead of typeid
* clean up memozation via subsecond in core
* use "main" as sentinel
* fix imports and re-exports
* get off __rust_alloc for aslr offset detection
* wip
* wip... fixing unoptimized web
* hmmmm mmmm
* close,ish, still missing the wasmbindgen dynaimc imports
* aha! full wasm works now
- disable externref when compilng patch modules
- manually link wasm instrinsics
- displace the __wbindgen_placeholder__ table with the synthesized wbg imports
what an awful pain.
There might be a few items missing, so will test against the docsite shortly
* remove failing test
* hmmmm things aren't perfect
* from what I can tell, relocatable wasm just doesn't work with wasm-bindgen
sad
https://github.com/rustwasm/wasm-bindgen/issues/1420
* AI IS LITERALLY THE WORST
* preserve wasm snippets across compiles
* IT HOTPATCHES THE DOCSITE, WE ARE LIVING IN THE FUTURE
* remove the macos cfg-out
* fix: need to allocate 1 more page
* fix url issue
* properly span props
* properly fill in extra symbols
* light cleanups and good docs
* delete cruft, better docs
* More cleanups and simplifications
* clippy, typos
* remove harnesses
* wasm-bindgen error logging
* clean up deps
* remove cruft
* proper priv/pub
* use ifuncs for all env imports
* cruft
* use par_iter, better output
* implement a cache for the base module
* delete custom sections
* cache the main native module too
* add par iter in a few more places
* clippy, map ident
* better logging and status bars
* wip: some small windows support
* wip more windowss
* fix weird regression
* implement windows jump table
* small fixes for windows
* better windows support
* windows support pt2
* rust lld is not msvc
* whole archive the rlibs
* ignore windows and sys crates
* logging
* ohhhhhh, pop out dlls
* dedupe
* thANK GOD FAT LINKING WORKS ON WINDOWS
* hoist caching
* implement patch based on cache
* fix location for pdb
* pass data symbols, correct object
* add all symbol for windows
* add log
* treat none rva as undefined
* whoops
* handle windows calling convention
* dont use relocated arm64 stub windows
* not all are text?
* WINDOWS FUNCTION PATCHING WORKS
but issue with statics?
* use our own entry
* handle windows imp symbols
* add log
* jump to the real symbol not the layout
* whoops
* hotpatching windows works completely holy heck yay
* drop linker args crate
* disable ssg playwright for now
* light cleanups
* some cleanups / preps:
- bump to serverfn 0.8.2
- fix playwright test
- fix clippy
* use fix from #4042
* bring in other fix for liveview
* hoist some configuration
* use __aslr_reference instead of aslr_reference
* add better errors to patcherror
* fix android
* panic if patching fails
* clean up tomls
* wip: fixing wasm compile for server
* fullstack wasm again
* fix cfg
* fixup feature detection
* fix issue with features
* fix playwright!
* add barebones template test harness
* fix compatibility between the two hotreload engines
* fix preldue of server
* fix check for wasm-opt
* small fixes
* changes to support axum 0.8
* fixing ci/cd failures. I would like advice on the change to cli/server
* putting back in something I took out because I am retarded
* update server function revision
* remove playwright test results
* clippy
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Change the suspense streaming context after suspense is resolved in the router
* Wait for the suspense context before streaming the first chunk in ssr
* forward more response parts
* warn
* extract the hydration format into a crate
* Fix hydration when no data is sent
* forward web and server features
* Fix suspense that starts on the client
* fix use_server_future on the client
* Add documentation for fullstack hooks and protocol
* downgrade rust edition
* fix clippy
* fix tests
* fix clippy
* Fix pure web compile
* undo changes to the fullstack router example
* fix formatting
The current `axum` feature and `server` feature are incompatible with wasm32-unknown-unknown target
due to:
1. depends on axum features not compatible with wasm
2. SSR requires reading the filesystem for index.html
With this patch I add the `server_fn_axum` feature which disables SSR and enables targeting
wasm32-unknown-unknown with server functions enabled.
Note that for this to work, `server_fn` depends on `inventory` and as stated in this docs depending on
the context you might need to expose and call [`__wasm_call_ctors`](https://docs.rs/inventory/latest/inventory/#webassembly-and-constructors)
(I needed that specifically for cloudflare workers)
change axum_server_fn feature for axum_wasm and include SSR tools there
This change additionaly make axum_server_fn feature additive by exposing a different
`DioxusRouterWasmExt` with only the wasm-compatible parts instead of exposing the
`DioxusRouter` trait under the same name.
Docs are updated to reflect this change.
rename axum_wasm to axum_core and update docs
fix typo
re-enable default-features for axum in dioxus-cli
re-enable axum default-features for liveview
re-enable default-features for axum for playwright-tests
* return a 404 when paring the route fails
* add a playwright test for fullstack routing status codes
* Fix new playwright test
* document SSRError
* Make SSRError public and fix clippy
* Move the error display bound to the routable trait
* fix clippy
* return a more generic 404 message
* fix router tests
* Add server context to suspense resolution
While this was done correctly in the streaming case, non-streaming
suspense resolution didn't recieve the server context. This meant that
anything that required the context after the point of suspension would
find it missing.
* fmt
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Fix hydration of suspense fragments that contain text nodes
* fix release builds
* disable link deduplication
* restore meta tag deduplication
* Add a test for the failed hydration case
* make changes to the document trait non-breaking
* remove info log from server future hook
* restore default implementation - this was also a breaking change
* fix semver breakage
* clean up server_future
* Cleanup unused code
* fix clippy
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Create a crate for constant serialization of config structs for manganis
* use SerializeConst for the image asset builder
* switch to a declarative macro for assets
* clean up asset macro a bit
* add serializable options for each asset type
* serialize const vec
* Add unique path formatting
* implement the new manganis macro
* optimize assets in the CLI
* Fix clippy
* Fix assets with dioxus formattable
* reduce fuzzing test limits
* use the new syntax in examples
* fix formatting
* Final doc and test pass on const-serialize
* fix avif support
* Fix manganis doc tests
* cache asset optimization
* Split out asset and bundled asset
* make hash pointer width independent
* remove const serialize cargo lock
* Fix manganis macro docs
* all tests passing
* add constvec::is_empty method to fix clippy lint
* remove nasm feature
* simplify test_rsplit_once test so typos passes
* fix range syntax for stable
* revert example change from clippy fix
* remove dioxus-static-site-generation workspace dependency
* always accept unix paths
* fix windows path seperator
* fix folder asset hash
* Optimize assets in a blocking task
* Fix asset options docs
* Document Asset and BundledAsset
* move manganis back into it's own folder
* simplify the linker macro a bit
* add more docs to AssetParser expansion
* fix manganis core doc test
* add image format helpers
* Fill in new cargo.tomls
* fix folders with explicit options
* Split by both unix and windows path separators and take the smallest one
* fix string length
* Fix base path on web and fullstack
* Fix assets with base path
* fix fullstack base route with trailing slash
* fix clippy
* wip: fix manganis import path
* upgrade tauri bundler, convert todo!() to unimplemented!()
* feat: mobile hotreloading + ios asset configuration
* remove oid demo and its associated env vars
* nuke all the things that cause cache thrashing
* swap to Asset type
* add some more logs
* display impl for attrvalue
* dont panic on collect failure
* cut down web deps to 150
* clean up deps in a lot of places, simplify build scripts
* clean up asset resolution and cli-dev profile
* wire up absolute paths for manganis asset in a particular mode
* move document related things around to shorten compile times
* move most things to `document::Item` and then decompose the cli-config
* switch link to stylesheet for clarity in examples
* move manganis workspace example to examples folder
* decompose manganis-cli-support
* dont need mobile demo anymore
* remove gloo dialogs
* html doesnt need document
* rename hotreload to devtools
* really clean up the html crate
* fix weird rsx spacing
* clean up desktop to use callback
* clean up document a bit
* re-wire up devsocket
* fix utf css
* yeeeet that js out of here
* synthetic web system works
* web crate almost done being cleaned up
* desktop mostly cleaned up too
* clean up cli a bit
* more cli cleanup
* cli builds again
* clean up cli, inline structs, cut down number of unique types where possible
* hotreload works again for desktop and this time, mobile too
* cfg out tungstenite
* devserver err
* more refactor to cli builder
* switch to unbounded_send
* new structure is much cleaner
* add http serve subcommand
* bundled hotreload
* kick stylsheets
* clean up a bit more, split up eventloop
* amazingly serve seems done
* change from pub to pub(crate) in cli
* remove tools
* bit more polish to cli
* fix issue with join
* gracefully handle fullstack without a server
* fullstack mobile demo
* fix launch function, move projects into example-projects folder
* hoist examples
* add "run" command
* clean up launch
* remove old manual websocket receiver
* doctor command
* allow desktop to scroll
* cut apart router crate
* dont put launch in prelude
* use dioxus::launch where possible
* rename rsx, cut out hotreload tests
* remove liveview project
* bump native
* fix compile for renderers
* move sync event response out of interpreter
* move render in serve
* rollback settings change
* cli compiles, huzzah!
* change uris for asset
* fix asset
* new tui screen
* new cargo-like tui works
* very very verty close
* it works! very small bug with incorrect grapheme calc
* Clean up devserver a bit
* status sytem
* tidy up debug filters
* clean up logging situation
* Fix a number of bugs with log printing
* new printing system is more reliable
* wire up more stuff
* things working but fullstack is having issues
* fullstack works again!
* hotreloading bundled assets works again
* bundled hotreload and beginnings of macos bundling
* Hotreload desktop
* combined server builds
* add build handle
* fix fullstack assets
* make open async, add some hooks for ios
* migrate filemap to runner
* wip global crate system
* fixup bundles + organize asset
* fix asset location bug
* all the bundled reloading!
* open ios simulator!
* full hotreload support for mobile + serverfn
* basic cleanups
* clean up dx
* Move filemap
* fix cutting of newlines
* assets workibg, some android
* hoist wry/tao
* use sync locks and headers to fix issues with android
* desktop -> mac/win/linux with alias
* better logging
* feat: workspace (entire computer!) hotreload
* should rebuild toggle, ios simulator bootup
* proper mobile support in launch
* more robust handling of assets
* fix cargo
* bring back some of tauri bundle
* make warnings go away, clippy happy on cli
* some final clippy cleanups
* fmt
* move manganis to its own folder
* upgrade bundle to stable
* drastically slim down manganis, prepping for merge
* typos, failing test, docsrs config
* remove static gen test
* nix static gen test
* we use --platform web instead of --platform fullstack now
* only bind dev urls in desktop/mobile
* install gtk
* nix static gen
* split build dir by app name
* add a default head method through eval
* remove the old document trait
* implement document for each platform
* pull out document into a dedicated crate to cut down on shared dependencies
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* improve documentation for the fullstack server context
* Add a section about axum integration to the crate root docs
* make serve_dioxus_application accept the cfg builder directly
* remove unused server_fn module
* improve fullstack config docs
* improve documentation for the server function macro
* fix axum router extension link
* Fix doc tests
* Fix launch builder
* Simplify the launch builder
* don't re-export launch in the prelude
* refactor fullstack launch
* Fix fullstack launch builder
* Update static generation with the new builder api
* fix some formatting/overly broad launch replacements
* fix custom menu example
* fix fullstack/static generation examples
* Fix static generation launch
* A few small formatting fixes
* Fix a few doc tests
* implement LaunchConfig for serve configs
* fix fullstack launch with separate web and server launch methods
* fix check with all features
* dont expose inner core module
* clippy and check
* fix readme
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
Javier E.