* test: add failing idempotency tests for commented-out RSX blocks
Two variants of the regression introduced in v0.7.4 (#5257):
- commented_rsx_block: first line keeps indent, rest gets dedented
- commented_rsx_block_nested: entire block gets dedented
See #5463
* fix(autofmt): preserve indentation of commented-out RSX blocks
Trailing comments before `}` in write_rsx_block were indented at
parent level instead of child level. Truncate the tab from
tabbed_line() and bump indent to child level before
apply_line_comments, same approach as write_trailing_body_comments.
Fixes#5463
* fix(cli): display user-specified address in serve output
When running `dx serve --addr 0.0.0.0`, the CLI was overriding the
displayed address to 127.0.0.1. This was confusing for users who
explicitly chose 0.0.0.0 and expected the output to reflect their
choice. The default (127.0.0.1) is unchanged when no --addr flag is
given.
Fixes#5477
* fix(cli): resolve actual network IP when bound to 0.0.0.0
Instead of showing the unroutable 0.0.0.0, use the UDP socket trick
to resolve the machine's primary network address for a clickable URL.
Falls back to 127.0.0.1 when resolution fails (no network, etc).
* style: apply rustfmt to test function calls
* fit longer urls in tui frame
* space
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Suggested method for correcting integration tests
* Use static atomics for simplicity
This is consistent with the test immediately below.
* Add assertions to some tests, comments to others
This should fix a handful of tests that didn't correctly do their test.
In other places, comments should make it clearer *why* tests are how
they are.
* Be consistent with existing imports
* remove bad test
* nit
* fix compile errrs
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* it works!
* fix wasm hotpatch error
* bump wasmopt
* rename wasmopt flag
* rename ldd_keep_exports
* add build profiling
* undo bundle ignore
* some cleanups
* more cleanups
* wip: hoist up telemetry to builder
* fix compile
* wip: flamegraph rewrite
* clean up flamegraph impl
* cleanup profiling engine
* add comment on spans obj
* cleanup more phases
* more cleanup
* small cleanups
* bit more cleanups
* cleanup phases
* sign with tokio, not std proc
* split out the specific platform helpers
* cleanup a bit
* more cleanups
* more cleanups
* more cleanups
* more cleanups
* pull out fingerprint logic
* wip... I think I have a slightly better approach. saving checkpoint
* hm I think it's better now?
* fix: also seems to work not in workspace mode juuust yet
* okay yay almost there
* clooose but not there yet
* fix: manually export __wasm_apply_data_relocs since got relocations weren't firing
WASM workspace hotpatching: export __wasm_apply_global_relocs to fix call_indirect type mismatch
When workspace crates are recompiled with -Crelocation-model=pic for hotpatching, wasm-ld generates GOT.func.internal globals that hold element-segment-relative offsets (e.g., MetricCardProps::memoize = 31). These need __table_base added at runtime by __wasm_apply_global_relocs to become absolute table indices.
wasm-ld generates __wasm_apply_global_relocs but treats it as an internal synthetic function -- neither --export nor --export-if-defined will export it. Without the export, the runtime's call silently failed (the old code used unchecked_into on undefined), leaving the globals unrelocated. Function pointers then pointed to index 31 in the original module's table (some unrelated function) instead of table_base + 31 (the patched function), causing call_indirect to a signature that does not match.
Three changes:
patch.rs: After walrus processing, find __wasm_apply_global_relocs by name and add it as an export before emitting the patched wasm.
lib.rs: Replace unchecked_into with dyn_into for calling relocation functions, so missing exports are handled gracefully instead of silently swallowed.
link.rs: Remove the ineffective --export-if-defined flags that were added during debugging.
* cleanup
* fix scope dir
* change up naming a bit
* more tidying up
* more cleanups
* ignore early return
* clean er up
* more comprehensive cache bustign
* bust fingerprints of dag
* move bust_fingerprint back to request.rs
* add better rustdoc
* more idiomatic
* more cleanups
* fix panic, typos
* more lints
* only delete workspace prints in fat mod
* clippy
* add tests
* fix: include root node when store is marked dirty
* fix tracking deep subscriptions. We need to walk all parents for deep subscriptions instead of relying on tracking all children recursively during the initial read since some children may not exist yet
* avoid double notifying parents when children re-visit parents in deep mark dirty
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
Add the `inert` boolean attribute to the global HTML attribute
group and to the SSR boolean attributes list. This allows users
to set `inert` on any HTML element, matching the HTML spec.
Fixes#5455
* feat: add blanket IntoAttributeValue impl for references
Adds `impl<T: IntoAttributeValue + Clone> IntoAttributeValue for &T` so
users don't need to explicitly dereference or clone when passing references
to RSX attributes.
Closes#5444
* use to-owned
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* fix autofill events
* ignore the wrong type of event like we do in desktop
* check the event type before dispatch instead of panicing on downcast
* clean up conversion
* remove example
* pull out shared event list
* pull in deserialize_raw
* unified event list
* prettier comment
* restore test
* restore alias
* normal doc comments
* move over comments
* minimize diff
* remove alias, was moved into the macro
By using the `permissions()` method of `FileOptionsBuilder`,
which was added in version 0.20.0 of the `rpm` crate, we fix
a bug where newer versions of `rpm` (the package, not the
crate) would fail when installing the bundle.
The post-handler redirect logic was unconditionally converting responses
to 302 Found when the request had Accept: text/html and a Referer header.
This overwrote error status codes (4xx, 5xx), making it impossible to
return errors from #[get] endpoints accessed via browser navigation.
Add a response.status().is_success() guard so only successful responses
get the Post/Redirect/Get treatment.
Fixes#5428
* fix(autofmt): remove extra whitespace before commas in for-loop tuple patterns
`dx fmt` was adding spaces before commas in for-loop destructuring
patterns (e.g. `for (index , name , value)`) because `TokenStream::Display`
inserts spaces between every token. Route the pattern through prettyplease
via a new `unparse_pat` helper, following the existing `unparse_expr` pattern.
Fixes#5348
* style: apply rustfmt to writer.rs
---------
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
The test_harnesses::run_harness test panics on machines without
Android NDK/SDK installed and on non-macOS platforms for iOS
assertions. Skip these assertions gracefully instead of failing
the entire test suite.
- Android assertions: skip when get_android_tools() returns None
- iOS assertions: skip when not running on macOS
* docs: clarify difference between use_context and consume_context
Document the key distinction: use_context is a hook that captures the
context value once on first render and caches it, following the rules
of hooks. consume_context reads directly from the runtime each time
and can be called from anywhere (event handlers, async tasks, etc.).
Fixes#3862
* fix: remove redundant explicit rustdoc link targets
* fix: use plain text for cross-crate use_context reference in rustdoc
- inline mac, windows, linux bundling in the cli
- remove tauri bundle from our dep tree
- trim down the rpm crate for fewer dependencies in tree
- migrate from blacksmith to warpbuild
- move off swc and instead use esbuild via tool
- use dev drives in windows CI
- use fork of nix action for faster caching
- test bundling in CI
- fix asset handling in linux
- add default APPDATA location for webview2 installs for dioxus apps on windows
* fix: handle empty string in calculator plus-minus button
calc_val() panics on empty string when AC is pressed before the
plus-minus button. Return 0.0 early for empty input.
Fixes#4858
* fix a few ci failures
* fix link check
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
* feat(signals): add WritableResultExt trait
Add WritableResultExt mirroring the existing ReadableResultExt,
providing mutable access to signal values holding Result<T, E>.
Methods:
- as_mut(): returns Result<WritableRef<T>, WritableRef<E>>
- unwrap_mut(): returns WritableRef<T>, panics if Err
Closes#5293
* refactor(signals): use descriptive expect messages in WritableResultExt::as_mut
Replace bare .unwrap() calls with .expect() containing a descriptive
message about the failure mode. This gives better diagnostics if the
Result variant changes between the read and write lock acquisitions.
* switch to a single write to avoid race conditions with sync signals
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
* initial version
* make custom permission work without const-vec change
* wiring up with cli
* yey symbol found
* wip
* holy moly
* proper ui
* cleanup
* okay
* wip cleanup
* reduce boilerplate code into mobile-core
* Delete copilot-instructions.md
* revert hello-world example for low diff
* fix android build in mobile-core
* rename permission to static_permission
* small success with popup location on android
* android popup working
* Refactor permission checks for readability
Improves code formatting in has_location_permission and check_permission functions by splitting long lines and updating function signatures for better readability. No functional changes were made.
* wip consolidate all java files and build from cli instead of build.rs
* few cli cleanups
* wip java_plugin macro
* cleanup cleanup cleanup
* Update java_plugin macro to use full relative file paths
The java_plugin macro now accepts full relative paths for Java files instead of assuming a fixed directory structure. Documentation and usage examples have been updated to reflect this change, improving flexibility and clarity for specifying file locations.
* Improve iOS geolocation permission and retrieval logic
Added checks for authorization status before requesting location permissions and retrieving location data. Now only requests permission if not determined, and attempts to retrieve cached location before starting location updates, improving efficiency and user experience.
* Add ios_plugin macro for iOS framework metadata
Introduces the ios_plugin! macro in mobile-core-macro for declarative iOS framework metadata embedding. Updates mobile-core to re-export the macro and refactors mobile-geolocation to use ios_plugin! instead of manual linker attributes.
* not needed
* simplify the plugin
* rename mobile-core to platform-bridge and mobile-core-macro to platform-bridge-macro
* Refactor metadata serialization buffer initialization
Replaces inline creation of ConstVec with a named EMPTY constant for buffer initialization in metadata serialization. This improves code clarity and maintainability.
* mobile-geolocation out of dioxus
* take the example also out of dioxus
* remove example from cargo toml
* remove demo css
* revert hello-world example
* revert mac.plist
* revert gitignore
* Remove basic usage example for permissions crate
Deleted the basic_usage.rs example file from the permissions crate. This change may be part of a cleanup or refactoring to remove outdated or unnecessary example code.
* Delete plan.md
* remove dups
* cleanup java build
* cleanup permission symbol extraction
* update todo
* small slop of tested permissions in enums for minimum diff
* Refactor symbol extraction into linker_symbols module
Moved generic symbol extraction logic from android_java.rs and permissions.rs into a new linker_symbols.rs module. Updated both files to use the shared utilities for finding symbol offsets, reducing code duplication and improving maintainability.
* wip consolidate ios and macos as darwin
* Add docs and re-export for MainThreadCell and MainThreadMarker
Expanded documentation for MainThreadCell, clarifying usage and safety. Changed visibility of MainThreadCell to public, improved method docs, and re-exported MainThreadMarker in darwin/mod.rs for easier access.
* Update Darwin framework symbol and section names
Changed the framework symbol prefix from '__DARWIN_FRAMEWORK__' to '__DARWIN_FW__' and updated the Mach-O section name from '__darwin_framework' to '__darwin_fw' for compliance with section name length limits and consistency.
* Fix Info.plist path handling for iOS and macOS
Adds comments and corrects the path to Info.plist for iOS and macOS app bundles. For iOS, Info.plist is at the root of the .app bundle, while for macOS it is inside Contents/. Also improves warning message to include the missing path.
* Handle missing permission symbols and web bundle case
Improves permission extraction by returning an empty manifest when no permission symbols are found or when building a web bundle, as permissions are runtime-only in that case. Adds debug logging for missing symbols and ensures robust handling of these scenarios.
* objc2 over framework
* windows, linux, web all permissions are runtime so cleanup
* only include permissions for build time
* cleanup unnecessary test
* more cleanup
* extract shared into dx-macro-helpers
* rc.3 to 0.7.0 for const-serialize
* Add CustomPermissionBuilder and enhance PermissionBuilder for better permission management
- Introduced `CustomPermissionBuilder` for creating custom permissions with platform-specific identifiers.
- Enhanced `PermissionBuilder` to support custom permissions and location permissions with a clear builder pattern.
- Updated documentation and examples in the macro README to reflect new usage patterns for custom and location permissions.
- Improved parsing logic in the macro to handle both builder and direct construction patterns for permissions.
* clippy fixes
* implement const cbor encoding + decoding for basic types
* Add #[used] attribute to linker sections for optimization protection
- Added #[used] attribute to linker sections in both permission and Android plugin macros to prevent the linker from optimizing away symbols, ensuring they are preserved even if unused.
- Created static references to linker sections to enhance defense-in-depth against optimization issues.
* implement map encoding and decoding
* fix map test
* wip unified linker symbol
* cleanup permissions
* pipe java sources with manganis as well
* all tests passing
* dynamically sized arrays
* smaller str encoding
* swap array and list and add more documentation
* move serialization and deserialization for each struct together
* support both legacy and new assets
* bump const serialize version
* fix asset conversion code
* pull out manganis symbol struct from tuble
* test reading old asset versions
* more list/array cleanup and bump rust version
* fix clippy
* Revert "pipe java sources with manganis as well"
This reverts commit ddea9a459d9ac26f3f037a74d9ae0de3edfced67.
* Revert "cleanup permissions"
This reverts commit 7b18500155237403e179f0783cb8903a4f158b80.
* Revert "wip unified linker symbol"
This reverts commit 813e33feddb30d26868f6ac6e6da318402ac138f.
* Revert "Add #[used] attribute to linker sections for optimization protection"
This reverts commit a94a7a3a5e8eee80060de9d66a53aabfcf554f96.
* update cargo lock
* wip permission through assets
* abit cleanup
* fix reexports
* fix assets
* Fix the permissions piping
* some small cleanups
* checkout const-serialize as per #4932 and fix build
* invoking swift as a package
* geolocation package & example dumping for easy testing
* keep geolocation simple for testing
* cleanups
* pipe everything through __ASSETS__ and cleanup
* remove linker_symbols helper file
* example
* re example
* copy build methos into mobile-plugin-build crate
* Add conditional import for dioxus_07 feature
Introduces a conditional import to use the dioxus_07 crate when the corresponding feature is enabled, improving compatibility with different dioxus versions.
* Improve error handling and JNI reference usage
Adds a null check for Objective-C instance initialization in the iOS geolocation plugin to prevent errors on failed allocation. Refactors Android callback to use local JNI references instead of creating unnecessary global references, reducing potential memory leaks.
* revert changes on playwright
* Update dioxus dependency to 0.7.2 in Cargo.lock
Removed dioxus 0.7.1 from dependencies, retaining only dioxus 0.7.2 for the dioxus-cli-optimization-test package.
* small cleanup
* Add legacy const-serialize 0.7 support to dx-macro-helpers
Introduces support for the const-serialize 0.7 format in dx-macro-helpers by adding a new dependency and export, as well as a helper function for serialization with layout padding. Updates manganis to use the new helper for serializing assets in the legacy format, simplifying code and improving maintainability.
* Add helper for legacy and current linker sections
Introduces generate_link_sections_with_legacy in dx-macro-helpers to emit both legacy and current linker sections for compatibility. Refactors manganis-macro to use this new helper, reducing duplication and improving maintainability.
* Fix lints
* Fix clippy and doctest
* Refactor asset bundling and allow large enum variant
Refactored Asset::bundled to use Vec<u8> instead of ConstVec for reading volatile slices, simplifying the code and improving compatibility. Added #[allow(clippy::large_enum_variant)] to SymbolData enum to suppress Clippy warnings about large enum variants.
* Update license URLs in README to use angle brackets
Changed license URLs in the README from parentheses to angle brackets for improved formatting and clarity.
* Fix asset deserialization with correct buffer type
Replaces the use of `bytes.read()` with `ConstReadBuffer::new(bytes.as_ref())` for asset deserialization, ensuring compatibility with the expected deserialization API.
* Refactor geolocation and asset handling for clarity
Removed unnecessary clones in geolocation example event handlers to simplify state management. Updated SymbolDataOrAsset to store SymbolData in a Box for improved memory handling and adjusted related logic. Fixed documentation example in geolocation lib to include PermissionState in the import.
* Update geolocation example and permissions usage docs
Removes unused variables in the geolocation example's App function. Updates the permissions crate documentation to reflect new API usage with PermissionBuilder and LocationPrecision.
* Update permissions-macro to use permissions crate
Switched imports and dev-dependency from permissions_core to permissions in permissions-macro. Updated documentation and examples to reflect the new crate usage.
* rollback const-serialize changes
* move items around (doesn't compile)
* convert gelocation plugin to example
* remove dx-macro-helpers
* we're just gonna full-send linker everything
* rollback desktop changes
* remove gradle
* fix most compile?
* fix dioxus vers
* small cleanups
* add claude design docs
* add ffi macro
* remove
* loads but not linking yet
* fix output leak
* a little bit closer but not quite
* improve android code gen
* sheeeeee works!!!
* small tweaks to demo
* replace ios/android plugin with ffi macro entirely
* simplify ffi module
* simplify again
* condense / rip out some stuff from manganis
* remove types form public api
* wip, permissions
* oops I broke it
* I unbroke it
* move arch doc
* remove extra manifest types
* drop bindgen file
* remove permission
* small cleanup
* remove unsafecall mtm thing
* yoink perms
* wire up manifest
* Add deeplinks
* add schema generation
* update schema
* wip....
* fix recurse limit schema generation
* wip, muck around with schema
* add inline dioxus.toml support
* merge bundle config schemas
* claude my man
* Remove cdecl, annotate ffi
* rename design docs
* wip: live activities
* wip: apple plugin bundling
* wip
* get live activities linking properly
* small cleanups
* remove sidecars
* remove widget
* yoink legacy
* cleanup
* more fixups
* wire up more things to dioxus.toml
* fix workspace join
* final cleanups
* fmt
* final bit of clippy
* ci tweak
* update schema
* fmt, doc
* update schema docs
---------
Co-authored-by: Evan Almloff <evanalmloff@gmail.com>
Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
* Refactor cross-tls-crate-dylib configuration and update test output
- Commented out the crate-type configuration in Cargo.toml for cross-tls-crate-dylib.
- Modified the initial value of the thread-local variable FOO from 2.0 to 1.0 in the main.rs test file.
- Updated the output message in main.rs to be more descriptive.
- Added a new field `tls_fixups` to the JumpTable struct in subsecond-types, which will facilitate future runtime TLS sharing.
* ws hotpatch!
* remove old file
* undo core change
* svh
* Enhance rlib path resolution by incorporating -C extra-filename handling
* remove obj diffing
* small cleanups
* obj cache as files
* simplify
* simplify a bit
* dont bother round tripping cache
* extract to helper
* cleanup `build` function
* dont round-trip modified_crates
* make sure to wipe between full
* bit of a cleanup
* use explicit naming
* compact extra method
* fix temp cleanup
* fix warnign
* cleanup
* fmt, clippy
Sebastian Flügge