From d8a7d33d9abf8e05eec40c965ed56dad3927ece7 Mon Sep 17 00:00:00 2001 From: Stephen Waits Date: Mon, 4 May 2026 19:47:21 -0600 Subject: [PATCH] chore: silence clippy nits in new SBX/PolyMut code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - PolynomialMutation::vary: `#[allow(clippy::needless_range_loop)]` on the per-dimension loop — body indexes both `self.bounds[j]` and `child[j]` so a range index is the cleanest option. - Operator tests: replace `x >= lo && x <= hi` with `(lo..=hi).contains(&x)` per clippy's manual_range_contains lint. --- src/operators/composite.rs | 2 +- src/operators/real.rs | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/operators/composite.rs b/src/operators/composite.rs index efdd494..7467882 100644 --- a/src/operators/composite.rs +++ b/src/operators/composite.rs @@ -75,7 +75,7 @@ mod tests { for c in &children { assert_eq!(c.len(), 4); for &x in c { - assert!(x >= -1.0 && x <= 1.0); + assert!((-1.0..=1.0).contains(&x)); } } } diff --git a/src/operators/real.rs b/src/operators/real.rs index 3366fb4..37af42e 100644 --- a/src/operators/real.rs +++ b/src/operators/real.rs @@ -218,6 +218,7 @@ impl Variation> for PolynomialMutation { ); let exponent = 1.0 / (self.eta + 1.0); let mut child = parents[0].clone(); + #[allow(clippy::needless_range_loop)] // Body indexes both `self.bounds[j]` and `child[j]`. for j in 0..self.bounds.len() { if !rng.random_bool(self.per_variable_probability) { continue; @@ -357,7 +358,7 @@ mod tests { assert_eq!(children.len(), 1); assert_eq!(children[0].len(), 4); for &x in &children[0] { - assert!(x >= -1.0 && x <= 1.0, "out of bounds: {x}"); + assert!((-1.0..=1.0).contains(&x), "out of bounds: {x}"); } } } @@ -394,7 +395,7 @@ mod tests { for c in &children { assert_eq!(c.len(), 4); for &v in c { - assert!(v >= -1.0 && v <= 1.0); + assert!((-1.0..=1.0).contains(&v)); } } } @@ -435,7 +436,7 @@ mod tests { assert_eq!(children.len(), 1); assert_eq!(children[0].len(), 5); for &x in &children[0] { - assert!(x >= -1.0 && x <= 1.0, "out of bounds: {x}"); + assert!((-1.0..=1.0).contains(&x), "out of bounds: {x}"); } } }