From 00acc362fa53cc18d83f711978942f5a28026167 Mon Sep 17 00:00:00 2001 From: Stephen Waits Date: Mon, 19 Oct 2026 13:13:41 -0600 Subject: [PATCH] viewer: the all-schemes test doesn't count a thumbnail still loading MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI (GitHub's slower runners) failed every_scheme_paints_the_same_words_and_figures_readably on the Documents page: thumbnails still rendering show "…" until their picture comes, and a few were still loading when one scheme's frame was read and done when the next one's was. The placeholder isn't a word of the page: it is left out of the comparison, and its contrast is still checked. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01T3gXMVt7XJPi6ens1or9Dj --- crates/ledger-gui/src/schemes.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/ledger-gui/src/schemes.rs b/crates/ledger-gui/src/schemes.rs index 9c1d6f5..d34b154 100644 --- a/crates/ledger-gui/src/schemes.rs +++ b/crates/ledger-gui/src/schemes.rs @@ -775,10 +775,14 @@ mod painted { /// The text that can be seen, and where it is, to the pixel. fn words(texts: &[Seen], label: &str) -> Vec<(String, i32, i32)> { // The scheme button names the scheme in force: that one differs. + // A document's thumbnail still rendering shows "…" (documents.rs, + // Render::Loading) until its picture comes, whenever that is: not + // a word of the page (its contrast is still checked). CI's slower + // machines caught a page drawn with a few still loading. let button = format!("{} {label}", egui_phosphor::regular::PALETTE); texts .iter() - .filter(|t| t.text != button) + .filter(|t| t.text != button && t.text != "…") .map(|t| { ( t.text.clone(),