Control roles in the journal (books.assign_role, books.roles); the MCP reloads wanderbooks.toml on change and reports settings problems (books.settings, digest); new writes a full commented wanderbooks.toml
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
- core: ControlAccount keys, Ledger::assign_role/check_assign_role/role_account (rules.md B-23): one account per role, of the role's type, balance sheet roles move only when empty; invoices, bills, payroll, remittance, and closes post to the assigned account; an assigned role frees its default code for renumbering - store: role.assigned journaled and replayed (strict account_id) - mcp: settings.rs reloads by content at the start of each request, keeps the last good settings on a broken edit; books.settings with chart problems; digest settings_problems; instructions say when to edit the toml - viewer: journal text for role.assigned - cli: full example wanderbooks.toml, tested to load with every example uncommented - tests: spec_roles.rs (25, spec-blind), store roles.rs (6), MCP reload/problems/roles, settings unit tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX
This commit is contained in:
1 parent
efa370dfa3
commit
1771d87e0e
19 files changed
+3044
-132
No files matched your search
@@ -230,3 +230,165 @@ fn codex_gets_its_own_named_server() {
|
||||
assert!(just.contains("codex mcp add \"wanderbooks-acme-books\""));
|
||||
assert!(out.contains("just codex"), "{out}");
|
||||
}
|
||||
|
||||
/// The `wanderbooks.toml` a fresh `new` writes.
|
||||
fn scaffolded_toml(tmp: &Path) -> (PathBuf, String) {
|
||||
let books = tmp.join("b");
|
||||
assert!(new(tmp, &books, &[]).0);
|
||||
let path = books.join("wanderbooks.toml");
|
||||
let text = fs::read_to_string(&path).unwrap();
|
||||
(path, text)
|
||||
}
|
||||
|
||||
/// The example a commented line holds, if it is one: `# key = value`, or
|
||||
/// `# [section]` / `# [[section]]`. Prose comments are not examples.
|
||||
fn example(line: &str) -> Option<&str> {
|
||||
let rest = line.strip_prefix("# ")?;
|
||||
let is_key = |k: &str| !k.is_empty() && k.bytes().all(|b| b.is_ascii_lowercase() || b == b'_');
|
||||
let header = rest
|
||||
.trim_start_matches('[')
|
||||
.trim_end_matches(']')
|
||||
.split('.')
|
||||
.all(is_key);
|
||||
let assignment = rest
|
||||
.split_once(" = ")
|
||||
.is_some_and(|(k, v)| is_key(k) && !v.trim().is_empty());
|
||||
((rest.starts_with('[') && rest.ends_with(']') && header) || assignment).then_some(rest)
|
||||
}
|
||||
|
||||
/// The template with the examples `pick` chooses uncommented.
|
||||
fn uncomment(text: &str, pick: impl Fn(&str) -> bool) -> String {
|
||||
text.lines()
|
||||
.map(|l| match example(l) {
|
||||
Some(ex) if pick(ex) => ex,
|
||||
_ => l,
|
||||
})
|
||||
.collect::<Vec<_>>()
|
||||
.join("\n")
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn the_scaffolded_toml_loads_with_the_defaults() {
|
||||
let tmp = tempfile::tempdir().unwrap();
|
||||
let (path, text) = scaffolded_toml(tmp.path());
|
||||
let s = ledger_config::load(&path).expect("scaffolded wanderbooks.toml loads");
|
||||
let c = &s.company;
|
||||
assert_eq!(c.name, "Unnamed company", "name is left for onboarding");
|
||||
assert_eq!(c.fiscal_year_start, (1, 1));
|
||||
assert_eq!(c.basis, "Accrual");
|
||||
assert!(c.members.is_empty());
|
||||
assert_eq!(c.tax_form, None);
|
||||
assert_eq!(c.close_into, None);
|
||||
assert!(c.close_sweep.is_empty());
|
||||
assert_eq!(
|
||||
c.profile,
|
||||
[
|
||||
("base_currency".to_string(), "USD".to_string()),
|
||||
("fiscal_year_start".to_string(), "01-01".to_string()),
|
||||
]
|
||||
);
|
||||
assert_eq!(s.receipt_threshold.as_deref(), Some("25.00"));
|
||||
assert!(s.cash_accounts.is_empty());
|
||||
assert!(s.financing_accounts.is_empty());
|
||||
assert!(s.investing_accounts.is_empty());
|
||||
let toml: toml::Value = toml::from_str(&text).unwrap();
|
||||
assert_eq!(toml["books"]["data_dir"].as_str(), Some("books-data"));
|
||||
// The justfile's session-start reads this line with sed, from column 0.
|
||||
assert!(
|
||||
text.lines().any(|l| l == "open_at_start = \"ask\""),
|
||||
"{text}"
|
||||
);
|
||||
assert!(text.contains("SSN"), "the template warns off storing SSNs");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn every_example_in_the_toml_is_valid() {
|
||||
let tmp = tempfile::tempdir().unwrap();
|
||||
let (_, text) = scaffolded_toml(tmp.path());
|
||||
let examples = text.lines().filter_map(example).count();
|
||||
assert!(examples >= 20, "only {examples} examples found");
|
||||
// close_into is for a single owner and refused with members, so it
|
||||
// gets a pass of its own; together the two passes cover every example.
|
||||
let single_owner = |ex: &str| ex.starts_with("close_into ");
|
||||
let all = ledger_config::parse(&uncomment(&text, |ex| !single_owner(ex)))
|
||||
.unwrap_or_else(|e| panic!("examples (without close_into) parse: {e}"));
|
||||
let c = &all.company;
|
||||
assert_eq!(c.name, "Acme Widgets LLC");
|
||||
assert_eq!(c.tax_form, Some(ledger_core::TaxForm::Form1065));
|
||||
assert_eq!(c.members.len(), 2);
|
||||
assert_eq!(c.members[1].distribution_account.as_deref(), Some("3101"));
|
||||
assert_eq!(c.close_sweep, ["3100"]);
|
||||
assert!(c.profile.iter().any(|(k, _)| k == "ein"));
|
||||
assert_eq!(all.cash_accounts, ["1000", "1010"]);
|
||||
assert_eq!(all.financing_accounts, ["2100"]);
|
||||
assert_eq!(all.investing_accounts, ["1400"]);
|
||||
let single = ledger_config::parse(&uncomment(&text, single_owner))
|
||||
.unwrap_or_else(|e| panic!("close_into example parses: {e}"));
|
||||
assert_eq!(single.company.close_into.as_deref(), Some("3000"));
|
||||
assert!(
|
||||
ledger_config::parse(&uncomment(&text, |_| true)).is_err(),
|
||||
"close_into with members is refused, as the template says"
|
||||
);
|
||||
}
|
||||
|
||||
/// The serde field names of `struct name` in ledger-config's source.
|
||||
fn fields(src: &str, name: &str) -> Vec<String> {
|
||||
let start = src
|
||||
.find(&format!("struct {name} {{"))
|
||||
.unwrap_or_else(|| panic!("ledger-config has struct {name}"));
|
||||
let body = &src[start..];
|
||||
let body = &body[..body.find("\n}").expect("struct ends")];
|
||||
let found: Vec<String> = body
|
||||
.lines()
|
||||
.skip(1)
|
||||
.map(str::trim)
|
||||
.filter(|l| !l.starts_with("//") && !l.starts_with("#["))
|
||||
.filter_map(|l| l.split_once(':'))
|
||||
.map(|(k, _)| k.trim_start_matches("pub ").to_string())
|
||||
.collect();
|
||||
assert!(!found.is_empty(), "struct {name} has fields");
|
||||
found
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn the_toml_shows_every_setting_the_config_reads() {
|
||||
let tmp = tempfile::tempdir().unwrap();
|
||||
let (_, text) = scaffolded_toml(tmp.path());
|
||||
// (section, key) for every assignment, examples included.
|
||||
let mut section = String::new();
|
||||
let mut present = Vec::new();
|
||||
for line in uncomment(&text, |_| true).lines() {
|
||||
if line.starts_with('[') {
|
||||
section = line.trim_matches(['[', ']']).to_string();
|
||||
} else if let Some((k, _)) = line.split_once(" = ") {
|
||||
present.push((section.clone(), k.to_string()));
|
||||
}
|
||||
}
|
||||
let has = |s: &str, k: &str| present.iter().any(|(ps, pk)| ps == s && pk == k);
|
||||
// Read from the config crate's serde structs, so a new setting there
|
||||
// fails here until the template shows it.
|
||||
let src = include_str!("../../ledger-config/src/lib.rs");
|
||||
assert_eq!(fields(src, "BooksToml"), ["company", "books"]);
|
||||
for (strukt, sect) in [
|
||||
("CompanyToml", "company"),
|
||||
("MemberToml", "company.members"),
|
||||
("BooksSection", "books"),
|
||||
] {
|
||||
for key in fields(src, strukt) {
|
||||
if strukt == "CompanyToml" && key == "members" {
|
||||
assert!(text.contains("# [[company.members]]"));
|
||||
continue;
|
||||
}
|
||||
assert!(has(sect, &key), "[{sect}] {key} is in the template");
|
||||
}
|
||||
}
|
||||
// Read elsewhere: the justfile's session-start (main.rs), and the two
|
||||
// the scaffold has always written live.
|
||||
for (sect, key) in [
|
||||
("viewer", "open_at_start"),
|
||||
("company", "base_currency"),
|
||||
("books", "data_dir"),
|
||||
] {
|
||||
assert!(has(sect, key), "[{sect}] {key} is in the template");
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user