config, mcp, gui: specs from sources, spec-blind suites, and the bugs they found
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
ledger-config: parse gets a sourced spec. A fiscal year starts on the first of a month (IRS Pub. 538); tax_classification is read by whole words (Treas. Reg. 301.7701-3, Schedule C instructions; "business corp" no longer reads as an S corp, "corporation or S corporation" is refused); duplicate or blank members and shared capital accounts are refused; a negative or non-grammatical receipt threshold is refused; codes trimmed. tests/spec_config.rs (65 spec-blind tests, 14 properties), fuzz target fuzz_config_parse (weekly). Mutation: 55 of 55 viable caught (from 25/38). The receipt policy moves to ledger-config, with one loader (effective_receipt_policy) and one decimal grammar, so the server and the viewer enforce and show the same rule (the viewer had its own: only expense-like debits, a silent $25 default, and no config.json). ledger-mcp: a module spec (MCP 2025-06-18 tools, JSON-RPC 2.0, the operating contract). Amounts in are exactly -?digits[.digits]; a number that is one account's code and another's id (vendors, classes alike) is refused, not guessed; the threshold is validated at startup. Fixed: add_line with a bad class journaled the line before refusing; profit_and_loss_by_class ignored `class`; aging buckets said "0". A wire in front of rmcp answers malformed JSON with -32700 and invalid requests with -32600 and their id (rmcp dropped the first, omitted the id). tests/spec_mcp.rs (26 spec-blind tests: every tool's result against its own outputSchema, a random-call state machine checking the journal is untouched by every refusal, amount grammar, previews, the receipt policy). ledger-gui: money, accounting, and dollars never round (they rounded to cents, banker's style); export file names avoid Windows device names, trailing dots and spaces, empty names, and 255-byte overflow; specs on attention, history, fuzzy search, and axis ticks. ledger-core: the lifetime profit_and_loss is renamed unclosed_earnings (docs/testing.md #3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX
This commit is contained in:
1 parent
5b8910a1cd
commit
3f20df9700
42 files changed
+4636
-363
No files matched your search
@@ -11,7 +11,7 @@
|
||||
use std::collections::{BTreeMap, BTreeSet};
|
||||
|
||||
use chrono::{Days, NaiveDate};
|
||||
use ledger_core::reports::{profit_and_loss, profit_and_loss_by_class, snapshot, trial_balance};
|
||||
use ledger_core::reports::{profit_and_loss_by_class, snapshot, trial_balance, unclosed_earnings};
|
||||
use ledger_core::{
|
||||
AccountId, AccountType, BalanceSheetStatement, CashFlowParams, CashFlowStatement, ClassId,
|
||||
CloseTo, Currency, EntryId, GeneralLedger, Ledger, MemberCapital, MemberClose,
|
||||
@@ -651,7 +651,7 @@ fn pnl_by_class_rows_sorted_by_name_unclassified_last() {
|
||||
(None, c(0), c(3000)),
|
||||
]
|
||||
);
|
||||
let whole = profit_and_loss(&co.l).unwrap();
|
||||
let whole = unclosed_earnings(&co.l).unwrap();
|
||||
assert_eq!(whole.revenue, c(15000));
|
||||
assert_eq!(whole.expenses, c(5000));
|
||||
}
|
||||
@@ -2134,7 +2134,7 @@ proptest! {
|
||||
fn prop_pnl_by_class_rows_sum_to_whole(gens in arb_books()) {
|
||||
let b = build_ordered(&gens, 1, &(0..N).collect::<Vec<_>>(), true);
|
||||
let rows = profit_and_loss_by_class(&b.l).unwrap();
|
||||
let whole = profit_and_loss(&b.l).unwrap();
|
||||
let whole = unclosed_earnings(&b.l).unwrap();
|
||||
prop_assert_eq!(rows.iter().map(|r| r.profit_and_loss.revenue).sum::<Decimal>(), whole.revenue);
|
||||
prop_assert_eq!(rows.iter().map(|r| r.profit_and_loss.expenses).sum::<Decimal>(), whole.expenses);
|
||||
let (wr, we) = model_pnl(&model(&gens, early(), d(2030, 1, 1), None));
|
||||
@@ -2171,7 +2171,7 @@ proptest! {
|
||||
let mut b = build_ordered(&gens, 1, &(0..N).collect::<Vec<_>>(), true);
|
||||
close_through(&mut b, Some(month), &re_close());
|
||||
let rows = profit_and_loss_by_class(&b.l).unwrap();
|
||||
let whole = profit_and_loss(&b.l).unwrap();
|
||||
let whole = unclosed_earnings(&b.l).unwrap();
|
||||
prop_assert_eq!(rows.iter().map(|r| r.profit_and_loss.revenue).sum::<Decimal>(), whole.revenue);
|
||||
prop_assert_eq!(rows.iter().map(|r| r.profit_and_loss.expenses).sum::<Decimal>(), whole.expenses);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user