refactor!: one way to serve books: the stdio server is gone (D-44)
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
The owner (2026-10-23): "We should probably just delete the stdio path altogether. THere's no point in that. And it sitting there unused will just lead to bitrot. Nuke it?" Books are served only by the books server (`wanderbooks server`), reached by agents through the bridge (`wanderbooks mcp --book ID`), which stays. Removed: `wanderbooks dev-stdio`, the `ledger-mcp` binary, and `ledger_mcp::run` (stdio and `--http` over a bare data dir), with all that only that mode had: - files the books make coming back inline: `HandedFile.content_base64` is gone, and `download` and `expires_at` are always there; - books with no access log or backups: `books.access_log`, `books.backup` and `books.back_up_now` are always offered, by scope; - the settings file read and reloaded (`legacy_files`), the vault key named by a file or `--vault-key-file`, and the books dir's key-inside-the-books and git checks (with `paths.rs`); - `wire.rs` (the bridge frames an agent's lines itself); - `books.settings`' file fields and `books.start`'s `settings_source`. `BooksServer` is built one way, from `Served` (a book as the books server serves it), in production and in the unit tests. An unknown tool is now a protocol error (mcp-tools.md). Inline file input is unchanged. Then the owner's three decisions (2026-10-23, the question tool): (a) `books.import_settings` is removed entirely (118 tools): old books come in whole by `wanderbooks books adopt`, which reads their settings file once; ledger-config keeps its settings-file parsing only as far as adoption uses it (`load` and the path-reading `effective_receipt_policy` are gone), and `books.chart_template` gives its settings as `books.set_setting` changes. (b) The viewer's loose-books-folder mode is removed (`--data-dir`, `--books-toml`, `--vault-key-file`, the settings file and config.json followed): it opens only books of the data root, reading settings from the journal and the vault from the book's own `vault/` and `keys/`. (c) `wanderbooks dev-stdio` has no stub: it is an unknown command like any other word. Also: an upload's expiry past the calendar is an error, never an empty string. Tests: every suite that drove the stdio server moved to crates/ledger-cli/tests/ and drives a real `wanderbooks server` on a data root of its own (tests/common), handed files by their download; mcp_stdio.rs is mcp_journeys.rs. Tests of what is gone are deleted and listed in docs/testing.md. Docs: plan D-44 (D-18 superseded), STATUS, testing, rules, mcp-interface, the handbook, README; justfile recipes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3gXMVt7XJPi6ens1or9Dj
This commit is contained in:
87 files changed
+3477
-6476
No files matched your search
+26
-2
@@ -35,8 +35,8 @@ settings: 1,396 characters.
|
||||
conventions (posting templates, approval rules, policies, close steps,
|
||||
calendar, mappings, notes), decisions, open items and approvals are
|
||||
journal events (format 2); books that keep their settings never read
|
||||
`wanderbooks.toml` or `config.json`, and `books.import_settings` moves a
|
||||
file in exactly once. Two review rounds (all findings fixed), `just
|
||||
`wanderbooks.toml` or `config.json`, and adoption moves a file in
|
||||
exactly once (`books.import_settings` did too, until D-44). Two review rounds (all findings fixed), `just
|
||||
check`, `just prove` (Kani 20/20, Lean 31 theorems, standard axioms
|
||||
only), and mutation on the whole diff (956 mutants; every survivor
|
||||
killed by a test but two equivalent: `docs/testing.md`). **Live on the
|
||||
@@ -182,6 +182,27 @@ shows a line's project; the viewer's invoice and bill pages list the
|
||||
document's lines, each project a link; the demo's "Client work" carries
|
||||
its invoices. The handbook's caveat is gone for books with the feature.
|
||||
|
||||
**One way to serve books (2026-10-23, D-44).** The owner: "We should
|
||||
probably just delete the stdio path altogether. THere's no point in that.
|
||||
And it sitting there unused will just lead to bitrot. Nuke it?" Gone:
|
||||
`wanderbooks dev-stdio`, the `ledger-mcp` binary and `ledger_mcp::run`
|
||||
(stdio and `--http` over a bare data dir), with what only it had: files
|
||||
the books make coming back inline (every handed file is a download now),
|
||||
books with no access log or backups, the settings file read and reloaded
|
||||
(`legacy_files`), the vault key named by a file or `--vault-key-file`.
|
||||
`BooksServer` is built one way, from a book as the books server serves it
|
||||
(`Served`); an unknown tool is a protocol error. Every suite that drove
|
||||
the stdio server moved to `crates/ledger-cli/tests/` and drives a real
|
||||
`wanderbooks server` on a data root of its own (`tests/common`), files by
|
||||
their download. Inline file input is unchanged. The owner then decided
|
||||
(2026-10-23, the question tool): `books.import_settings` goes (118
|
||||
tools; old books come in whole by `books adopt`; `books.chart_template`
|
||||
gives its settings as `books.set_setting` changes); the viewer's
|
||||
loose-books-folder mode goes (`--data-dir`, `--books-toml`,
|
||||
`--vault-key-file`, the settings file followed): it opens only books of
|
||||
the data root; and `wanderbooks dev-stdio` goes with no stub, an unknown
|
||||
command like any other.
|
||||
|
||||
**Still open after P3 (each for the phase named, or the lead):**
|
||||
- Invoices and bills take a project now (above), behind the new journal
|
||||
feature `document_line_projects`: the first company's books declared
|
||||
@@ -386,6 +407,9 @@ interface is MCP, not a cloned GUI. The first storage + MCP slice is done
|
||||
|
||||
## Decisions log
|
||||
|
||||
- 2026-10-23: D-44, one way to serve books: the stdio server, its inline
|
||||
file outputs and its settings-file mode are gone; tests drive a real
|
||||
books server (plan/served.md D-44).
|
||||
- 2026-10-13: Formal methods are part of the bar (the owner: "This shit is
|
||||
fucking GOLD"). Money arithmetic lives in `kernel.rs` with Kani
|
||||
harnesses; accounting laws get Lean theorems; `just prove` stays green.
|
||||
|
||||
Reference in new issue
Block a user