From 76285434cb46ba8c69b12b7de3cacb25ae164084 Mon Sep 17 00:00:00 2001 From: Stephen Waits Date: Thu, 29 Oct 2026 01:56:32 -0600 Subject: [PATCH] fix(fuzz): fuzz_settings_replay builds again; a B-27 check for an unknown convention kind The weekly run's fuzz_settings_replay job failed to build since P3 gave each projection schema its own file: the target still named ledger_store::DB_FILE, which became db_file(). The fuzz crate is outside the workspace, so just check never compiled it; every target builds again (cargo fuzz build, 2026-10-29). The same run's fuzz_store_replay crash (the writer refusing a journal with an unknown convention kind as newer while the viewer said something else) is not reproduced yet: the hand-made case, kept here as an_unknown_convention_kind_is_newer_for_the_writer_and_the_viewer_alike, passes, so the divergence needs the fuzzer's exact journal, which the weekly job now keeps as an artifact. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01HS8WZziDnyxunC23MUxrLp --- crates/ledger-store/tests/format.rs | 36 +++++++++++++++++++++++ fuzz/fuzz_targets/fuzz_settings_replay.rs | 2 +- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/crates/ledger-store/tests/format.rs b/crates/ledger-store/tests/format.rs index 608142b..66edee7 100644 --- a/crates/ledger-store/tests/format.rs +++ b/crates/ledger-store/tests/format.rs @@ -1549,3 +1549,39 @@ fn an_older_version_stops_at_invoice_sent() { drop(store); Store::open(&dir).unwrap().verify().unwrap(); } + +/// The weekly fuzz run of 2026-10-26 (`fuzz_store_replay`, crash +/// 0dfab1cc): a journal whose `convention.set` names a kind this version +/// doesn't know. The writer says NewerJournal (B-27: newer content is +/// newer, never corrupt); the viewer must say the same, since the two +/// share one reading of the journal (rules.md B-27, docs/architecture.md +/// "The journal format gate"). +#[test] +fn an_unknown_convention_kind_is_newer_for_the_writer_and_the_viewer_alike() { + let dir = tempfile::tempdir().unwrap(); + let dir = dir.path(); + { + let mut w = + ledger_store::JournalWriter::open(&dir.join(ledger_store::JOURNAL_FILE)).unwrap(); + w.append("store.created", serde_json::json!({"base_currency": "USD"})) + .unwrap(); + w.append( + "convention.set", + serde_json::json!({"id": "c-1", "kind": "1000", "title": "t", "body_md": "b", + "source": {"decided_by": "x", "decided_on": "2026-01-01"}}), + ) + .unwrap(); + } + let store = ledger_store::Store::open(dir); + let snap = ledger_store::Snapshot::load(dir); + let newer = |e: &ledger_store::StoreError| matches!(e, ledger_store::StoreError::NewerJournal { .. }); + match (store, snap) { + (Err(a), Err(b)) => assert!( + newer(&a) && newer(&b), + "the writer says {a}; the viewer says {b}" + ), + (Ok(_), Ok(_)) => panic!("both opened a journal with an unknown convention kind"), + (Ok(_), Err(e)) => panic!("the writer opens books the viewer refuses: {e}"), + (Err(e), Ok(_)) => panic!("the viewer loads books the writer refuses: {e}"), + } +} diff --git a/fuzz/fuzz_targets/fuzz_settings_replay.rs b/fuzz/fuzz_targets/fuzz_settings_replay.rs index 30afb43..fa141fd 100644 --- a/fuzz/fuzz_targets/fuzz_settings_replay.rs +++ b/fuzz/fuzz_targets/fuzz_settings_replay.rs @@ -167,7 +167,7 @@ fuzz_target!(|data: &[u8]| { w.append(t, p).unwrap(); } } - let _ = std::fs::remove_file(dir.join(ledger_store::DB_FILE)); + let _ = std::fs::remove_file(dir.join(ledger_store::db_file())); let store = ledger_store::Store::open(&dir); let snap = ledger_store::Snapshot::load(&dir); match (store, snap) {