docs: P0 review: server instructions, handbook, local files, fail closed
docs/mcp-interface.md: the connect text and its budgets, the handbook (tool and resources), annotations, failing closed, import_local_file's roots and refusals, the set_w9 path rule and where TIN-bearing files may go. docs/testing.md: the P0 laws and the tests that check them. docs/architecture.md: the journal format gate and the server's fail-closed store lock. Round-2 review (2026-10-16): mcp-interface.md lists all 26 destructive tools (unlink_receipt, unlink_attachment and correct_asset were missing) and openWorldHint false on every tool; the connect text states the parties rule and the exact receipt rule, and how it fits its budget; the lint covers every refusal; the import roots refuse /, the home folder and folders holding the books or a key, the open is a component walk, every missing or outside path gets one refusal, and the TIN-file registry and text scan (and what they can't catch) are described. architecture.md: the frozen envelope, the lenient next-line prev, no repair of newer books. testing.md: the new laws and tests. verification.md and parity.md: P0 notes (no new law to prove, no status moved). The TIN text check, narrowed (2026-10-16; rules.md B-26, mcp-interface.md): text is refused for a TIN the vault holds, in its common renderings, or a stand-alone printed SSN or EIN shape, so bank exports go in; the oracle a vault comparison gives is recorded as a known limit for P7. testing.md: the P0 mutation run of the final diff, per crate, and how each survivor was resolved (killed by a named test, removed by simpler code, or argued equivalent). The probe bound (rules.md B-26, mcp-interface.md): rule (a) answers for at most two candidates a filing, so finding a TIN from its last four takes on the order of 50,000 refused filings; the open limit now names that path, closed by P2's access log and P7's human-only TIN channel. testing.md: the law and its tests; tin_files.rs mutated again, 74 of 74 caught. Review round 3: rules.md B-28 (four-digit years, amounts a line can carry, checked products, bounded recurring runs) and B-26/B-27 updates (BOM-less UTF-16, when set_w9 records); mcp-interface.md matches the code (25 destructive tools, the five idempotent ones, no reverse_entry receipt checklist, strictly above the threshold, no tool text names wanderbooks.toml, dot names and roots inside the books refused, the new settings lists); testing.md lists the new laws and this round's mutation run. Review round 4: rules.md B-28 says the bounds are for new commands only, replay accepts every line an earlier version accepted, and derived figures refuse rather than panic; mcp-interface.md documents plan_error and the nullable totals; testing.md lists the old-books contracts and this round's mutation run (core, store, MCP, config, GUI). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3gXMVt7XJPi6ens1or9Dj
This commit is contained in:
6 files changed
+658
-37
No files matched your search
@@ -80,3 +80,39 @@ to the data directory. A loader thread watches the directory and applies
|
||||
appended journal lines; the UI renders an immutable view model rebuilt per
|
||||
change. Statements and series come from `ledger-core` (`reports`,
|
||||
`analysis`); the GUI only arranges them. See `plan/gui.md`.
|
||||
|
||||
## The journal format gate (`ledger-store`, P0)
|
||||
|
||||
Every journal line passes a gate after its parse, seq and chain checks
|
||||
(`ledger_store::format`): a type this version knows, or a
|
||||
`journal.format_set` this version reads. A line it can't read stops the
|
||||
read whole (the writer never opens, the viewer applies none of the new
|
||||
lines): never skipped, never half-read. A line with a key beside the
|
||||
envelope's (`seq`, `ts`, `type`, `payload`, `prev`, frozen across formats)
|
||||
is refused the same way, never read with the key dropped. The refusal is
|
||||
`NewerJournal`, not `JournalCorrupt`: verified ("line N is intact; this
|
||||
version can't check the lines after it") when the next line's `prev`,
|
||||
read leniently whatever format frames that line, matches the refused
|
||||
line's hash (the SHA-256 of its canonical JSON, every key included);
|
||||
corruption when a `prev` it can read doesn't match; "newer or damaged"
|
||||
when there is no next line or no `prev` it can read. The writer
|
||||
(`Store::open`) and the viewer (`Snapshot`) read the journal the same way
|
||||
(bytes split on newlines) and share the same gate and settling
|
||||
(`format::gate`, `format::settle`), so they always give the same answer
|
||||
for the same journal (fuzzed by `fuzz_store_replay`). The writer checks
|
||||
every complete line before it changes anything: a torn tail is set aside
|
||||
only when the gate passes, so an older version never alters newer books.
|
||||
Rule: `docs/spec/rules.md` B-27.
|
||||
|
||||
## The MCP server's store lock (`ledger-mcp`, P0)
|
||||
|
||||
One `Store` is shared by every session (`SharedStore`: a
|
||||
`tokio::sync::Mutex` and a `stopped` flag). Tool bodies run on tokio's
|
||||
blocking threads (`run_blocking`), never on the async workers, and take the
|
||||
lock with `blocking_lock`; the guard is `!Send`, so no tool can hold it
|
||||
across an `.await`. The store journals a command before it changes memory,
|
||||
so a panic between the two would leave memory behind the journal; and a
|
||||
tokio mutex never poisons. So the server fails closed: a panic in a
|
||||
request (its task, or while it holds the guard) sets `stopped`, and every
|
||||
later request, on every session, is refused until a restart, which
|
||||
re-verifies the journal.
|
||||
Reference in new issue
Block a user