4 Commits

Include renames

Author	SHA1	Message	Date
swaitsandClaude Opus 5.5	b22a034746	MCP: short connect text, a handbook, tool annotations, safe local imports ... - The 13K-character instructions (clients cut them short) become a connect text of at most 1,400 characters whose first 512 stand alone, plus books.handbook and books://handbook/{section}: the old guidance by section, with no helper commands, home paths, pull requests or file-reading suggestions (tool_text_lint). - Every tool has a title and read-only/destructive hints; no requiresUserInteraction anywhere (owner decision 2026-10-16). - books.import_local_file reads only regular files inside the import roots (the downloads folder by default, or --import-root), never the data dir, books dir, vault or the key's folder, no symlink escapes or hard links, and the file opened must be the file checked. - The store lock is a tokio mutex taken off the runtime threads. - get_info refreshes settings first; a bare books://digest reads. Review fixes (P0 review, 2026-10-16): - Fail closed: a tokio mutex never poisons and spawn_blocking caught the panic, so after a panic mid-mutation the server kept serving a Store behind its journal. A panic (the task, or while holding the store) now stops the shared store; every later request on every session is refused with a plain message; a restart re-verifies the journal. The join error goes through redact_refusal and never carries the panic's text. - books.set_w9 w9_file_path read any path (a link named w9.pdf to the vault key was stored and get_w9 wrote it out): it now goes through the import roots' lockdown, its type judged on the canonical path. - Sealed even inside a root: the key file in force, where a linked one leads, both folders, and the default key folder whatever the settings say. Refusals check the roots first, so outside them every path gets one message (no probing what exists); inside, other books-dir files say to copy them out first. - The open is O_NOFOLLOW | O_NONBLOCK (a pipe swapped in after the check can't hang a thread) and must match the checked file's device and inode. New dependency: libc (unix only), for those two open flags, which std doesn't name. - Default import roots are the downloads folder only (the plan); files with full TINs (get_w9, vendor_1099 include_tins, the CPA package with TINs) are never written into an import root, and the server refuses to import any file it wrote with TINs (by SHA-256). - set_tin and set_w9 overwrite vault records: destructive_hint = true; annotations_complete pins the key tools' hints. The read-only hint is checked in behaviour on every spec_mcp call (journal and data-dir files unchanged). - Text: the connect text names the settings file as the one local file to edit, says every entry balances on real accounts and names its party, says invoice/bill/payment/payroll tools post unchecked, rewords the exemptions, and shows the company name as one plain line; the handbook takes section "all", lists its ids in the schema and says to read contract first; books.settings drops the config.json path and no error names the data dir or the key file. tool_text_lint covers the whole tool JSON and resources and bans git/commit/WL-0001; tool descriptions over 700 characters are pinned to today's eight (P5). - digest: an empty since= is bare; the default date is pinned on every day of a month. Round-2 review fixes (2026-10-16): - TIN files (B-26): the in-memory, per-session set of TIN-file hashes became one registry beside the vault (vault/tin-files.sha256, hashes only), shared by every session and every later server. It holds the W-9 set_w9 reads (recorded as read), get_w9 copies, 1099 worksheets with TINs, CPA packages with TINs and each file in one that holds a TIN; a file is recorded before it is written, and a failure refuses. import_local_file, attach_receipt and file_document (base64 was never checked) refuse a recorded file, and a text file (by type, name, or UTF-8/UTF-16 decoding) holding a full TIN. Not caught: an altered binary copy; the docs say so (P2/P7 remove the path tools). - The text check is narrow (owner/engineer decision, 2026-10-16: bank exports are filed for reconciliation, and has_full_tin's "nine digits however separated" refused their routing numbers, long references and dates run into amounts). Text is refused when it holds (a) a TIN the vault holds for a party, anywhere, as nine digits, 3-2-4 joined by hyphens, spaces or dots, or 2-7 joined by a hyphen or space, compared on the server against the decrypted vault and never returned or logged (a vault that can't be opened leaves (b)); or (b) a stand-alone printed SSN (123-45-6789) or EIN (12-3456789) shape: no digit, and no hyphen or dot followed by a digit, beside it. Full-width digits and Unicode hyphens and spaces read as ASCII. has_full_tin still guards refusals and results (redact_refusal). Known limit, for P7: a refusal under (a) tells the agent a text it chose holds a vault TIN. New dependency: zeroize in ledger-mcp (already in the workspace through ledger-vault, same major version), so the vault's TINs decoded for the scan are wiped from memory on drop as the vault's own are. - Mutation testing of the final P0 diff (docs/testing.md): tests for each law a survivor broke (handbook titles, a dropped default root, a .jpg W-9, the waker, the walk's folder flags against a link and a pipe, the 40-link limit, save paths refused as such, the package marking only its TIN files, a registry that can't be read, text types, the short receipt rule's counts and a 12-character code). Simpler code where only a race could tell: inspect places an existing path by canonicalize itself (no second comparison), read_checked's read limit is its one size check, openat fails on -1 as specified. The 25 MiB upload test removes its 50 MB of books however it ends. - The GUI's stale-rule prompt no longer says to open a pull request: it asks the agent to find the figure from the rule's official authority, confirm it with the human, pass it explicitly, and tell the human so it can be reported upstream (as the handbook says); a lib test pins it and bans files, git, GitHub and pull requests from every attention prompt. - Import roots (local_files.rs INVARIANT 0): XDG_DOWNLOAD_DIR="$HOME/" made $HOME (or /) the root. No root may be /, the home folder or hold it, or hold the books, data dir, vault or a key: a named one stops the server at startup, a default one is dropped; the default falls back to ~/Downloads only if that is a real folder other than $HOME; with no root, an import says so. - The read is a component walk from / with openat(O_NOFOLLOW | O_DIRECTORY) per folder and O_NOFOLLOW | O_NONBLOCK for the file, so a folder swapped for a link after the check fails; no step may land on a protected inode (one renamed into a root); dev/ino and nlink stay. No /proc. Portable to macOS. (libc's openat, two small unsafe blocks.) - One refusal for missing, dangling and outside paths: resolved() follows every link, dangling ones too, so a link's target existing or not no longer changes the answer. - Sealing: the key files (in force, default) and their targets always; their folders only when not $HOME, not a root, not holding a root; and ~/.config/wanderbooks whatever XDG_CONFIG_HOME says. - Agent text (I-12): RuleNotKnown names the authority (IRS, with its address) and says to tell the human, never a repo path, PR or GitHub; the digest's stale_rules drop the repo catalog and path for it; vault, outside-books, STOPPED and local-file refusals name no git, path or flag. tool_text_lint bans docs/, .md, /home, data dir, --data-dir, --import-root, vault.key, .jsonl, sqlite, .gitignore, github, pull request, and also lints every error template (scanned from source), built error texts, and the server's refusal constants. - The receipt rule told (ReceiptPolicy::rule) is the one enforced: the exact threshold in the base currency (no "$", no rounding), required and exempt accounts, reversals exempt; the connect text fits 1,400 characters by dropping reasons, then codes, never the rule. - The connect text follows the parties setting; "offer books.digest" everywhere. shown_name drops Unicode format characters (bidi, zero width). - read_only_tools_change_nothing compares file contents, the database by every row, the vault and the settings file (raw database bytes did not change either; rows are the stable comparison). - import_local_file takes the name and type from the canonical path; the digest's journal repair says when the tail was set aside, not the journal's file name; "version-history messages" back in the TIN rule; openWorldHint false on every tool, pinned in annotations_complete. - Outside the MCP crate, for the same texts: ledger-core's DatedRule gains `authority` (the statute or publication with its address) and RuleNotKnown carries it; ledger-store's "sqlite error" reads "database error"; ledger-config's ReceiptPolicy::rule takes the base currency. New dev-dependency: rusqlite in ledger-mcp (already in the workspace, same version and features as ledger-store), to read the database's rows in read_only_tools_change_nothing. - The filing scan is no TIN oracle (tin_files.rs INVARIANT 4): text holding more than two TIN-shaped numbers (any rendering rule (a) reads) that end in a known TIN's last four (the books' TIN and W-9 facts, via known_tin_last4, before the vault is opened; then the vault's own) is refused with TIN_PROBE, the same words whether or not one is the vault's TIN; only one or two candidates are compared against the vault. Tests: unit text_probing_for_a_tin_is_refused_alike_whether_or_not_it_holds_it, one_or_two_candidates_are_compared_against_the_vault; over HTTP text_probing_for_a_tin_is_refused_alike_by_every_filing_tool. Plan: plan/served.md P0, section 6 "Immediate hole (P0)", 4.1, 4.3, 4.9. Review round 3. S1: a panic stops the server for every session, so no input may reach one. Dates are four-digit years (new ledger_core:: calendar, 0001-01-01..9999-12-31): the MCP's parse_date is strict YYYY-MM-DD, periods are bounded, last_day_of_month returns a refusal (server and store); schedules, assets, recurring entries, periods, documents, disposals and entries refuse dates outside the calendar, and replay refuses such journal dates. Every amount a command takes is at most a line's (draft lines by size, document lines, payouts, payroll, statements, shares, tax basis, proceeds, recurring templates), on replay too, so sums are exact; the 1099 vendor part and the K-1 property share use checked products (TooLargeToCompute); a recurring run makes at most 1,000 drafts. tests/hostile_args.rs drives every tool with schema-derived hostile arguments and every resource with generated URIs, asserting the server never stops; the audit's panics are pinned. S2: a `.` or `..` path name is refused as NO_SUCH_FILE up front. S3: NUL-interleaved UTF-16 without a byte-order mark is scanned both ways. S4: resource-read refusals are TIN-redacted. S5: set_w9 records its W-9 only once the call passes every check, just before the vault write. S8: idempotentHint only on verify, run_depreciation, run_schedules, run_recurring, set_party_roles (a repeat leaves journal and vault alone; spec_vault checks every candidate twice); every tool's hints pinned in one table. C1: books.settings lists receipt_required_accounts and receipt_exempt_accounts uncut. C2: the default company name reads "a new company". C3: the parties rule names no-party reasons. C4/C5: the handbook names the settings file only as books.settings' books_toml, and restores "check books.digest and offer it". C6: an import root inside the books, data dir or vault is refused at startup. The lint catches `just` however it ends and where the books are; digest_resource_bare_reads reads the server's month. Review round 4 (2026-10-17): round 3's bounds ran in replay too, so journals main wrote and reopened (an entry dated 0000-06-01 or +10000-01-01, a draft line of 2e15, an asset ending past 9999, a basis or share past the line limit, sub-cent document and payroll lines) no longer opened. Posted is forever: the bounds are the commands' only. - Replay applies main's rule exactly: parse_date takes any date chrono reads; replay_add_line(_fx) has no size bound (add_line/add_line_fx do); replay_register_asset/correct_asset (chrono overflow only), replay_set_asset_tax_basis (check_journaled), replay_set_entry_parties (check_shares_journaled), replay_register_recurring (validate_recurring_journaled), replay_register_schedule (months 1 to 600), replay_create_period (order only), replay_dispose_asset, and no line, date, payment or payroll range checks in replay_invoice/bill, their payments and replay_payroll_run. - Derived figures over such books refuse (TooLargeToCompute, DateOutOfRange), never panic: amortization plans, depreciation into chrono's last month (and the true-up for lives past 9999), intervals, document totals and aging, net pay and payroll plans, money flows and share resolution, the asset register, receipt-policy debits; the MCP tools and the viewer show what can't be computed. - tests/fixtures/old-books: the review's 13 journals, its control and 15 more edges, written by main's Store API with main's figures (expected.json); every one opens in the writer and the viewer to those figures, every derived figure computes or refuses, every MCP tool and GUI page answers; hostile_args restarts the server after each property; each bound has a command/replay test pair. Final review: a schedule's plan refuses a total of 10^26 or more (TooLargeToCompute) instead of letting Decimal round its cents silently, and a null `remaining` in the schedule output is always explained by plan_error. Replay is unaffected: no journaled schedule month can belong to a total that large (the line limit bounds every posted month). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3gXMVt7XJPi6ens1or9Dj	2026-10-17 09:25:00 -06:00
swaitsandClaude Opus 5.5	aec55b8d12	Store: say "newer wanderbooks", not "corrupt", for books from a newer version ... An unknown event type on a whole, chained line, or a journal.format_set declaring a newer journal format, now raises StoreError::NewerJournal (update wanderbooks) instead of JournalCorrupt. Corruption (bad hash, seq, or JSON) is still corruption. The gate runs in the store, the Snapshot and the GUI, after each line's parse, seq and hash checks, and never skips a line it can't read. Adds the journal.format_set event (format 1 today; nothing writes it yet) and a registry of every event type this version reads, tested against the replay and projection arms. Review fixes (P0 review, 2026-10-16): - A line's own hash is checked only by the next line's prev, and the gate used to refuse a line before reading the next: a flipped bit in a middle line's type (or a format_set edited from 1 to 2) was reported as "newer, the books are not damaged". Now the reader settles every refusal against the next line (format::settle): a next line that doesn't chain makes it corrupt; one that chains makes it newer and verified; with no next line the message says "newer or damaged; update, then run verify", never "not damaged" (NewerJournal.verified). - A newer format number is judged newer before its features are parsed: a newer format may shape them differently. - Snapshot treats a blank complete line as corrupt, as the writer does. - docs/spec/rules.md B-27, which the code cites, now exists. Round-2 review fixes (2026-10-16): - The envelope {seq, ts, type, payload, prev} and its hash (SHA-256 of the canonical JSON) are frozen across formats (rules.md B-27); new fields go in payload. settle reads only the next line's prev, leniently, so a newer format's next line (a float, a string seq, keys of its own) is never called corrupt: no readable prev means unverified newer. - A key beside the envelope's was silently dropped (and the chain then broke as "corrupt"): it is now NewerJournal, hashed over the raw canonical JSON so the next line still checks it; JournalLine::parse refuses such a line. - "the books are not damaged" overclaimed: a verified refusal says line N is intact and this version can't check the lines after it. - The writer read the journal with BufRead::lines (invalid UTF-8 was an I/O error); it now splits bytes on newlines as the Snapshot does, so a non-UTF-8 line is JournalCorrupt in both. - Store::open truncated a torn tail before the gate ran, altering newer books (perhaps mid-append) before refusing them. The gate now runs over the complete lines first; the tail is set aside (and journaled) only when they pass. - Mutation testing (docs/testing.md, P0): the viewer and the writer say the same words about the same damaged line (the newline is no part of it); read_journal_and_format returns every line and the format in force; the journal page tells a format declaration. Plan: plan/served.md P0 and 5.1. Review round 3 (S6, S7). Store::open replays every complete line in memory (the first line's currency, then the ledger) before a cut-off last line is set aside, so a complete line the books can't apply refuses the open with the journal byte for byte as it was and nothing set aside (B-27 SCENARIO 3; test a_bad_complete_line_before_a_torn_tail_leaves_the_journal_as_it_was); catch_up now only projects. The viewer applies the writer's first-line rule (created_currency, shared) instead of guessing USD: any other first line, or a store.created without a sound base_currency, is corrupt to both (test the_first_line_is_store_created_for_the_viewer_and_the_writer). fuzz_store_replay varies the first line (14,696 runs clean). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3gXMVt7XJPi6ens1or9Dj	2026-10-17 00:32:42 -06:00
swaitsandClaude Opus 5.5	efa370dfa3	mcp: tests for the settings beside the books, year earnings (open periods, last year's partial close), year 1, a failed flush; drop by-class P&L's dead placeholder guard; record config, MCP, GUI mutation scores ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX	2026-10-14 20:45:49 -06:00
swaitsandClaude Opus 5.5	2fa84a37ff	mcp: balance sheet's year earnings no longer charge this year with closing last year's; tests for what mutation found untested ... year_earnings counted every closing entry dated this year against this year's income, but a close takes all unclosed income through its end, earlier years included. A partnership closing January after an unclosed December printed "Net income (loss)" -969 for a year earning +730, and the closed December as "Undistributed earnings, prior years". The unclosed part is now the income after the last close, from no earlier than the fiscal year's start (closes are cumulative). Unit tests: the 25 MiB upload limit, YYYY-MM periods, config_mentions for every setting naming a code, report members, year earnings before and after a close, and which entries may lose their last receipt. tests/startup.rs: --help, the default data dir under HOME, settings read from beside the books, and a held lock refused after the wait instead of waited on forever. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX	2026-10-14 15:58:48 -06:00