check / check (push) Canceled after 0s
CI's run of the store refusal property found a payroll run that posted $65.27794: the employer tax was passed in unrounded and nothing refused it, though rules.md B-3 already says a ledger in one money holds no fractions of its smallest unit. Sums of it then differed in scale between journal replay and the SQLite read-back. - Ledger::post_entry refuses any line finer than its currency's ISO 4217 minor unit (FinerThanMinorUnit), whatever made the line: payroll, closes, disposals. add_line refuses it up front. Older journals replay as booked through replay_post_entry. Spec tests for the kernel's ten-place limit now run on the replay path. - The property's body is now run_ops, so failing sequences become named regression tests (regression_payroll_with_a_fraction_of_a_cent). The generator rounds payroll tax to the cent, as callers must. - Ledger derives PartialEq and gains differs_from; Store::verify compares the live ledger with the journal replay in full (drafts, documents, schedules, periods, settings), not just balances, and names the parts that differ. The property checks the ledger its commands built against that replay and against the reopened books. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX
189 lines
6.8 KiB
Rust
189 lines
6.8 KiB
Rust
//! Journal entries: the atomic unit of double-entry bookkeeping.
|
|
//!
|
|
//! An entry is a set of lines that must balance exactly: total debits equal
|
|
//! total credits. Entries are born as drafts, validated, then posted. Posting
|
|
//! is one-way; a posted entry can only be corrected by a reversing entry.
|
|
|
|
use crate::kernel::{self, LineError};
|
|
use crate::{AccountId, ChartOfAccounts, ClassId, Currency, LedgerError, Money, Side};
|
|
use chrono::NaiveDate;
|
|
use rust_decimal::Decimal;
|
|
use serde::{Deserialize, Serialize};
|
|
use std::collections::HashMap;
|
|
|
|
/// Opaque journal entry handle. Created by [`crate::Ledger`]; never forged.
|
|
pub type EntryId = u64;
|
|
|
|
/// Lifecycle of a journal entry. `Draft -> Posted` is one-way.
|
|
#[derive(Clone, Copy, PartialEq, Eq, Debug, Serialize, Deserialize)]
|
|
pub enum EntryStatus {
|
|
/// Being built. Lines may be added; nothing has hit the ledger.
|
|
Draft,
|
|
/// Validated and applied. Immutable from here on.
|
|
Posted,
|
|
}
|
|
|
|
/// One debit or credit line of a journal entry.
|
|
#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
|
|
pub struct JournalLine {
|
|
/// The account this line posts to.
|
|
pub account: AccountId,
|
|
/// Which side of the entry this line is on.
|
|
pub side: Side,
|
|
/// The exact amount, in the ledger's base currency. Never zero (rejected
|
|
/// at validation).
|
|
pub amount: Money,
|
|
/// For foreign-currency lines: the original currency. `None` for base-
|
|
/// currency lines. When set, `amount` is the base-currency equivalent
|
|
/// converted at the line's rate.
|
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
pub foreign_currency: Option<Currency>,
|
|
/// For foreign-currency lines: the original foreign amount. `None` for
|
|
/// base-currency lines.
|
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
pub foreign_amount: Option<Decimal>,
|
|
/// Divisional tracking: which class (department, location, job) this
|
|
/// line belongs to. `None` means unclassified. Set on drafts only via
|
|
/// [`crate::Ledger::set_line_class`]; posted lines are immutable, so
|
|
/// their classes are frozen.
|
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
pub class_id: Option<ClassId>,
|
|
}
|
|
|
|
/// A balanced set of journal lines with a date and a description.
|
|
#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
|
|
pub struct JournalEntry {
|
|
id: EntryId,
|
|
date: NaiveDate,
|
|
description: String,
|
|
lines: Vec<JournalLine>,
|
|
status: EntryStatus,
|
|
reversal_of: Option<EntryId>,
|
|
}
|
|
|
|
impl JournalEntry {
|
|
/// Create a draft entry. Only [`crate::Ledger`] does this; the id comes
|
|
/// from the ledger's allocator so ids are unique per ledger.
|
|
pub(crate) fn draft(id: EntryId, date: NaiveDate, description: String) -> Self {
|
|
Self {
|
|
id,
|
|
date,
|
|
description,
|
|
lines: Vec::new(),
|
|
status: EntryStatus::Draft,
|
|
reversal_of: None,
|
|
}
|
|
}
|
|
|
|
/// The entry's id.
|
|
pub fn id(&self) -> EntryId {
|
|
self.id
|
|
}
|
|
|
|
/// The entry's accounting date.
|
|
pub fn date(&self) -> NaiveDate {
|
|
self.date
|
|
}
|
|
|
|
/// Human description / memo.
|
|
pub fn description(&self) -> &str {
|
|
&self.description
|
|
}
|
|
|
|
/// The entry's lines, in the order they were added.
|
|
pub fn lines(&self) -> &[JournalLine] {
|
|
&self.lines
|
|
}
|
|
|
|
/// Draft or posted.
|
|
pub fn status(&self) -> EntryStatus {
|
|
self.status
|
|
}
|
|
|
|
/// If this entry reverses another, the reversed entry's id.
|
|
pub fn reversal_of(&self) -> Option<EntryId> {
|
|
self.reversal_of
|
|
}
|
|
|
|
/// Append a line. Only while drafted; only via [`crate::Ledger`].
|
|
pub(crate) fn push_line(&mut self, line: JournalLine) {
|
|
self.lines.push(line);
|
|
}
|
|
|
|
/// Tag a line with a class (or clear it). Only while drafted; only via
|
|
/// [`crate::Ledger::set_line_class`].
|
|
pub(crate) fn set_line_class(&mut self, index: usize, class_id: Option<ClassId>) {
|
|
self.lines[index].class_id = class_id;
|
|
}
|
|
|
|
/// Mark posted. Only via [`crate::Ledger`], after [`Self::validate`].
|
|
pub(crate) fn mark_posted(&mut self) {
|
|
self.status = EntryStatus::Posted;
|
|
}
|
|
|
|
/// Link this entry as the reversal of another. Only via [`crate::Ledger`].
|
|
pub(crate) fn mark_reversal_of(&mut self, original: EntryId) {
|
|
self.reversal_of = Some(original);
|
|
}
|
|
|
|
/// Validate the entry against the chart of accounts. This is the heart of
|
|
/// R-1: at least two lines, every amount positive and within line range,
|
|
/// no placeholder or unknown accounts, one currency throughout, and
|
|
/// debits exactly equal to credits. The arithmetic is
|
|
/// [`kernel::check_lines`].
|
|
pub fn validate(&self, chart: &ChartOfAccounts) -> Result<(), LedgerError> {
|
|
let mut currency: Option<Currency> = None;
|
|
for line in &self.lines {
|
|
let account = chart
|
|
.get(line.account)
|
|
.ok_or(LedgerError::UnknownAccount(line.account))?;
|
|
if account.placeholder {
|
|
return Err(LedgerError::PlaceholderAccount(account.code.clone()));
|
|
}
|
|
match currency {
|
|
None => currency = Some(line.amount.currency),
|
|
Some(c) if c != line.amount.currency => {
|
|
return Err(LedgerError::CurrencyMismatch {
|
|
expected: c.code().to_string(),
|
|
found: line.amount.currency.code().to_string(),
|
|
});
|
|
}
|
|
Some(_) => {}
|
|
}
|
|
if account.currency != line.amount.currency {
|
|
return Err(LedgerError::CurrencyMismatch {
|
|
expected: account.currency.code().to_string(),
|
|
found: line.amount.currency.code().to_string(),
|
|
});
|
|
}
|
|
}
|
|
let sides: Vec<(Side, Decimal)> = self
|
|
.lines
|
|
.iter()
|
|
.map(|l| (l.side, l.amount.amount))
|
|
.collect();
|
|
kernel::check_lines(&sides).map_err(|e| match e {
|
|
LineError::TooFewLines => LedgerError::TooFewLines,
|
|
LineError::ZeroAmount => LedgerError::ZeroAmountLine,
|
|
LineError::NegativeAmount => LedgerError::NegativeAmountLine,
|
|
LineError::OutOfRange => LedgerError::AmountOutOfRange,
|
|
LineError::Unbalanced { debits, credits } => {
|
|
LedgerError::UnbalancedEntry { debits, credits }
|
|
}
|
|
})
|
|
}
|
|
|
|
/// Net movement per account within this entry: debits minus credits.
|
|
/// Sums to zero across accounts for any valid entry.
|
|
pub fn movements(&self) -> HashMap<AccountId, Decimal> {
|
|
kernel::movements(
|
|
self.lines
|
|
.iter()
|
|
.map(|l| (l.account, l.side, l.amount.amount)),
|
|
)
|
|
.expect("posted lines are in range, so their sums are")
|
|
.into_iter()
|
|
.collect()
|
|
}
|
|
}
|