check / check (push) Canceled after 0s
Max-testing pass, step 8. The final mutation run left 112 survivors (89% caught). Three agents triaged them by file, by the playbook's table: spec the boundary then test it, a law rather than one more pinned value, assert the real value, never weaken a test. Every expected value is hand-computed. - reports.rs (35): 28 killed, chiefly cash flow (inclusive start date, each line's sign and label, a loss on disposal moving to investing, financing designation), general ledger and members' equity date boundaries, and the balanced() checks (a real report nudged by a cent must stop balancing). 7 equivalent: four >/>= after an early return on zero; two in dead code (removed in this commit); one sign of a zero cleaned on output. - ledger.rs, kernel.rs, journal.rs, money.rs (52, plus one new): 49 killed, including every replay_* mutant at the core level (ids, accumulation, status, vendor tags, out-of-order refusal), FX rates, 0%/100% deductible boundaries, a dividend sweep with no income, the legacy member rounding at close, a bill paid on its own date, a liability-account reconciliation, mixed-currency entries (via serde), ISO 4217 minor units, Display/Debug. 3 equivalent: zero refused before a </<= check; a period whose end is in a closed period refused earlier; columns(0). - schedules, tax, analysis, payouts, assets, form1099 (25): 23 killed (schedule length 1-600, recurring end on its start, frequency parsing and stepping, cost of goods in tax net, a zero payout, disposal on the purchase date, quarter starts, labels); 2 equivalent (zero adds zero; days_held is provably >= 1). Two small production cleanups the triage surfaced: kernel::columns(0) returned a negative-zero credit that would print "-0" (regression a_zero_movement_has_no_negative_zero_column, shown to fail before); and cash_flow computed a book value it never used. Spec lines added where a boundary wasn't specified (cash flow's inclusive start and line signs, members' equity start date, payout with no deposit, disposal on the purchase date, bill paid on its own date). `just mutants` now runs core and store tests (the store's replay tests), not the whole workspace, which rebuilt the viewer for every mutant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWVo7x3UHw5kwCUaWxiejX
212 lines
6.8 KiB
Rust
212 lines
6.8 KiB
Rust
//! Exact money: [`Decimal`] amounts paired with an ISO 4217 currency code.
|
|
//!
|
|
//! There is no float anywhere in this module, and there never will be.
|
|
//! [`Money`] arithmetic is checked: adding different currencies is an error,
|
|
//! not a guess.
|
|
|
|
use crate::LedgerError;
|
|
use rust_decimal::Decimal;
|
|
use serde::{Deserialize, Serialize};
|
|
use std::fmt;
|
|
|
|
/// An ISO 4217 alpha-3 currency code, stored as three uppercase ASCII bytes.
|
|
#[derive(Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
|
|
pub struct Currency([u8; 3]);
|
|
|
|
impl Currency {
|
|
/// US dollar.
|
|
pub const USD: Currency = Currency(*b"USD");
|
|
/// Euro.
|
|
pub const EUR: Currency = Currency(*b"EUR");
|
|
/// British pound.
|
|
pub const GBP: Currency = Currency(*b"GBP");
|
|
/// Swiss franc.
|
|
pub const CHF: Currency = Currency(*b"CHF");
|
|
/// Japanese yen.
|
|
pub const JPY: Currency = Currency(*b"JPY");
|
|
|
|
/// Parse and validate a three-letter code. Input is uppercased, so
|
|
/// `"usd"` and `"USD"` both work; `"US"` or `"USDD"` fail.
|
|
pub fn new(code: &str) -> Result<Self, LedgerError> {
|
|
let bytes = code.as_bytes();
|
|
if bytes.len() != 3 || !bytes.iter().all(|b| b.is_ascii_alphabetic()) {
|
|
return Err(LedgerError::InvalidCurrencyCode(code.to_string()));
|
|
}
|
|
let mut upper = [0u8; 3];
|
|
for (i, b) in bytes.iter().enumerate() {
|
|
upper[i] = b.to_ascii_uppercase();
|
|
}
|
|
Ok(Currency(upper))
|
|
}
|
|
|
|
/// The currency's minor units: how many decimal places its smallest
|
|
/// unit has (2 for USD's cents, 0 for JPY, 3 for KWD), or `None` for
|
|
/// codes ISO 4217 gives none (gold, SDRs). Unlisted codes are 2.
|
|
///
|
|
/// SOURCE: ISO 4217 list one, published 2026-09-17
|
|
/// (docs/spec/sources/iso-4217.md); generated from it, not typed in.
|
|
pub fn minor_units(&self) -> Option<u32> {
|
|
match self.code() {
|
|
"BIF" | "CLP" | "DJF" | "GNF" | "ISK" | "JPY" | "KMF" | "KRW" | "PYG" | "RWF"
|
|
| "UGX" | "UYI" | "VND" | "VUV" | "XAF" | "XOF" | "XPF" => Some(0),
|
|
"BHD" | "IQD" | "JOD" | "KWD" | "LYD" | "OMR" | "TND" => Some(3),
|
|
"CLF" | "UYW" => Some(4),
|
|
"XAG" | "XAU" | "XBA" | "XBB" | "XBC" | "XBD" | "XDR" | "XPD" | "XPT" | "XSU"
|
|
| "XTS" | "XUA" | "XXX" => None,
|
|
_ => Some(2),
|
|
}
|
|
}
|
|
|
|
/// The three-letter code, e.g. `"USD"`.
|
|
pub fn code(&self) -> &str {
|
|
std::str::from_utf8(&self.0).expect("currency codes are ASCII by construction")
|
|
}
|
|
}
|
|
|
|
impl fmt::Debug for Currency {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
write!(f, "Currency({})", self.code())
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for Currency {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
f.write_str(self.code())
|
|
}
|
|
}
|
|
|
|
/// An exact decimal amount in a specific currency.
|
|
///
|
|
/// `Money` is `Copy` and cheap: pass it by value. All arithmetic is checked
|
|
/// for currency agreement and returns [`LedgerError::CurrencyMismatch`]
|
|
/// rather than silently converting.
|
|
#[derive(Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
|
|
pub struct Money {
|
|
/// The exact amount. Never a float.
|
|
pub amount: Decimal,
|
|
/// The currency this amount is denominated in.
|
|
pub currency: Currency,
|
|
}
|
|
|
|
impl Money {
|
|
/// Build money from an exact decimal amount.
|
|
pub fn new(amount: Decimal, currency: Currency) -> Self {
|
|
Self { amount, currency }
|
|
}
|
|
|
|
/// Zero in the given currency.
|
|
pub fn zero(currency: Currency) -> Self {
|
|
Self {
|
|
amount: Decimal::ZERO,
|
|
currency,
|
|
}
|
|
}
|
|
|
|
/// True when the amount is exactly zero.
|
|
pub fn is_zero(&self) -> bool {
|
|
self.amount.is_zero()
|
|
}
|
|
|
|
fn check_currency(&self, other: &Money) -> Result<(), LedgerError> {
|
|
if self.currency != other.currency {
|
|
return Err(LedgerError::CurrencyMismatch {
|
|
expected: self.currency.code().to_string(),
|
|
found: other.currency.code().to_string(),
|
|
});
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
/// Add two money values. Fails on currency mismatch.
|
|
pub fn checked_add(self, rhs: Money) -> Result<Money, LedgerError> {
|
|
self.check_currency(&rhs)?;
|
|
Ok(Money::new(self.amount + rhs.amount, self.currency))
|
|
}
|
|
|
|
/// Subtract two money values. Fails on currency mismatch.
|
|
pub fn checked_sub(self, rhs: Money) -> Result<Money, LedgerError> {
|
|
self.check_currency(&rhs)?;
|
|
Ok(Money::new(self.amount - rhs.amount, self.currency))
|
|
}
|
|
}
|
|
|
|
impl fmt::Debug for Money {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
write!(f, "{} {}", self.amount, self.currency)
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for Money {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
write!(f, "{} {}", self.amount, self.currency)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
fn usd(amount: Decimal) -> Money {
|
|
Money::new(amount, Currency::USD)
|
|
}
|
|
|
|
fn d(cents: i64) -> Decimal {
|
|
Decimal::new(cents, 2)
|
|
}
|
|
|
|
#[test]
|
|
fn checked_arithmetic() {
|
|
assert_eq!(
|
|
usd(d(1050)).checked_add(usd(d(425))).unwrap().amount,
|
|
d(1475)
|
|
);
|
|
assert_eq!(
|
|
usd(d(1050)).checked_sub(usd(d(425))).unwrap().amount,
|
|
d(625)
|
|
);
|
|
// Subtraction is not division, and not addition.
|
|
assert_ne!(
|
|
usd(d(1000)).checked_sub(usd(d(200))).unwrap().amount,
|
|
d(500)
|
|
);
|
|
}
|
|
|
|
/// ISO 4217 list one (docs/spec/sources/iso-4217.md): one code from
|
|
/// each exponent class, and the codes with no minor unit.
|
|
#[test]
|
|
fn minor_units_follow_iso_4217() {
|
|
let units = |c: &str| Currency::new(c).unwrap().minor_units();
|
|
assert_eq!(units("USD"), Some(2));
|
|
assert_eq!(units("JPY"), Some(0));
|
|
assert_eq!(units("BHD"), Some(3));
|
|
assert_eq!(units("KWD"), Some(3));
|
|
assert_eq!(units("CLF"), Some(4));
|
|
assert_eq!(units("UYW"), Some(4));
|
|
assert_eq!(units("XAU"), None);
|
|
assert_eq!(units("XDR"), None);
|
|
}
|
|
|
|
#[test]
|
|
fn currency_and_money_print_their_code_and_amount() {
|
|
assert_eq!(Currency::new("usd").unwrap().to_string(), "USD");
|
|
assert_eq!(format!("{:?}", Currency::EUR), "Currency(EUR)");
|
|
assert_eq!(usd(d(1250)).to_string(), "12.50 USD");
|
|
assert_eq!(format!("{:?}", usd(d(-5))), "-0.05 USD");
|
|
}
|
|
|
|
#[test]
|
|
fn is_zero_means_exactly_zero() {
|
|
assert!(Money::zero(Currency::USD).is_zero());
|
|
assert!(usd(d(0)).is_zero());
|
|
assert!(!usd(d(1)).is_zero());
|
|
assert!(!usd(d(-1)).is_zero());
|
|
}
|
|
|
|
#[test]
|
|
fn checked_arithmetic_rejects_currency_mismatch() {
|
|
let eur = Money::new(d(100), Currency::EUR);
|
|
assert!(usd(d(100)).checked_add(eur).is_err());
|
|
assert!(usd(d(100)).checked_sub(eur).is_err());
|
|
}
|
|
}
|