drop scopes in order when dropping the virtual dom

packages/core/src/arena.rs

@@ -64,7 +64,7 @@ impl VirtualDom {
         self.elements.try_remove(el.0).map(|_| ())
     }
 
-    // Drop a scope and all its children
+    // Drop a scope without dropping its children
     //
     // Note: This will not remove any ids from the arena
     pub(crate) fn drop_scope(&mut self, id: ScopeId) {

packages/core/src/virtual_dom.rs

@@ -762,7 +762,11 @@ impl VirtualDom {
 
 impl Drop for VirtualDom {
     fn drop(&mut self) {
-        // Simply drop this scope which drops all of its children
-        self.drop_scope(ScopeId::ROOT);
+        // Drop all scopes in order of height
+        let mut scopes = self.scopes.drain().collect::<Vec<_>>();
+        scopes.sort_by_key(|scope| scope.context().height);
+        for scope in scopes.into_iter().rev() {
+            drop(scope);
+        }
     }
 }