Merge pull request #402 from Demonthos/tui_preformance

Tui performance improvements
This commit is contained in:
Jon Kelley authored and GitHub committed 2022-05-07 10:32:09 -04:00
commit dab24e9ad9
2 files changed
+64 -55

No files matched your search

+62 -53
View File
@@ -335,81 +335,90 @@ impl InnerInputState {
{ {
// mouseup // mouseup
let mut will_bubble = FxHashSet::default(); if released {
for node in dom.get_listening_sorted("mouseup") { let mut will_bubble = FxHashSet::default();
let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap(); for node in dom.get_listening_sorted("mouseup") {
let currently_contains = layout_contains_point(node_layout, new_pos); let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap();
let currently_contains = layout_contains_point(node_layout, new_pos);
if currently_contains && released { if currently_contains {
try_create_event( try_create_event(
"mouseup", "mouseup",
Arc::new(prepare_mouse_data(mouse_data, node_layout)), Arc::new(prepare_mouse_data(mouse_data, node_layout)),
&mut will_bubble, &mut will_bubble,
resolved_events, resolved_events,
node, node,
dom, dom,
); );
}
} }
} }
} }
{ {
// click // click
let mut will_bubble = FxHashSet::default(); if mouse_data.button == 0 && released {
for node in dom.get_listening_sorted("click") { let mut will_bubble = FxHashSet::default();
let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap(); for node in dom.get_listening_sorted("click") {
let currently_contains = layout_contains_point(node_layout, new_pos); let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap();
let currently_contains = layout_contains_point(node_layout, new_pos);
if currently_contains && released && mouse_data.button == 0 { if currently_contains {
try_create_event( try_create_event(
"click", "click",
Arc::new(prepare_mouse_data(mouse_data, node_layout)), Arc::new(prepare_mouse_data(mouse_data, node_layout)),
&mut will_bubble, &mut will_bubble,
resolved_events, resolved_events,
node, node,
dom, dom,
); );
}
} }
} }
} }
{ {
// contextmenu // contextmenu
let mut will_bubble = FxHashSet::default(); if mouse_data.button == 2 && released {
for node in dom.get_listening_sorted("contextmenu") { let mut will_bubble = FxHashSet::default();
let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap(); for node in dom.get_listening_sorted("contextmenu") {
let currently_contains = layout_contains_point(node_layout, new_pos); let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap();
let currently_contains = layout_contains_point(node_layout, new_pos);
if currently_contains && released && mouse_data.button == 2 { if currently_contains {
try_create_event( try_create_event(
"contextmenu", "contextmenu",
Arc::new(prepare_mouse_data(mouse_data, node_layout)), Arc::new(prepare_mouse_data(mouse_data, node_layout)),
&mut will_bubble, &mut will_bubble,
resolved_events, resolved_events,
node, node,
dom, dom,
); );
}
} }
} }
} }
{ {
// wheel // wheel
let mut will_bubble = FxHashSet::default(); if let Some(w) = wheel_data {
for node in dom.get_listening_sorted("wheel") { if wheel_delta != 0.0 {
let node_layout = layout.layout(node.state.layout.node.unwrap()).unwrap(); let mut will_bubble = FxHashSet::default();
let currently_contains = layout_contains_point(node_layout, new_pos); for node in dom.get_listening_sorted("wheel") {
let node_layout =
layout.layout(node.state.layout.node.unwrap()).unwrap();
let currently_contains = layout_contains_point(node_layout, new_pos);
if let Some(w) = wheel_data { if currently_contains {
if currently_contains && wheel_delta != 0.0 { try_create_event(
try_create_event( "wheel",
"wheel", Arc::new(w.clone()),
Arc::new(w.clone()), &mut will_bubble,
&mut will_bubble, resolved_events,
resolved_events, node,
node, dom,
dom, );
); }
} }
} }
} }
+2 -2
View File
@@ -129,7 +129,7 @@ fn render_vdom(
terminal.clear().unwrap(); terminal.clear().unwrap();
} }
let to_rerender: fxhash::FxHashSet<usize> = vec![0].into_iter().collect(); let mut to_rerender: fxhash::FxHashSet<usize> = vec![0].into_iter().collect();
let mut resized = true; let mut resized = true;
loop { loop {
@@ -226,7 +226,7 @@ fn render_vdom(
// update the style and layout // update the style and layout
let mut any_map = AnyMap::new(); let mut any_map = AnyMap::new();
any_map.insert(stretch.clone()); any_map.insert(stretch.clone());
let _to_rerender = rdom.update_state(vdom, to_update, any_map).unwrap(); to_rerender = rdom.update_state(vdom, to_update, any_map).unwrap();
} }
} }